Skip to content

Commit 6459bd2

Browse files
committed
fix: Correct printf format specifiers for unsigned integers
This commit addresses cppcheck warnings about mismatched printf format specifiers (invalidPrintfArgType_sint). The format specifiers %i and %d expect signed integers (int) but the variables being passed are unsigned integers (uint32_t, unsigned). This mismatch can lead to undefined behavior and incorrect output formatting. Changes made: - utils/kmstouch.cpp: Changed %i to %u for event code formatting - utils/kmstouch.cpp: Changed %d to %u for event type and property type formatting - utils/kmsview.cpp: Changed %d to %u for frame number formatting These fixes ensure proper type safety in printf formatting and prevent potential undefined behavior when printing unsigned integer values.
1 parent 21755e6 commit 6459bd2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

utils/kmstouch.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static void print_code_bits(struct libevdev* dev, unsigned int type, unsigned in
6464
if (!libevdev_has_event_code(dev, type, i))
6565
continue;
6666

67-
printf(" Event code %i (%s)\n", i, libevdev_event_code_get_name(type, i));
67+
printf(" Event code %u (%s)\n", i, libevdev_event_code_get_name(type, i));
6868
if (type == EV_ABS)
6969
print_abs_bits(dev, i);
7070
}
@@ -78,7 +78,7 @@ static void print_bits(struct libevdev* dev)
7878
if (!libevdev_has_event_type(dev, i))
7979
continue;
8080

81-
printf(" Event type %d (%s)\n", i, libevdev_event_type_get_name(i));
81+
printf(" Event type %u (%s)\n", i, libevdev_event_type_get_name(i));
8282

8383
switch (i) {
8484
case EV_KEY:
@@ -120,7 +120,7 @@ static void print_props(struct libevdev* dev)
120120
if (!libevdev_has_property(dev, i))
121121
continue;
122122

123-
printf(" Property type %d (%s)\n", i, libevdev_property_get_name(i));
123+
printf(" Property type %u (%s)\n", i, libevdev_property_get_name(i));
124124
}
125125
}
126126

utils/kmsview.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ int main(int argc, char** argv)
9999
printf("file size %u, frame size %u, frames %u\n", fsize, frame_size, num_frames);
100100

101101
for (unsigned i = 0; i < num_frames; ++i) {
102-
printf("frame %d", i);
102+
printf("frame %u", i);
103103
fflush(stdout);
104104
read_frame(is, fb, crtc, plane);
105105
if (!time) {

0 commit comments

Comments
 (0)