Audible Click when triggered if time shifting initially

[tinkerlevu]

Hello again 😅

There's a small click that can be heard when the plugin is triggered if I'm applying a time shift from the start.

this isn't an issue when in sync mode, even if the sample is lined up exactly with the start of the graph. So far I've just tested it with audio trigger and not midi trigger.

if you look closely at the start of the analysis graph I think there's a little bit of green there indicating the click

I'm running the latest release of the plugin.

_{(really appreciate all the work that has been done so far btw 😇)}

[tinkerlevu]

Update: I don't think this is an issue in midi trigger mode, just audio trigger

[tiagolr]

Haven't had time to go through these issues yet, hopefully today or next couple of days.

[tinkerlevu]

ahhhh no wait I think everything is fine, it might just be an issue with the settings triggering the audio, whoops 😅

if the threshold is set too high some audio might come in first before the time shifting is triggered.

Unfortunately it's kinda hard to set the threshold low enough for sounds that have some sort of ramp up without causing spurious re-triggers later in the sample:

mb if issue #12 is fixed first I can try playing around with threshold and sensitivity better for certain sounds to see if the triggering and settings is the issue.

As far as I can tell using the daw controls it always produces some sort of click even in drum mode until the threshold is so low it causes retriggers.

or mb some sort of "trigger reset time" or look ahead setting would work for sounds like this.

😅😅😅😅

[tiagolr]

Looks awful, will be looking soon, hopefully not an issue with JUCE + wayland.

[tinkerlevu]

ah okay so since #12 has been fixed I've been able to play with it properly and I think everything is functioning as intended.

Most clicks go away when the offset is increased/decreased.

But the offset range might have to be extended, the plugin does struggle with some sounds that have a more noticeable ramp up:

if I edit the start to be more abrupt then everything works fine:

I've attached the audio files shown if you want to look at them and measure the timings:

Doesnt work.wav
Needs large offset.wav
absolutely fine.wav

[tinkerlevu]

Sidenote, here's another tricky sound btw:

but I think this would be a better candidate for midi triggering if I want the delay to only activate on start of the sound tbh, since the second peak is louder than the first

I've attached the file if you want to play around with it anyways:

tricky sound.wav

[tiagolr]

I tried your Doesnt work file

I used Gate-12 instead that has an option to output midi on audio trigger (not sure if TIME-12 has that same option)

The first midi event is using the default Audio settings
The second is using lower threshold and offset -5ms (minimum)

Now I don't notice anything wrong, could you explain where you would expect those midi notes to hit? Looks in order to me.

Also playing with settings like threshold, sensitivity and algorithm (drums vs simple) may help.

[tinkerlevu]

Update: found a setting that causes a click even with the very abrupt sound that worked the best

adjusting the trigger settings does improve things, but there's always a very noticeable click

[tiagolr]

Can you send the wav file for that?

[tinkerlevu]

absolutely fine.wav

as it's the same one as the message above, it's just when I played around with graph shape it started producing that very audible click.

[tiagolr]

I mean a recording of the clicks with the TIME-12 instance, that way I can have a close look at the waveform at least.

Just realized yes I can try with you sample and using the same settings, will try.

[tiagolr]

You're right, if it is what I think it is a loud click when the onset triggers but before the sound starts.

I'll have to check, maybe I should clear the buffers when a trigger happens or something.

Can be complicated I have to make sure it does not break anything else.

[tinkerlevu]

in regards to #13 (comment)

the file Doesnt work.wav passes a little bit of it's initial sound through before triggering, as shown by this little green sliver on the analysis display here:

this sliver increases as I make offset positive, and decreases as I make offset negative, but I am unable to make offset low enough to make it go away.

if I try adjusting threshold or filtering settings I either end up causing retriggers or failing to trigger.

with Needs large offset.wav it also produces the same click, but with -3 to -4ms offset it goes away.

(here's the full capture for the above photo for reference:)

[tiagolr]

I am noticing this issue, yes can confirm there is something wrong, will let you know when I make progress. Its a very loud click / sound going through.

[tinkerlevu]

yes, playing with it more, even the absolutely fine.wav file produces a small click when I drag the initial delay all the way down:

full capture for context:

I needed to get these settings just right to get the clicks to go away until I dragged initial delay all the way to the bottom.

I'm not sure if this is an offset range issue anymore 😅

but yes I'll defer to you on this 😇👍