feat: Add ResizeExecTtyAsync to IExecOperations (#68)

Co-authored-by: Andre Hofmeister <[email protected]>

Author: j4587698

src/Docker.DotNet/Endpoints/ExecOperations.cs

@@ -60,4 +60,22 @@ public async Task<MultiplexedStream> StartContainerExecAsync(string id, Containe
 
         return new MultiplexedStream(response, !parameters.TTY);
     }
+
+    public async Task ResizeExecTtyAsync(string id, ContainerResizeParameters parameters, CancellationToken cancellationToken = default)
+    {
+        if (string.IsNullOrEmpty(id))
+        {
+            throw new ArgumentNullException(nameof(id));
+        }
+
+        if (parameters == null)
+        {
+            throw new ArgumentNullException(nameof(parameters));
+        }
+
+        var queryParameters = new QueryString<ContainerResizeParameters>(parameters);
+
+        await _client.MakeRequestAsync([NoSuchContainerHandler], HttpMethod.Post, $"exec/{id}/resize", queryParameters, cancellationToken)
+            .ConfigureAwait(false);
+    }
 }

src/Docker.DotNet/Endpoints/IExecOperations.cs

@@ -7,4 +7,6 @@ public interface IExecOperations
     Task<ContainerExecCreateResponse> CreateContainerExecAsync(string id, ContainerExecCreateParameters parameters, CancellationToken cancellationToken = default);
 
     Task<MultiplexedStream> StartContainerExecAsync(string id, ContainerExecStartParameters parameters, CancellationToken cancellationToken = default);
+
+    Task ResizeExecTtyAsync(string id, ContainerResizeParameters parameters, CancellationToken cancellationToken = default);
 }

src/Docker.DotNet/Models/ContainerResizeParameters.Generated.cs

@@ -2,10 +2,10 @@ namespace Docker.DotNet.Models
 {
     public class ContainerResizeParameters // (main.ContainerResizeParameters)
     {
-        [QueryStringParameter("h", false)]
-        public long? Height { get; set; }
+        [QueryStringParameter("h", true)]
+        public long Height { get; set; }
 
-        [QueryStringParameter("w", false)]
-        public long? Width { get; set; }
+        [QueryStringParameter("w", true)]
+        public long Width { get; set; }
     }
 }

test/Docker.DotNet.Tests/IExecOperationsTests.cs

@@ -0,0 +1,95 @@
+namespace Docker.DotNet.Tests;
+
+[Collection(nameof(TestCollection))]
+public class IExecOperationsTests
+{
+    private readonly TestFixture _testFixture;
+    private readonly ITestOutputHelper _testOutputHelper;
+
+    public IExecOperationsTests(TestFixture testFixture, ITestOutputHelper testOutputHelper)
+    {
+        _testFixture = testFixture;
+        _testOutputHelper = testOutputHelper;
+    }
+
+    [Fact]
+    public async Task ResizeExecTtyAsync_RunningExec_Succeeds()
+    {
+        // Given: a running container with a TTY exec session
+        var createContainerResponse = await _testFixture.DockerClient.Containers.CreateContainerAsync(
+            new CreateContainerParameters
+            {
+                Image = _testFixture.Image.ID,
+                Entrypoint = CommonCommands.SleepInfinity
+            },
+            _testFixture.Cts.Token
+        );
+
+        await _testFixture.DockerClient.Containers.StartContainerAsync(
+            createContainerResponse.ID,
+            new ContainerStartParameters(),
+            _testFixture.Cts.Token
+        );
+
+        var execCreateResponse = await _testFixture.DockerClient.Exec.CreateContainerExecAsync(
+            createContainerResponse.ID,
+            new ContainerExecCreateParameters
+            {
+                AttachStdout = true,
+                AttachStderr = true,
+                AttachStdin = true,
+                TTY = true,
+                Cmd = ["/bin/sh"]
+            },
+            _testFixture.Cts.Token
+        );
+
+        // Start the exec to make it running (resize only works on a running exec)
+        using var stream = await _testFixture.DockerClient.Exec.StartContainerExecAsync(
+            execCreateResponse.ID,
+            new ContainerExecStartParameters
+            {
+                TTY = true
+            },
+            _testFixture.Cts.Token
+        );
+
+        // When: resize the exec TTY
+        await _testFixture.DockerClient.Exec.ResizeExecTtyAsync(
+            execCreateResponse.ID,
+            new ContainerResizeParameters
+            {
+                Height = 48,
+                Width = 80
+            },
+            _testFixture.Cts.Token
+        );
+
+        // Then: no exception means success
+        _testOutputHelper.WriteLine("ResizeExecTtyAsync succeeded for running exec session.");
+
+        // Verify exec is still running
+        var execInspect = await _testFixture.DockerClient.Exec.InspectContainerExecAsync(
+            execCreateResponse.ID,
+            _testFixture.Cts.Token
+        );
+
+        Assert.True(execInspect.Running);
+    }
+
+    [Fact]
+    public async Task ResizeExecTtyAsync_NonExistentExecId_ThrowsException()
+    {
+        await Assert.ThrowsAsync<DockerContainerNotFoundException>(
+            () => _testFixture.DockerClient.Exec.ResizeExecTtyAsync(
+                Guid.NewGuid().ToString("N"),
+                new ContainerResizeParameters
+                {
+                    Height = 24,
+                    Width = 80
+                },
+                _testFixture.Cts.Token
+            )
+        );
+    }
+}

tools/specgen/modeldefs.go

@@ -132,8 +132,8 @@ type ContainerRenameParameters struct {
 
 // ContainerResizeParameters for POST /containers/(id)/resize
 type ContainerResizeParameters struct {
-	Height int `rest:"query,h"`
-	Width  int `rest:"query,w"`
+	Height int `rest:"query,h,required"`
+	Width  int `rest:"query,w,required"`
 }
 
 // ContainerRestartParameters for POST /containers/(id)/restart