chore(shield): defer waiter image auto-bump to follow-up PR

The waiter image now points at quay.io/sysdig/kubectl, while the rest of
.github/updatecli.d/config-update-kubectl-image.yaml still tracks
quay.io/sysdig/sysdig-kubectl. Wiring shield into the existing target would
have it consume tags from the wrong image.

Drop the bumpShieldChart target and the matching values.yaml comment; the
chart and the updatecli config will be reconciled together in a separate PR
that migrates all charts to sysdig/kubectl.

Author: francesco-furlan

.github/updatecli.d/config-update-kubectl-image.yaml

@@ -70,12 +70,3 @@ targets:
       name: "charts/rapid-response"
       key: "$.tests.image.tag"
       versionincrement: patch
-
-  bumpShieldChart:
-    name: "bump the sysdig/sysdig-kubectl image reference in the shield chart"
-    kind: helmchart
-    scmid: github
-    spec:
-      name: "charts/shield"
-      key: "$.gke_autopilot.allowlist_waiter.image.tag"
-      versionincrement: patch

charts/shield/README.md

@@ -300,7 +300,7 @@ The following table lists the configurable parameters of the `shield` chart and
 | gke_autopilot.allowlist_waiter.service_account_name                                                                                    | Override the name of the waiter ServiceAccount (defaults to <host fullname>-allowlist-waiter)                                                                                                                                                                                                                                                                                                                    | <code></code>                                                                                                                                                                                                                                                                                                                                                                                                                                |
 | gke_autopilot.allowlist_waiter.image.registry                                                                                          | The registry where the kubectl image is stored                                                                                                                                                                                                                                                                                                                                                                   | <code>quay.io</code>                                                                                                                                                                                                                                                                                                                                                                                                                         |
 | gke_autopilot.allowlist_waiter.image.repository                                                                                        | The repository where the kubectl image is stored                                                                                                                                                                                                                                                                                                                                                                 | <code>sysdig/kubectl</code>                                                                                                                                                                                                                                                                                                                                                                                                                  |
-| gke_autopilot.allowlist_waiter.image.tag                                                                                               | The tag for the kubectl image (auto-bumped by .github/updatecli.d/config-update-kubectl-image.yaml)                                                                                                                                                                                                                                                                                                              | <code>1.34.3-1.6.21</code>                                                                                                                                                                                                                                                                                                                                                                                                                   |
+| gke_autopilot.allowlist_waiter.image.tag                                                                                               | The tag for the kubectl image                                                                                                                                                                                                                                                                                                                                                                                    | <code>1.34.3-1.6.21</code>                                                                                                                                                                                                                                                                                                                                                                                                                   |
 | gke_autopilot.allowlist_waiter.image.pull_policy                                                                                       | The pull policy for the kubectl image                                                                                                                                                                                                                                                                                                                                                                            | <code>IfNotPresent</code>                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | gke_autopilot.allowlist_waiter.image.pull_secrets                                                                                      | The pull secrets for the kubectl image                                                                                                                                                                                                                                                                                                                                                                           | <code>[]</code>                                                                                                                                                                                                                                                                                                                                                                                                                              |
 | gke_autopilot.allowlist_waiter.resources.limits.cpu                                                                                    | The CPU limit for the allowlist waiter Job                                                                                                                                                                                                                                                                                                                                                                       | <code>100m</code>                                                                                                                                                                                                                                                                                                                                                                                                                            |

charts/shield/values.yaml

@@ -667,7 +667,7 @@ gke_autopilot:
       registry: quay.io
       # The repository where the kubectl image is stored
       repository: sysdig/kubectl
-      # The tag for the kubectl image (auto-bumped by .github/updatecli.d/config-update-kubectl-image.yaml)
+      # The tag for the kubectl image
       tag: 1.34.3-1.6.21
       # The pull policy for the kubectl image
       pull_policy: IfNotPresent