Fix non-descript errors when sending template previews

Author: synzen

services/backend-api/client/src/features/feedConnections/hooks/useTestSendFlow.tsx

@@ -137,9 +137,11 @@ export const useTestSendFlow = ({
         });
       }
     } catch (err) {
+      const errorMessage =
+        (err as Error).message || "Failed to send test article. Please try again.";
       setTestSendFeedback({
         status: "error",
-        message: "Failed to send test article. Please try again.",
+        message: errorMessage,
       });
     } finally {
       setIsTestSending(false);

services/backend-api/client/src/features/templates/components/TemplateGalleryModal/index.tsx

@@ -690,12 +690,7 @@ const TemplateGalleryModalComponent = (props: TemplateGalleryModalProps) => {
                   {testSendFeedback.status === "error" && (
                     <Alert status="error" borderRadius="md" size="sm">
                       <AlertIcon />
-                      <HStack justifyContent="space-between" flex={1}>
-                        <AlertDescription>{testSendFeedback.message}</AlertDescription>
-                        <Button size="sm" variant="outline" onClick={onTestSend}>
-                          Retry
-                        </Button>
-                      </HStack>
+                      <AlertDescription>{testSendFeedback.message}</AlertDescription>
                     </Alert>
                   )}
                 </Box>

services/backend-api/src/features/feed-connections/filters/add-discord-channel-connection.filter.ts

@@ -5,6 +5,7 @@ import { StandardException } from "../../../common/exceptions/standard-exception
 import { StandardBaseExceptionFilter } from "../../../common/filters/standard-exception-filter";
 import { WebhookMissingPermissionsException } from "../../discord-webhooks/exceptions";
 import {
+  MissingChannelException,
   MissingChannelPermissionsException,
   UserMissingManageGuildException,
 } from "../../feeds/exceptions";
@@ -23,6 +24,10 @@ export const ADD_DISCORD_CHANNEL_CONNECTION_ERROR_CODES: Record<
     status: HttpStatus.BAD_REQUEST,
     code: ApiErrorCode.FEED_MISSING_CHANNEL,
   },
+  [MissingChannelException.name]: {
+    status: HttpStatus.BAD_REQUEST,
+    code: ApiErrorCode.FEED_MISSING_CHANNEL,
+  },
   [DiscordChannelPermissionsException.name]: {
     status: HttpStatus.BAD_REQUEST,
     code: ApiErrorCode.FEED_MISSING_CHANNEL_PERMISSION,

services/backend-api/src/features/feed-connections/filters/create-discord-channel-test-article.filter.ts

@@ -8,33 +8,40 @@ import {
   InvalidFiltersRegexException,
   InvalidPreviewCustomPlaceholdersRegexException,
 } from "../../../services/feed-fetcher/exceptions";
+import { MissingChannelException } from "../../feeds/exceptions";
 import { FeedConnectionNotFoundException } from "../exceptions";
 
-const ERROR_CODES: Record<string, { status: HttpStatus; code: ApiErrorCode }> =
-  {
-    [FeedConnectionNotFoundException.name]: {
-      status: HttpStatus.NOT_FOUND,
-      code: ApiErrorCode.FEED_CONNECTION_NOT_FOUND,
-    },
-    [FeedArticleNotFoundException.name]: {
-      status: HttpStatus.NOT_FOUND,
-      code: ApiErrorCode.FEED_ARTICLE_NOT_FOUND,
-    },
-    [InvalidPreviewCustomPlaceholdersRegexException.name]: {
-      status: HttpStatus.UNPROCESSABLE_ENTITY,
-      code: ApiErrorCode.INVALID_CUSTOM_PLACEHOLDERS_REGEX_PREVIEW_INPUT,
-    },
-    [InvalidFiltersRegexException.name]: {
-      status: HttpStatus.UNPROCESSABLE_ENTITY,
-      code: ApiErrorCode.INVALID_FILTERS_REGEX,
-    },
-    [InvalidComponentsV2Exception.name]: {
-      status: HttpStatus.BAD_REQUEST,
-      code: ApiErrorCode.FEED_INVALID_COMPONENTS_V2,
-    },
-  };
+export const CREATE_DISCORD_CHANNEL_TEST_ARTICLE_ERROR_CODES: Record<
+  string,
+  { status: HttpStatus; code: ApiErrorCode }
+> = {
+  [FeedConnectionNotFoundException.name]: {
+    status: HttpStatus.NOT_FOUND,
+    code: ApiErrorCode.FEED_CONNECTION_NOT_FOUND,
+  },
+  [FeedArticleNotFoundException.name]: {
+    status: HttpStatus.NOT_FOUND,
+    code: ApiErrorCode.FEED_ARTICLE_NOT_FOUND,
+  },
+  [InvalidPreviewCustomPlaceholdersRegexException.name]: {
+    status: HttpStatus.UNPROCESSABLE_ENTITY,
+    code: ApiErrorCode.INVALID_CUSTOM_PLACEHOLDERS_REGEX_PREVIEW_INPUT,
+  },
+  [InvalidFiltersRegexException.name]: {
+    status: HttpStatus.UNPROCESSABLE_ENTITY,
+    code: ApiErrorCode.INVALID_FILTERS_REGEX,
+  },
+  [InvalidComponentsV2Exception.name]: {
+    status: HttpStatus.BAD_REQUEST,
+    code: ApiErrorCode.FEED_INVALID_COMPONENTS_V2,
+  },
+  [MissingChannelException.name]: {
+    status: HttpStatus.BAD_REQUEST,
+    code: ApiErrorCode.FEED_MISSING_CHANNEL,
+  },
+};
 
 @Catch(StandardException)
 export class CreateDiscordChannelTestArticleFilter extends StandardBaseExceptionFilter {
-  exceptions = ERROR_CODES;
+  exceptions = CREATE_DISCORD_CHANNEL_TEST_ARTICLE_ERROR_CODES;
 }

services/backend-api/src/features/feeds/feeds.service.ts

@@ -182,7 +182,23 @@ export class FeedsService {
     userAccessToken: string;
     skipBotPermissionAssertions?: boolean;
   }) {
-    const channel = await this.discordApiService.getChannel(channelId);
+    let channel;
+
+    try {
+      channel = await this.discordApiService.getChannel(channelId);
+    } catch (err) {
+      if (err instanceof DiscordAPIError) {
+        if (err.statusCode === HttpStatus.NOT_FOUND) {
+          throw new MissingChannelException();
+        }
+
+        if (err.statusCode === HttpStatus.FORBIDDEN) {
+          throw new MissingChannelPermissionsException();
+        }
+      }
+
+      throw err;
+    }
 
     const { isManager } = await this.discordAuthService.userManagesGuild(
       userAccessToken,

services/backend-api/src/features/user-feeds/filters/index.ts

@@ -1,3 +1,4 @@
 export * from "./retry-user-feed-exception.filter";
 export * from "./create-user-feed-management-invite-exception.filter";
 export * from "./get-user-feed-articles.exception.filter";
+export * from "./send-test-article-exception.filter";

services/backend-api/src/features/user-feeds/filters/send-test-article-exception.filter.ts

@@ -0,0 +1,19 @@
+import { Catch, HttpStatus } from "@nestjs/common";
+import { ApiErrorCode } from "../../../common/constants/api-errors";
+import { StandardException } from "../../../common/exceptions/standard-exception.exception";
+import { StandardBaseExceptionFilter } from "../../../common/filters/standard-exception-filter";
+import { ADD_DISCORD_CHANNEL_CONNECTION_ERROR_CODES } from "../../feed-connections/filters/add-discord-channel-connection.filter";
+import { CREATE_DISCORD_CHANNEL_TEST_ARTICLE_ERROR_CODES } from "../../feed-connections/filters/create-discord-channel-test-article.filter";
+
+export const SEND_TEST_ARTICLE_ERROR_CODES: Record<
+  string,
+  { status: HttpStatus; code: ApiErrorCode }
+> = {
+  ...CREATE_DISCORD_CHANNEL_TEST_ARTICLE_ERROR_CODES,
+  ...ADD_DISCORD_CHANNEL_CONNECTION_ERROR_CODES,
+};
+
+@Catch(StandardException)
+export class SendTestArticleFilter extends StandardBaseExceptionFilter {
+  exceptions = SEND_TEST_ARTICLE_ERROR_CODES;
+}

services/backend-api/src/features/user-feeds/user-feeds.controller.ts

@@ -23,10 +23,7 @@ import { DiscordOAuth2Guard } from "../discord-auth/guards/DiscordOAuth2.guard";
 import { FastifyReply, FastifyRequest } from "fastify";
 import { SessionAccessToken } from "../discord-auth/types/SessionAccessToken.type";
 
-import {
-  ADD_DISCORD_CHANNEL_CONNECTION_ERROR_CODES,
-  CreateDiscordChannelTestArticleFilter,
-} from "../feed-connections/filters";
+import { ADD_DISCORD_CHANNEL_CONNECTION_ERROR_CODES } from "../feed-connections/filters";
 import { FeedConnectionsDiscordChannelsService } from "../feed-connections/feed-connections-discord-channels.service";
 import { FeedsService } from "../feeds/feeds.service";
 import {
@@ -62,6 +59,7 @@ import {
 import {
   GetUserFeedArticlesExceptionFilter,
   RETRY_USER_FEED_ERROR_CODES,
+  SendTestArticleFilter,
 } from "./filters";
 import { RestoreLegacyUserFeedExceptionFilter } from "./filters/restore-legacy-user-feed-exception.filter";
 import { GetUserFeedsPipe, GetUserFeedsPipeOutput } from "./pipes";
@@ -241,7 +239,7 @@ export class UserFeedsController {
   }
 
   @Post("/:feedId/test-send")
-  @UseFilters(CreateDiscordChannelTestArticleFilter)
+  @UseFilters(SendTestArticleFilter)
   async sendTestArticle(
     @Param(
       "feedId",