Merge pull request #553 from sylhare/release-2.5.1

sylhare · web-flow · commit 74eadf6fa115 · 2026-04-01T16:31:24.000-04:00
Release v2.5.1
diff --git a/.github/cli/src/release.ts b/.github/cli/src/release.ts
@@ -48,20 +48,11 @@ export function updatePackageLockJson(filePath: string, newVersion: string): voi
   });
 }
 
-export function updateGemBuildWorkflow(filePath: string, newVersion: string): void {
-  updateVersionInFile(
-    filePath,
-    /(gem install type-on-strap --version ")[^"]+(")/,
-    `$1${newVersion}$2`
-  );
-}
-
 export function release(newVersion: string, root: string): void {
   updateGemspec(path.join(root, 'type-on-strap.gemspec'), newVersion);
   updateDefaultHtml(path.join(root, '_layouts/default.html'), newVersion);
   updatePackageJson(path.join(root, 'package.json'), newVersion);
   updatePackageLockJson(path.join(root, 'package-lock.json'), newVersion);
-  updateGemBuildWorkflow(path.join(root, '.github/workflows/gem-build.yml'), newVersion);
   logger.success(`Version bumped to ${newVersion}`);
 }
 
diff --git a/.github/cli/test/release.test.ts b/.github/cli/test/release.test.ts
@@ -5,7 +5,6 @@ import {
   parseVersion,
   release,
   updateDefaultHtml,
-  updateGemBuildWorkflow,
   updateGemspec,
   updatePackageJson,
   updatePackageLockJson,
@@ -109,30 +108,13 @@ describe('release.ts', () => {
     });
   });
 
-  describe('updateGemBuildWorkflow()', () => {
-    test('replaces version in gem install command', () => {
-      const content = 'gem install type-on-strap --version "2.4.11" --source "https://rubygems.pkg.github.com/sylhare"\n';
-      jest.spyOn(fs, 'readFileSync').mockReturnValue(content as any);
-      const write = jest.spyOn(fs, 'writeFileSync').mockImplementation(() => {
-      });
-
-      updateGemBuildWorkflow('/fake/.github/workflows/gem-build.yml', '2.6.0');
-
-      expect(write).toHaveBeenCalledWith(
-        '/fake/.github/workflows/gem-build.yml',
-        'gem install type-on-strap --version "2.6.0" --source "https://rubygems.pkg.github.com/sylhare"\n'
-      );
-    });
-  });
-
   describe('release()', () => {
     test('calls all updaters and logs the new version', () => {
       const current = '2.4.11';
       jest.spyOn(fs, 'readFileSync').mockImplementation((filePath: unknown) => {
         const p = filePath as string;
         if (p.endsWith('.gemspec')) return `spec.version = "${current}"` as any;
         if (p.endsWith('default.html')) return `Type on Strap jekyll theme v${current}` as any;
-        if (p.endsWith('gem-build.yml')) return `gem install type-on-strap --version "${current}"` as any;
         return `{"version":"${current}","packages":{"":{"version":"${current}"}}}` as any;
       });
       jest.spyOn(fs, 'writeFileSync').mockImplementation(() => {
@@ -146,7 +128,6 @@ describe('release.ts', () => {
       expect(fs.writeFileSync).toHaveBeenCalledWith(expect.stringContaining('default.html'), expect.any(String));
       expect(fs.writeFileSync).toHaveBeenCalledWith(expect.stringContaining('package.json'), expect.any(String));
       expect(fs.writeFileSync).toHaveBeenCalledWith(expect.stringContaining('package-lock.json'), expect.any(String));
-      expect(fs.writeFileSync).toHaveBeenCalledWith(expect.stringContaining('gem-build.yml'), expect.any(String));
     });
   });
 });
diff --git a/.github/workflows/gem-build.yml b/.github/workflows/gem-build.yml
@@ -41,4 +41,4 @@ jobs:
       - name: GPR
         run: |
           gem cleanup type-on-strap
-          gem install type-on-strap --version "2.4.11" --source "https://rubygems.pkg.github.com/sylhare"
+          gem install type-on-strap --source "https://rubygems.pkg.github.com/sylhare"
diff --git a/_layouts/default.html b/_layouts/default.html
@@ -1,6 +1,6 @@
 <!DOCTYPE html>
 <!--
-    Type on Strap jekyll theme v2.5.0
+    Type on Strap jekyll theme v2.5.1
     Theme free for personal and commercial use under the MIT license
     https://github.com/sylhare/Type-on-Strap/blob/master/LICENSE
 -->
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "type-on-strap-helper",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "CLI utilities for the Type on Strap jekyll theme",
   "scripts": {
     "post": "tsx .github/cli/src/post.ts",
diff --git a/type-on-strap.gemspec b/type-on-strap.gemspec
@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "type-on-strap"
-  spec.version       = "2.5.0"
+  spec.version       = "2.5.1"
   spec.authors       = ["Sylhare", "Rohan Chandra"]
   spec.email         = ["sylhare@outlook.com", "hellorohan@outlook.com"]
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "type-on-strap-helper",`
`3`		`- "version": "2.5.0",`
	`3`	`+ "version": "2.5.1",`
`4`	`4`	`"description": "CLI utilities for the Type on Strap jekyll theme",`
`5`	`5`	`"scripts": {`
`6`	`6`	`"post": "tsx .github/cli/src/post.ts",`