fix clippy warnings

Author: sudokoi

src/app_deps.rs

@@ -70,15 +70,14 @@ pub trait RateLimiterInterface: Send + Sync {
     fn release(&mut self);
 }
 
+#[derive(Default)]
 pub struct RealRateLimiter {
     inner: rate_limit::RateLimiter,
 }
 
 impl RealRateLimiter {
     pub fn new() -> Self {
-        Self {
-            inner: rate_limit::RateLimiter::new(),
-        }
+        Self::default()
     }
 }
 

src/paths.rs

@@ -228,9 +228,7 @@ mod tests {
                         .join("github-secrets")
                         .join("config.toml");
                     let default_xdg_canonical = default_xdg_config.canonicalize().ok();
-                    default_xdg_canonical
-                        .as_ref()
-                        .map_or(false, |default| default == found_can)
+                    default_xdg_canonical.is_some_and(|default| default == *found_can)
                 } else {
                     false
                 }

tests/prompt_interaction_test.rs

@@ -51,26 +51,24 @@ fn test_prompt_secrets_interaction_flow() {
     // 3. Esc (to finish)
     // 4. "y" (confirm exit)
 
-    let mut events = Vec::new();
-
-    // Type "KEY1"
-    events.push(char_event('K'));
-    events.push(char_event('E'));
-    events.push(char_event('Y'));
-    events.push(char_event('1'));
-    events.push(key_event(KeyCode::Enter));
-
-    // Type "VAL1"
-    events.push(char_event('V'));
-    events.push(char_event('A'));
-    events.push(char_event('L'));
-    events.push(char_event('1'));
-    events.push(key_event(KeyCode::Enter));
-
-    // Finish
-    events.push(key_event(KeyCode::Esc));
-    // Confirm exit (y)
-    events.push(char_event('y'));
+    let events = vec![
+        // Type "KEY1"
+        char_event('K'),
+        char_event('E'),
+        char_event('Y'),
+        char_event('1'),
+        key_event(KeyCode::Enter),
+        // Type "VAL1"
+        char_event('V'),
+        char_event('A'),
+        char_event('L'),
+        char_event('1'),
+        key_event(KeyCode::Enter),
+        // Finish
+        key_event(KeyCode::Esc),
+        // Confirm exit (y)
+        char_event('y'),
+    ];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);
@@ -94,28 +92,25 @@ fn test_prompt_secrets_validation_error() {
     // 3. "VAL" -> Enter
     // 4. Esc -> y
 
-    let mut events = Vec::new();
-
-    // "KEY@"
-    events.push(char_event('K'));
-    events.push(char_event('E'));
-    events.push(char_event('Y'));
-    events.push(char_event('@'));
-    events.push(key_event(KeyCode::Enter)); // Should show error
-
-    // Fix it: Backspace
-    events.push(key_event(KeyCode::Backspace));
-    events.push(key_event(KeyCode::Enter)); // Now "KEY" is valid
-
-    // Value "VAL"
-    events.push(char_event('V'));
-    events.push(char_event('A'));
-    events.push(char_event('L'));
-    events.push(key_event(KeyCode::Enter));
-
-    // Finish
-    events.push(key_event(KeyCode::Esc));
-    events.push(char_event('y'));
+    let events = vec![
+        // "KEY@"
+        char_event('K'),
+        char_event('E'),
+        char_event('Y'),
+        char_event('@'),
+        key_event(KeyCode::Enter), // Should show error
+        // Fix it: Backspace
+        key_event(KeyCode::Backspace),
+        key_event(KeyCode::Enter), // Now "KEY" is valid
+        // Value "VAL"
+        char_event('V'),
+        char_event('A'),
+        char_event('L'),
+        key_event(KeyCode::Enter),
+        // Finish
+        key_event(KeyCode::Esc),
+        char_event('y'),
+    ];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);

tests/selection_test.rs

@@ -53,10 +53,7 @@ fn test_select_repositories_select_all() {
         },
     ];
 
-    let mut events = Vec::new();
-    // Space to select all, then Enter
-    events.push(key_event(KeyCode::Char(' ')));
-    events.push(key_event(KeyCode::Enter));
+    let events = vec![key_event(KeyCode::Char(' ')), key_event(KeyCode::Enter)];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);
@@ -90,13 +87,13 @@ fn test_select_repositories_select_subset() {
         },
     ];
 
-    let mut events = Vec::new();
-    // Down to repo1, Space to select, Down to repo2, Space to select, Enter
-    events.push(key_event(KeyCode::Down)); // Move to repo1
-    events.push(key_event(KeyCode::Char(' '))); // Select repo1
-    events.push(key_event(KeyCode::Down)); // Move to repo2
-    events.push(key_event(KeyCode::Char(' '))); // Select repo2
-    events.push(key_event(KeyCode::Enter)); // Confirm
+    let events = vec![
+        key_event(KeyCode::Down),      // Move to repo1
+        key_event(KeyCode::Char(' ')), // Select repo1
+        key_event(KeyCode::Down),      // Move to repo2
+        key_event(KeyCode::Char(' ')), // Select repo2
+        key_event(KeyCode::Enter),     // Confirm
+    ];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);
@@ -118,9 +115,9 @@ fn test_select_repositories_cancel() {
         alias: None,
     }];
 
-    let mut events = Vec::new();
-    // Esc to cancel
-    events.push(key_event(KeyCode::Esc));
+    let events = vec![
+        key_event(KeyCode::Esc), // Esc to cancel
+    ];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);
@@ -145,9 +142,9 @@ fn test_select_repositories_no_selection() {
         alias: None,
     }];
 
-    let mut events = Vec::new();
-    // Just Enter without selecting anything
-    events.push(key_event(KeyCode::Enter));
+    let events = vec![
+        key_event(KeyCode::Enter), // Just Enter without selecting anything
+    ];
 
     let mut event_source = MockEventSource::new(events);
     let backend = TestBackend::new(80, 24);