Skip to content

Inconsistent SAC calculations #277

@mgoodness

Description

@mgoodness

When looking at Dive Details, SAC is calculated for all tanks used in a dive. But in others, it only uses the first tank:

  • Dives table view - SAC Rate column
  • Statistics - Air Consumption - SAC Rate Trend
  • Statistics - Air Consumption - SAC Rate Records

Is the plan/desire to use all tanks for these as well?

I also noticed that the Dives table view SAC Rate column doesn't convert from L/min to cuft/min, and doesn't honor users' SAC Rate Unit preferences.

Volume: L, SAC Rate: L/min
Image

Volume: cuft, SAC Rate: cuft/min
Image

Pressure: psi, SAC Rate: psi/min
Image

Pressure: bar, SAC Rate: bar/min
Image

I'm happy to fix/address these, and (with Claude's help) have already drafted changes. Just don't want to step on any toes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions