chore: enable erasableSyntaxOnly in tsconfig (#1946)

Author: hugo-vrijswijk

eslint.config.js

@@ -1,5 +1,5 @@
 import eslint from '@eslint/js';
-import { defineConfig } from 'eslint/config';
+import { defineConfig, globalIgnores } from 'eslint/config';
 import { importX } from 'eslint-plugin-import-x';
 import { configs as litConfigs } from 'eslint-plugin-lit';
 import simpleImportSort from 'eslint-plugin-simple-import-sort';
@@ -20,6 +20,8 @@ export default defineConfig(
   {
     rules: {
       '@typescript-eslint/consistent-type-imports': 'error',
+      '@typescript-eslint/no-import-type-side-effects': 'error',
+
       '@typescript-eslint/unbound-method': 'off',
       '@typescript-eslint/prefer-nullish-coalescing': 'off',
 
@@ -85,16 +87,14 @@ export default defineConfig(
       '@typescript-eslint/no-unsafe-member-access': 'off',
     },
   },
-  {
-    ignores: [
-      'node_modules',
-      'packages/*/dist',
-      'dist',
-      '.stryker-tmp',
-      'packages/*/reports',
-      'test-results',
-      'playwright-report',
-      '!.storybook',
-    ],
-  },
+  globalIgnores([
+    'node_modules',
+    'packages/*/dist',
+    'dist',
+    '.stryker-tmp',
+    'packages/*/reports',
+    'test-results',
+    'playwright-report',
+    '!.storybook',
+  ]),
 );

packages/badge-api/badge/Shield.ts

@@ -11,11 +11,13 @@ export interface Shield {
   logoColor: Color;
 }
 
-export enum Color {
-  Grey = 'lightgrey',
-  Red = 'red',
-  Orange = 'orange',
-  Green = 'green',
-  BrightGreen = 'brightgreen',
-  WhiteSmoke = 'whitesmoke',
-}
+export const Color = {
+  Grey: 'lightgrey',
+  Red: 'red',
+  Orange: 'orange',
+  Green: 'green',
+  BrightGreen: 'brightgreen',
+  WhiteSmoke: 'whitesmoke',
+} as const;
+
+export type Color = (typeof Color)[keyof typeof Color];

packages/badge-api/badge/ShieldMapper.ts

@@ -4,10 +4,13 @@ import type { Shield } from './Shield.js';
 import { Color } from './Shield.js';
 
 export class ShieldMapper {
-  constructor(private readonly reportMapper: MutationTestingReportMapper) {}
+  readonly #reportMapper: MutationTestingReportMapper;
+  constructor(reportMapper: MutationTestingReportMapper) {
+    this.#reportMapper = reportMapper;
+  }
 
   public async shieldFor(projectName: string, version: string, moduleName?: string): Promise<Shield> {
-    const report = await this.reportMapper.findOne({
+    const report = await this.#reportMapper.findOne({
       projectName,
       version,
       moduleName,

packages/common/src/slug.ts

@@ -8,10 +8,13 @@ const NR_OF_PROJECT_NAME_PARTS = 3;
  * Or "github.com/stryker-mutator/stryker/feat/allow/slashes"
  */
 export class Slug {
-  constructor(
-    public readonly project: string,
-    public readonly version: string,
-  ) {}
+  public readonly project: string;
+  public readonly version: string;
+
+  constructor(project: string, version: string) {
+    this.project = project;
+    this.version = version;
+  }
 
   /**
    * Parses a raw slug into project and version.

packages/data-access/src/mappers/DashboardQuery.ts

@@ -5,24 +5,27 @@ import { encodeKey } from '../utils.js';
 import type { ModelClass } from './ModelClass.js';
 
 export class DashboardQuery<TModel, TPartitionKeyFields extends keyof TModel, TRowKeyFields extends keyof TModel> {
-  private constructor(
-    protected ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>,
-    private readonly whereConditions: string[],
-  ) {}
+  protected ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>;
+  readonly #whereConditions: string[];
+
+  private constructor(ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>, whereConditions: string[]) {
+    this.ModelClass = ModelClass;
+    this.#whereConditions = whereConditions;
+  }
 
   public whereRowKeyNotEquals(
     rowKey: Pick<TModel, TRowKeyFields>,
   ): DashboardQuery<TModel, TPartitionKeyFields, TRowKeyFields> {
     const whereCondition: string = odata`RowKey ne ${encodeKey(this.ModelClass.createRowKey(rowKey) || '')}`;
 
-    return new DashboardQuery(this.ModelClass, [...this.whereConditions, whereCondition]);
+    return new DashboardQuery(this.ModelClass, [...this.#whereConditions, whereCondition]);
   }
 
   public wherePartitionKeyEquals(
     partitionKey: Pick<TModel, TPartitionKeyFields>,
   ): DashboardQuery<TModel, TPartitionKeyFields, TRowKeyFields> {
     const whereCondition: string = odata`PartitionKey eq ${encodeKey(this.ModelClass.createPartitionKey(partitionKey))}`;
-    return new DashboardQuery(this.ModelClass, [...this.whereConditions, whereCondition]);
+    return new DashboardQuery(this.ModelClass, [...this.#whereConditions, whereCondition]);
   }
 
   public static create<TModel, TPartitionKeyFields extends keyof TModel, TRowKeyFields extends keyof TModel>(
@@ -32,7 +35,7 @@ export class DashboardQuery<TModel, TPartitionKeyFields extends keyof TModel, TR
   }
 
   public build(): TableEntityQueryOptions {
-    return this.whereConditions.reduce<TableEntityQueryOptions>((tableQuery, whereCondition, index) => {
+    return this.#whereConditions.reduce<TableEntityQueryOptions>((tableQuery, whereCondition, index) => {
       if (index === 0) {
         return { filter: whereCondition };
       } else {

packages/data-access/src/mappers/MutationTestingResultMapper.ts

@@ -15,12 +15,12 @@ const errCodes = Object.freeze({
  * The report json part of a mutation testing report is stored in blob storage
  */
 export class MutationTestingResultMapper {
-  private static readonly CONTAINER_NAME = 'mutation-testing-report';
+  static readonly #CONTAINER_NAME = 'mutation-testing-report';
 
   #containerClient: ContainerClient;
 
   constructor(blobService: BlobServiceClient = createBlobServiceClient()) {
-    this.#containerClient = blobService.getContainerClient(MutationTestingResultMapper.CONTAINER_NAME);
+    this.#containerClient = blobService.getContainerClient(MutationTestingResultMapper.#CONTAINER_NAME);
   }
 
   public createStorageIfNotExists(): Promise<ContainerCreateIfNotExistsResponse> {

packages/data-access/src/mappers/TableStorageMapper.ts

@@ -18,12 +18,14 @@ export default class TableStorageMapper<
   TPartitionKeyFields extends keyof TModel,
   TRowKeyFields extends keyof TModel,
 > implements Mapper<TModel, TPartitionKeyFields, TRowKeyFields> {
+  readonly #ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>;
   readonly #tableClient: TableClient;
 
   constructor(
-    private readonly ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>,
+    ModelClass: ModelClass<TModel, TPartitionKeyFields, TRowKeyFields>,
     tableClient: TableClient = createTableClient(ModelClass.name),
   ) {
+    this.#ModelClass = ModelClass;
     this.#tableClient = tableClient;
   }
 
@@ -32,17 +34,17 @@ export default class TableStorageMapper<
   }
 
   public async insertOrMerge(model: TModel) {
-    const entity = this.toEntity(model);
+    const entity = this.#toEntity(model);
     await this.#tableClient.upsertEntity(entity, 'Merge');
   }
 
   public async findOne(identity: Pick<TModel, TPartitionKeyFields | TRowKeyFields>): Promise<Result<TModel> | null> {
     try {
       const result = await this.#tableClient.getEntity<TModel>(
-        encodeKey(this.ModelClass.createPartitionKey(identity)),
-        encodeKey(this.ModelClass.createRowKey(identity) || ''),
+        encodeKey(this.#ModelClass.createPartitionKey(identity)),
+        encodeKey(this.#ModelClass.createRowKey(identity) || ''),
       );
-      return this.toModel(result);
+      return this.#toModel(result);
     } catch (err) {
       if (hasErrorCode(err, errCodes.RESOURCE_NOT_FOUND)) {
         return null;
@@ -54,14 +56,14 @@ export default class TableStorageMapper<
   }
 
   public async findAll(
-    query: DashboardQuery<TModel, TPartitionKeyFields, TRowKeyFields> = DashboardQuery.create(this.ModelClass),
+    query: DashboardQuery<TModel, TPartitionKeyFields, TRowKeyFields> = DashboardQuery.create(this.#ModelClass),
   ): Promise<Result<TModel>[]> {
     const tableQuery = query.build();
     const entities = this.#tableClient.listEntities<TModel>({ queryOptions: tableQuery });
 
     const results: Result<TModel>[] = [];
     for await (const entity of entities) {
-      results.push(this.toModel(entity));
+      results.push(this.#toModel(entity));
     }
     return results;
   }
@@ -73,7 +75,7 @@ export default class TableStorageMapper<
    * @throws {OptimisticConcurrencyError}
    */
   public async replace(model: TModel, etag: string): Promise<Result<TModel>> {
-    const entity = this.toEntity(model);
+    const entity = this.#toEntity(model);
     try {
       const result = await this.#tableClient.updateEntity(entity, 'Replace', { etag });
       return { model, etag: result.etag! };
@@ -89,7 +91,7 @@ export default class TableStorageMapper<
   }
 
   public async insert(model: TModel): Promise<Result<TModel>> {
-    const entity = this.toEntity(model);
+    const entity = this.#toEntity(model);
     try {
       const result = await this.#tableClient.createEntity(entity);
       return { model, etag: result.etag! };
@@ -107,8 +109,8 @@ export default class TableStorageMapper<
   public async delete(identity: Pick<TModel, TPartitionKeyFields | TRowKeyFields>): Promise<void> {
     try {
       await this.#tableClient.deleteEntity(
-        encodeKey(this.ModelClass.createPartitionKey(identity)),
-        encodeKey(this.ModelClass.createRowKey(identity) || ''),
+        encodeKey(this.#ModelClass.createPartitionKey(identity)),
+        encodeKey(this.#ModelClass.createRowKey(identity) || ''),
       );
     } catch (err) {
       if (hasErrorCode(err, errCodes.RESOURCE_NOT_FOUND)) {
@@ -119,24 +121,24 @@ export default class TableStorageMapper<
     }
   }
 
-  private toModel(entity: TableEntityResult<TModel>): Result<TModel> {
-    const value = new this.ModelClass();
-    this.ModelClass.identify(value, decodeKey(entity.partitionKey!), decodeKey(entity.rowKey!));
-    this.ModelClass.persistedFields.forEach((field) => (value[field] = entity[field]));
+  #toModel(entity: TableEntityResult<TModel>): Result<TModel> {
+    const value = new this.#ModelClass();
+    this.#ModelClass.identify(value, decodeKey(entity.partitionKey!), decodeKey(entity.rowKey!));
+    this.#ModelClass.persistedFields.forEach((field) => (value[field] = entity[field]));
     return {
       etag: entity.etag,
       model: value,
     };
   }
 
-  private toEntity(entity: TModel): TableEntity<TModel> {
+  #toEntity(entity: TModel): TableEntity<TModel> {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const data: TableEntity<any> = {
-      partitionKey: encodeKey(this.ModelClass.createPartitionKey(entity)),
-      rowKey: encodeKey(this.ModelClass.createRowKey(entity) || ''),
+      partitionKey: encodeKey(this.#ModelClass.createPartitionKey(entity)),
+      rowKey: encodeKey(this.#ModelClass.createRowKey(entity) || ''),
     };
     // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-    this.ModelClass.persistedFields.forEach((field) => (data[field] = entity[field]));
+    this.#ModelClass.persistedFields.forEach((field) => (data[field] = entity[field]));
 
     return data as TableEntity<TModel>;
   }