Remove some Best Practice issues

Author: gb119

Stoner/core/property.py

@@ -85,7 +85,7 @@ def data(self, value):
             nv = ma.atleast_2d(nv)
         elif nv.ndim == 1:  # nv is a vector - make it a 2D array
             nv = ma.atleast_2d(nv).T
-        elif nv.ndim > 2:  # nv has more than 2D - raise an error # TODO 0.9? Support 3D arrays in DataFile?
+        elif nv.ndim > 2:
             raise ValueError(f"DataFile.data should be no more than 2 dimensional not shape {nv.shape}")
         if not isinstance(
             nv, DataArray

Stoner/folders/mixins.py

@@ -493,6 +493,12 @@ class PlotFolder(DataFolder):
 
     _defaults = {"plots_per_page": 12, "fig_defaults": {"figsize": (8, 6)}}
 
+    def __init__(self, *args, **kwargs):
+        """Fixup attributes."""
+        super().__init__(*args, **kwargs)
+        self._figure = getattr(self, "_figure", [])
+        self._fig_args = getattr(self, "_fig_args", [])
+
     def figure(self, *args, **kargs):
         """Pass through for :py:func:`matplotlib.pyplot.figure` but also takes a note of the arguments for later."""
         self._fig_args = args

Stoner/formats/data/zip.py

@@ -126,9 +126,9 @@ def save(save_data: Data, *args: Args, **kwargs: Kwargs) -> Data:
                         break
                 else:
                     raise IOError(f"Can't figure out where the zip file is in {filename}")
-                zipfile = zf.ZipFile(
+                zipfile = zf.ZipFile(  # pylint: disable=consider-using-with
                     path.join(*parts[: i + 1]), "w", compression, True
-                )  # pylint: disable=consider-using-with
+                )
                 close_me = True
                 member = path.join("/", *parts[i + 1 :])
         elif isinstance(filename, zf.ZipFile):  # Handle\ zipfile instance, opening if necessary

Stoner/tools/file.py

@@ -395,6 +395,7 @@ def get_loader(filetype, silent=False):
                 pass
         if not silent:
             raise StonerLoadError(f"Cannot locate a loader function for {filetype}") from err
+    return None
 
 
 def get_saver(filetype, silent=False):
@@ -427,6 +428,7 @@ def get_saver(filetype, silent=False):
                 pass
         if not silent:
             raise StonerLoadError(f"Cannot locate a loader function for {filetype}") from err
+    return None
 
 
 def clear_routine(name, loader=True, saver=True):
@@ -490,7 +492,7 @@ def __init__(self, filename, *args, **kargs):
             if parsed.scheme not in URL_SCHEMES:
                 filename = pathlib.Path(filename)
             else:
-                filename = urllib.request.urlopen(filename)
+                filename = urllib.request.urlopen(filename)  # pylint: disable=consider-using-with
         match filename:
             case str() | pathlib.Path():
                 self.mode = "open"