Merge pull request #3 from stfc/3.1_sync

3.1 sync

Author: sergisiso

.gitattributes

@@ -9,16 +9,16 @@
 # Fortran files
 *.f   text diff=fortran
 *.for text diff=fortran
-*.f90 text diff=fortran
-*.F90 text diff=fortran
-*.f95 text diff=fortran
-*.f03 text diff=fortran
-*.x90 text diff=fortran
-*.X90 text diff=fortran
-*.t90 text diff=fortran
-*.T90 text diff=fortran
-*.pf  text diff=fortran
-*.PF  text diff=fortran
+*.f90 text diff=fortran-free-form
+*.F90 text diff=fortran-free-form
+*.f95 text diff=fortran-free-form
+*.f03 text diff=fortran-free-form
+*.x90 text diff=fortran-free-form
+*.X90 text diff=fortran-free-form
+*.t90 text diff=fortran-free-form
+*.T90 text diff=fortran-free-form
+*.pf  text diff=fortran-free-form
+*.PF  text diff=fortran-free-form
 
 # Enable syntax highlighting for files with `.pf` extensions.
 #

.github/CODEOWNERS

@@ -1,3 +1,80 @@
-**/jules_interface/rose-meta @maggiehendry
-**/jedi_lfric* @MetOffice/r2o
-**/linear* @MetOffice/r2o
+# This CODEOWNERS file includes a primary codeowner and a deputy for each section. 
+# Codeowners who are not in a comment will be automatically notified of changes
+# to the listed files. All codeowners listed are valid points of contact
+# for discussing changes and seeking approval for work. 
+
+# Applications
+**/adjoint_tests             @DrTVockerodtMO                     # @mo-joshuacolclough
+**/gravity_wave              @thomasmelvin                       # @cjohnson-pi
+**/gungho_model              @thomasmelvin                       # @BShipway
+**/jedi_lfric_tests          @ss421  @matthewrmshin @MetOffice/r2o-systems
+**/jules                     @iboutle                            # @MetOfficessdtesam
+**/lfric2lfric               @mo-lottieturner                    # @mike-hobson
+**/lfricinputs               @mo-lottieturner                    # @mike-hobson
+**/lfric_atm                 @iboutle                            # @BShipway
+**/lfric_coupled             @HengistPodd                        # @BShipway
+**/lfricinputs               @mo-lottieturner                    # @mike-hobson
+**/linear_model              @cjohnson-pi @MetOffice/r2o-systems  # @tommbendall  # Also notifiy jedi team about linear changes.
+**/name_transport            @jameskent-metoffice                # @tommbendall
+**/ngarch                    @christophermaynard                 # @jcsmeto
+**/shallow_water             @jameskent-metoffice                # @atb1995
+**/solver                    @christophermaynard                 # @thomasmelvin
+**/transport                 @tommbendall                        # @jameskent-metoffice
+
+# Science
+**/adjoint                              @DrTVockerodtMO                     # @mo-joshuacolclough
+**/linear                               @cjohnson-pi  @MetOffice/r2o-systems # @tommbendall # Also notifiy jedi team about linear changes.
+science/shared/source/constants/        @iboutle                            # @BShipway
+
+**/gungho                               @thomasmelvin                       # @iboutle
+science/gungho/**/configuration/        @jameskent-metoffice                # @thomasmelvin
+science/gungho/**/core_dynamics/        @jameskent-metoffice                # @thomasmelvin
+science/gungho/**/diagnostics/          @atb1995                            # @iboutle
+science/gungho/**/diffusion/            @iboutle                            # @tommbendall
+science/gungho/**/driver/               @MetOffice/core-capability-development
+science/gungho/**/external_forcing/     @iboutle                            # @tommbendall
+science/gungho/**/initialisation/       @mo-cjsmith                         # @thomasmelvin
+science/gungho/**/limited_area/         @cjohnson-pi                        # @thomasmelvin
+science/gungho/**/orography/            @atb1995                            # @tommbendall
+science/gungho/**/physics/              @iboutle                            # @tommbendall
+science/gungho/**/psy/                  @thomasmelvin                       # @tommbendall
+science/gungho/**/runtime_constants/    @tommbendall                        # @atb1995
+science/gungho/**/solver/               @thomasmelvin                       # @tommbendall
+science/gungho/**/timestepping/         @thomasmelvin                       # @jameskent-metoffice
+science/gungho/**/transport/            @tommbendall                        # @jameskent-metoffice
+
+**/physics_schemes                                      @iboutle            # @MetOffice/ssdteam
+science/physics_schemes/**/boundary_layer               @Adrian-Lock        # @P-Burns
+science/physics_schemes/**/convection                   @MichaelWhitall
+science/physics_schemes/**/convection/comorph           @MichaelWhitall
+science/physics_schemes/**/large_scale_cloud            @paul-barrett       # @CyrilMorcrette
+science/physics_schemes/**/large_scale_precipitation    @paulfield2024      # @paul-barrett
+science/physics_schemes/**/radiation_control            @mo-jmanners        # @Petzi1
+science/physics_schemes/**/stochastic_physics           @wjtmo              # @annemccabe
+
+# Interfaces
+**/coupled_interface            @mike-hobson                        # @harry-shepherd
+**/jedi_lfric_interface         @ss421  @matthewrmshin @MetOffice/r2o-systems
+**/jules_interface              @iboutle                            # @MetOfficessdteam
+**/jules_interface/rose-meta    @maggiehendry
+**/physics_schemes_interface    @iboutle                            # @MetOfficessdteam
+**/socrates_interface           @mo-jmanners                        # @Petzi1
+
+# System Components
+rose-stem/templates/                   @james-bruten-mo                    # @jennyhickson
+rose-stem/lib/                         @james-bruten-mo                    # @jennyhickson
+rose-stem/bin/                         @james-bruten-mo                    # @jennyhickson
+rose-stem/site/meto/common/            @james-bruten-mo                    # @jennyhickson
+rose-stem/site/meto/macros/            @james-bruten-mo                    # @jennyhickson
+rose-stem/apps                         # Mostly updated by macros, no codeowner
+**/versions.py                         @james-bruten-mo                    # @jennyhickson
+build/                                 @MetOffice/ssdteam @hiker
+**/*Makefile                           @MatthewHambley @hiker
+**/*.mk                                @MatthewHambley @hiker
+**/optimisation                        @christophermaynard                 # HPC Optimisation Team
+
+# Other areas
+documentation                           # @MetOffice/ssdteam
+.github/                                @MetOffice/ssdteam
+LICENSE                                 @yaswant
+README.md                               @MetOffice/ssdteam

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -6,7 +6,8 @@ body:
   - type: markdown
     attributes:
       value: |
-        Thanks for taking the time to fill out this bug report!
+        Thanks for taking the time to fill out this bug report! _If you are planning 
+        to work on this issue, then please assign yourself to it._
   - type: dropdown
     id: version
     attributes:

.github/ISSUE_TEMPLATE/custom_issue.yml

@@ -6,7 +6,8 @@ body:
   - type: markdown
     attributes:
       value: |
-        Thanks for taking the time to help improve LFRic Apps.
+        Thanks for taking the time to help improve LFRic Apps. _If you are planning 
+        to work on this issue, then please assign yourself to it._
   - type: input
     id: linked-issues
     attributes:

.github/ISSUE_TEMPLATE/documentation.yml

@@ -6,7 +6,8 @@ body:
   - type: markdown
     attributes:
       value: |
-        Thanks for taking the time to help improve the LFRic Apps documentation.
+        Thanks for taking the time to help improve the LFRic Apps documentation. 
+        _If you are planning to work on this issue, then please assign yourself to it._
   - type: input
     id: linked-issues
     attributes:

.github/pull_request_template.md

@@ -1,6 +1,6 @@
 # PR Summary
 
-Sci/Tech Reviewer: <!-- SR id, filled when known (e.g. @octocat) -->
+Sci/Tech Reviewer: <!-- SR id, filled by author when ready for review (e.g. @octocat) -->
 Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) -->
 
 <!-- To be completed by the developer -->
@@ -30,8 +30,7 @@ Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) -->
 
 ## Testing
 
-- [ ] I have tested this change locally, using the LFRic Core rose-stem suite
-- [ ] If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
+- [ ] I have tested this change locally, using the LFRic Apps rose-stem suite
 - [ ] If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
 - [ ] I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
 - [ ] Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)
@@ -64,7 +63,7 @@ Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) -->
 
 ## PSyclone Approval
 
-- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](tooscollabdevteam@metoffice.gov.uk)
+- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](mailto:ToolsCollabDevTeam@metoffice.gov.uk)
 
 # Sci/Tech Review
 

.github/workflows/ci.yml .github/workflows/ci_docs.yml.github/workflows/ci.yml renamed to .github/workflows/ci_docs.yml

@@ -4,13 +4,16 @@
 #  under which the code may be used.
 # ------------------------------------------------------------------------------
 
-name: ci
-run-name: CI
+name: Documentation
+run-name: Docs Build and Deploy - ${{ github.ref_name }}
 
 on:
   push:
     branches:
       - main
+    paths:
+      - 'documentation/**'
+      - '.github/workflows/**'       
 
 concurrency:
   group: ${{ github.workflow }}-${{github.ref}}

.github/workflows/pr.yml .github/workflows/pr_docs.yml.github/workflows/pr.yml renamed to .github/workflows/pr_docs.yml

@@ -4,12 +4,15 @@
 #  under which the code may be used.
 # ------------------------------------------------------------------------------
 
-name: pr
-run-name: Pull Request ${{github.event.pull_request.number}}
+name: Docs Build for Pull Requests
+run-name: Docs build PR${{github.event.pull_request.number}}
 on:
   pull_request:
     branches:
       - main
+    paths:
+      - 'documentation/**'
+      - '.github/workflows/**'       
 
 concurrency:
   group: pr-${{github.ref}}-${{github.event.pull_request.number || github.run_number}}

.github/workflows/track-review-project.yaml

@@ -0,0 +1,17 @@
+name: Track Review Project
+
+on:
+  workflow_run:
+    workflows: [Trigger Review Project]
+    types:
+      - completed
+
+permissions:
+  actions: read
+  contents: read
+  pull-requests: write
+
+jobs:
+  track_review_project:
+    uses: MetOffice/growss/.github/workflows/track-review-project.yaml@main
+    secrets: inherit

.github/workflows/trigger-project-workflow.yaml

@@ -0,0 +1,17 @@
+name: Trigger Review Project
+
+on:
+  pull_request_target:
+    types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed", "closed"]
+  pull_request_review:
+  pull_request_review_comment:
+
+permissions:
+  actions: read
+  contents: read
+  pull-requests: write
+
+jobs:
+  trigger_project_workflow:
+    uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@main
+    secrets: inherit