Do not remove `null` datetime for items

[vincentsarago]

Hi,

We are facing an issue with items having date ranges, that are not showing in QGIS.
We did provide the items to the API (stac-fastapi v3.0.1, backend is pgstac v0.8.6) with "properties": {"datetime": null, "start_datetime": "xxxx", "end_datetime": "yyyy", ...}. Note that datetime was set to null at item creation time, but when we query the API, datetime is not there, we suspect that this is causing the trouble with QGIS (we didn't had any problem so far with pystac, etc but it looks like QGIS is more strict).

@vincentsarago we are using an old version of stac-fastapi (3.0.1) but still, it should have come after the updates you mentionned

Many thanks you for your help

Originally posted by @remicres in #637

[vincentsarago]

this is fixed with latest stac-pydantic version https://github.com/stac-utils/stac-pydantic/releases/tag/3.5.0

[remicres]

Thank you so much @vincentsarago !

[remicres]

Hi @vincentsarago , we gave a try with the latest stac-fastapi-pgstac but unfortunately we weren't able to read the items as expected. We have checked that we have the following packages installed:

stac-fastapi-api        6.2.1
stac-fastapi-extensions 6.2.1
stac-fastapi-pgstac     6.2.2
stac-fastapi-types      6.2.1
stac-pydantic           3.5.1

The "datetime": null is still missing in the returned items.

Are we missing something?

Thank you

[vincentsarago]

@remicres I cannot replicate,

I've added more tests in #913 🤷

can you share more info:

• response
• code base of your application

[remicres]

Hi @vincentsarago , the tests are running fine on stac-fastapi.
But we fail to play with stac-fastapi-pgstac.

• We first git clone https://github.com/stac-utils/stac-fastapi-pgstac.git
• Then we make docker-run from the cloned repository
• After that we push the joplin collection (from the testdata folder), then we push this custom item:

request

curl -X 'POST' \
  'http://localhost:8082/collections/joplin/items' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
    "id": "item2",
    "type": "Feature",
    "collection": "joplin",
    "links": [],
    "geometry": {
        "type": "Polygon",
        "coordinates": [
            [
                [
                    -94.6884155,
                    37.0595608
                ],
                [
                    -94.6884155,
                    37.0332547
                ],
                [
                    -94.6554565,
                    37.0332547
                ],
                [
                    -94.6554565,
                    37.0595608
                ],
                [
                    -94.6884155,
                    37.0595608
                ]
            ]
        ]
    },
    "properties": {
        "proj:epsg": 3857,
        "orientation": "nadir",
        "height": 2500,
        "width": 2500,
        "datetime": null,
        "start_datetime": "2000-02-02T00:00:00Z",
        "end_datetime": "2003-02-02T00:00:00Z",
        "gsd": 0.5971642834779395
    },
    "assets": {
        "COG": {
            "type": "image/tiff; application=geotiff; profile=cloud-optimized",
            "href": "https://arturo-stac-api-test-data.s3.amazonaws.com/joplin/images/may24C350000e4102500n.tif",
            "title": "NOAA STORM COG"
        }
    },
    "bbox": [
        -94.6884155,
        37.0332547,
        -94.6554565,
        37.0595608
    ],
    "stac_extensions": [
        "https://stac-extensions.github.io/eo/v1.0.0/schema.json",
        "https://stac-extensions.github.io/projection/v1.0.0/schema.json"
    ],
    "stac_version": "1.0.0"
}'

stac-fastapi-pgstac response

Code 201 (success)

{
  "bbox": [
    -94.6884155,
    37.0332547,
    -94.6554565,
    37.0595608
  ],
  "type": "Feature",
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [
          -94.6884155,
          37.0595608
        ],
        [
          -94.6884155,
          37.0332547
        ],
        [
          -94.6554565,
          37.0332547
        ],
        [
          -94.6554565,
          37.0595608
        ],
        [
          -94.6884155,
          37.0595608
        ]
      ]
    ]
  },
  "properties": {
    "datetime": null,
    "start_datetime": "2000-02-02T00:00:00Z",
    "end_datetime": "2003-02-02T00:00:00Z",
    "gsd": 0.5971642834779395,
    "proj:epsg": 3857,
    "orientation": "nadir",
    "height": 2500,
    "width": 2500
  },
  "id": "item2",
  "stac_version": "1.0.0",
  "assets": {
    "COG": {
      "href": "https://arturo-stac-api-test-data.s3.amazonaws.com/joplin/images/may24C350000e4102500n.tif",
      "type": "image/tiff; application=geotiff; profile=cloud-optimized",
      "title": "NOAA STORM COG"
    }
  },
  "links": [
    {
      "rel": "collection",
      "type": "application/json",
      "href": "http://localhost:8082/collections/joplin"
    },
    {
      "rel": "parent",
      "type": "application/json",
      "href": "http://localhost:8082/collections/joplin"
    },
    {
      "rel": "root",
      "type": "application/json",
      "href": "http://localhost:8082/"
    },
    {
      "rel": "self",
      "type": "application/geo+json",
      "href": "http://localhost:8082/collections/joplin/items/item2"
    }
  ],
  "stac_extensions": [
    "https://stac-extensions.github.io/eo/v1.0.0/schema.json",
    "https://stac-extensions.github.io/projection/v1.0.0/schema.json"
  ],
  "collection": "joplin"
}

request to read (get)

curl -i http://localhost:8082/collections/joplin/items/item2

Outputs:

{
  "id": "item2",
  "bbox": [
    -94.6884155,
    37.0332547,
    -94.6554565,
    37.0595608
  ],
  "type": "Feature",
  "links": [
    {
      "rel": "collection",
      "type": "application/json",
      "href": "http://localhost:8082/collections/joplin"
    },
    {
      "rel": "parent",
      "type": "application/json",
      "href": "http://localhost:8082/collections/joplin"
    },
    {
      "rel": "root",
      "type": "application/json",
      "href": "http://localhost:8082/"
    },
    {
      "rel": "self",
      "type": "application/geo+json",
      "href": "http://localhost:8082/collections/joplin/items/item2"
    }
  ],
  "assets": {
    "COG": {
      "href": "https://arturo-stac-api-test-data.s3.amazonaws.com/joplin/images/may24C350000e4102500n.tif",
      "type": "image/tiff; application=geotiff; profile=cloud-optimized",
      "title": "NOAA STORM COG"
    }
  },
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [
          -94.6884155,
          37.0595608
        ],
        [
          -94.6884155,
          37.0332547
        ],
        [
          -94.6554565,
          37.0332547
        ],
        [
          -94.6554565,
          37.0595608
        ],
        [
          -94.6884155,
          37.0595608
        ]
      ]
    ]
  },
  "collection": "joplin",
  "properties": {
    "gsd": 0.5971642834779395,
    "width": 2500,
    "height": 2500,
    "proj:epsg": 3857,
    "orientation": "nadir",
    "end_datetime": "2003-02-02T00:00:00Z",
    "start_datetime": "2000-02-02T00:00:00Z"
  },
  "stac_version": "1.0.0",
  "stac_extensions": [
    "https://stac-extensions.github.io/eo/v1.0.0/schema.json",
    "https://stac-extensions.github.io/projection/v1.0.0/schema.json"
  ]
}

[vincentsarago]

I believe this is a PgSTAC issue stac-utils/pgstac#425

cc @bitner

[remicres]

Thank you. We have suspected that, but weren't sure at all!

[seedlit]

I believe this is a PgSTAC issue stac-utils/pgstac#425

cc @bitner

made a PR to address that.
Just fyi