test sort extension (#906)

* test sort extension

* add pr number

---------

Co-authored-by: vincentsarago <vincent.sarago@gmail.com>

Author: jonhealy1

CHANGES.md

@@ -4,7 +4,8 @@
 
 ### Added
 
-- Added tests for the fields extension, which were previously missing ([#902](https://github.com/stac-utils/stac-fastapi/pull/902))
+- Add tests for the `sort` extension ([#906](https://github.com/stac-utils/stac-fastapi/pull/906))
+- Add tests for the `fields` extension ([#902](https://github.com/stac-utils/stac-fastapi/pull/902))
 - Simply add a list of present stac-fastapi extensions to the Readme ([#898](https://github.com/stac-utils/stac-fastapi/pull/898))
 
 ### Changed

stac_fastapi/extensions/tests/test_sort.py

@@ -0,0 +1,71 @@
+"""Tests for the Sort extension."""
+
+import pytest
+from fastapi import FastAPI
+
+# Adjust the import path based on your project structure
+from stac_fastapi.extensions.sort import (
+    SortConformanceClasses,
+    SortExtension,
+)
+from stac_fastapi.extensions.sort.request import (
+    SortExtensionGetRequest,
+    SortExtensionPostRequest,
+)
+
+
+def test_sort_conformance_classes():
+    """Test that the enum values match the official STAC API spec URIs."""
+    assert (
+        SortConformanceClasses.SEARCH
+        == "https://api.stacspec.org/v1.0.0/item-search#sort"
+    )
+    assert (
+        SortConformanceClasses.ITEMS
+        == "https://api.stacspec.org/v1.0.0/ogcapi-features#sort"
+    )
+    assert (
+        SortConformanceClasses.COLLECTIONS
+        == "https://api.stacspec.org/v1.0.0-rc.1/collection-search#sort"
+    )
+
+
+def test_sort_extension_defaults():
+    """Test the default instantiation of the SortExtension."""
+    ext = SortExtension()
+
+    assert ext.schema_href is None
+    assert ext.conformance_classes == [SortConformanceClasses.SEARCH]
+
+    # Ensure the GET/POST request models are properly assigned
+    assert ext.GET == SortExtensionGetRequest
+    assert ext.POST == SortExtensionPostRequest
+
+
+def test_sort_extension_customization():
+    """Test instantiating SortExtension with custom arguments."""
+    custom_conformance = [
+        SortConformanceClasses.SEARCH,
+        SortConformanceClasses.ITEMS,
+        SortConformanceClasses.COLLECTIONS,
+    ]
+    custom_schema = "https://example.com/sort-schema.json"
+
+    ext = SortExtension(
+        conformance_classes=custom_conformance,
+        schema_href=custom_schema,
+    )
+
+    assert ext.conformance_classes == custom_conformance
+    assert ext.schema_href == custom_schema
+
+
+def test_sort_extension_register():
+    """Test the register method with a dummy FastAPI app."""
+    ext = SortExtension()
+    app = FastAPI()
+
+    try:
+        ext.register(app)
+    except Exception as e:
+        pytest.fail(f"SortExtension.register() raised an exception: {e}")

stac_fastapi/extensions/tests/test_sort_request.py

@@ -0,0 +1,62 @@
+import pytest
+from pydantic import ValidationError
+from stac_pydantic.api.extensions.sort import SortExtension as PostSortModel
+
+from stac_fastapi.extensions.sort.request import (
+    SortExtensionGetRequest,
+    SortExtensionPostRequest,
+)
+
+## GET Request Tests
+
+
+def test_sort_extension_get_request_parsing():
+    """Test that the GET request properly converts comma-separated strings to a list."""
+    # Single field
+    req = SortExtensionGetRequest(sortby="-gsd")
+    assert req.sortby == ["-gsd"]
+
+    # Multiple fields
+    req = SortExtensionGetRequest(sortby="-gsd,+datetime,id")
+    assert req.sortby == ["-gsd", "+datetime", "id"]
+
+
+def test_sort_extension_get_request_empty():
+    """Test GET request with null or empty values."""
+    req_none = SortExtensionGetRequest(sortby=None)
+    assert req_none.sortby is None
+
+
+## POST Request Tests
+
+
+def test_sort_extension_post_request_defaults():
+    """Test POST request model default values."""
+    req = SortExtensionPostRequest()
+    assert req.sortby is None
+
+
+def test_sort_extension_post_request_valid_data():
+    """Test POST request with valid structured sort objects."""
+    data = {
+        "sortby": [
+            {"field": "properties.created", "direction": "asc"},
+            {"field": "id", "direction": "desc"},
+        ]
+    }
+    req = SortExtensionPostRequest(**data)
+
+    assert len(req.sortby) == 2
+    assert isinstance(req.sortby[0], PostSortModel)
+    assert req.sortby[0].field == "properties.created"
+    assert req.sortby[0].direction == "asc"
+
+
+def test_sort_extension_post_request_invalid_direction():
+    """
+    Test that pydantic validation catches invalid directions.
+    The PostSortModel restricts direction to 'asc' or 'desc'.
+    """
+    invalid_data = {"sortby": [{"field": "properties.created", "direction": "sideways"}]}
+    with pytest.raises(ValidationError):
+        SortExtensionPostRequest(**invalid_data)