Add psf_match_reference_filter to multiband catalog

[schlafly]

The multiband catalog can compute PSF-matched photometry. The images are roughly convolved to match the PSF of the reference image before performing photometry. The user can specify the reference band by a --reference_filter argument to the multiband catalog step. We need to store this metadata in the files. The romancal code currently stores this to
meta.psf_match_reference_filter
in the multiband catalog, which seems like a good place for it. We should also add it to the multiband significance image in order to keep those two files in sync.

Let's make these optional for now.

rad/latest/multiband_source_catalog.yaml

Line 22 in b56d5a4

source_catalog:

[braingram]

Would this be needed if spacetelescope/romancal#2019 is addressed and the step spec parameters are recorded? (asking mainly to cross-link the issues)

[schlafly]

It would help. In this case, I want the psf_match_reference_filter to go to the archive, etc., while I want the spec parameters to be more of an automatic fall-back that just records everything without needing to go to the archive.

[PaulHuwe]

@stscijgbot-rstdms

[stscijgbot-rstdms]

This issue is tracked on JIRA as RAD-260.

[stscijgbot-rstdms]

Comment by Paul Huwe on JIRA:

This is implemented in RAD PR-843: #843

 

[schlafly]

This looks reasonable. The failing tests are because it looks like Larry & I chose to store this as lowercase. Would you mind taking a look at how bad it is to change that to upper case? At least this will change:
https://github.com/spacetelescope/romancal/blob/cbdb56a32058a02ee5a42959d2d301fc526e65be/romancal/multiband_catalog/multiband_catalog.py#L386
but presumably there are other consequences.

I think this change should not require any compatibility updates, but please also run the regtests to see.

[stscijgbot-rstdms]

Comment by Paul Huwe on JIRA:

PR approved and merged.