Enable serial CTE for subarrays

Author: pllim

pkg/acs/Dates

@@ -1,3 +1,4 @@
+ 16-Mar-2026   CALACS 10.5.0 Serial CTE correction is now enabled for post-SM4 WFC subarrays.
  07-May-2024   CALACS 10.4.0 Implementation of the "Parallel and Serial CTE correction". This
                              version of the CTE correction (Generation 3) is based upon the
                              algorithm of Generation 2, but includes the additional correction

pkg/acs/History

@@ -1,3 +1,5 @@
+### 16-Mar-2026 - PLL - Version 10.5.0
+    Serial CTE correction is now enabled for post-SM4 WFC subarrays.
 ### 07-May-2024 - MDD - Version 10.4.0
     Implementation of the "Parallel and Serial CTE correction". This
     version of the CTE correction (Generation 3) is based upon the

pkg/acs/Updates

@@ -1,3 +1,12 @@
+Update for version 10.5.0 - 16-Mar-2026 (PLL)
+    pkg/acs/Dates
+    pkg/acs/History
+    pkg/acs/Updates
+    pkg/acs/include/acsversion.h
+    pkg/acs/include/pcte_gen3_funcs.h
+    pkg/acs/lib/acscte/docte.c
+    pkg/acs/lib/acscte/dopcte-gen3.c
+
 Update for version 10.4.0 - 07-May-2024 (MDD)
     pkg/acs/Dates
     pkg/acs/History

pkg/acs/include/acsversion.h

@@ -2,8 +2,8 @@
 #define INCL_ACSVERSION_H
 
 /* This string is written to the output primary header as CAL_VER. */
-#define ACS_CAL_VER "10.4.0 (07-May-2024)"
-#define ACS_CAL_VER_NUM "10.4.0"
+#define ACS_CAL_VER "10.5.0 (16-Mar-2026)"
+#define ACS_CAL_VER_NUM "10.5.0"
 
 /* This Generation of the CTE algorithm is obsolete.  These strings
    are only maintained in case a user has an older version of the
@@ -21,6 +21,6 @@
 
 /* name and version number of generation 3 CTE correction algorithm */
 #define ACS_GEN3_CTE_NAME "Par/Serial PixelCTE 2023"
-#define ACS_GEN3_CTE_VER "3.0"
+#define ACS_GEN3_CTE_VER "3.1"
 
 #endif /* INCL_ACSVERSION_H */

pkg/acs/lib/acscte/docte.c

@@ -6,7 +6,7 @@
  14-Sep-2023 MDD: Updated to accommodate only the "Parallel/Serial PixelCTE 2023"
      (aka Generation 3) correction. Code now applies a serial CTE correction for
      full-frame data.
-
+ 16-Mar-2026 PLL: Enabled serial CTE correction for subarrays.
 */
 # include <string.h>
 # include <stdio.h>
@@ -326,8 +326,7 @@ int DoCTE (ACSInfo *acs_info, const bool forwardModelOnly) {
         trlwarn("(pctecorr) IGNORING read noise level PCTERNOI from PCTETAB: %f. Using amp dependent values from CCDTAB instead", cteParallelPars.rn_amp);
         trlmessage("(pctecorr) Readout simulation forward modeling iterations PCTENFOR: %i\n"
                    "(pctecorr) Number of iterations used in the parallel transfer PCTENPAR: %i\n"
-                   "(pctecorr) CTE_FRAC: %f\n\n"
-                   "(pctecorr) NOTE: No serial CTE correction is done for any subarray data.\n",
+                   "(pctecorr) CTE_FRAC: %f\n\n",
                    cteParallelPars.n_forward, cteParallelPars.n_par, cteParallelPars.scale_frac);
         /* End read of the parallel CTE parameters */
 
@@ -364,9 +363,9 @@ int DoCTE (ACSInfo *acs_info, const bool forwardModelOnly) {
                     ampIDInCalib = amplocInCalib - AMPCALIBORDER; // This is a number.
 
                     /*
-                       Only perform the serial CTE correction for full-frame, post-SM4 data
+                       Only perform the serial CTE correction for post-SM4 data.
                     */
-                    if ((acs_info->expstart >= SM4MJD) && (!acs[i].subarray)) {
+                    if (acs_info->expstart >= SM4MJD) {
 
                         startOfSetInCalib = SET_TO_PROCESS[ampIDInCalib];
                         strcpy(corrType, "serial");
@@ -443,8 +442,8 @@ int DoCTE (ACSInfo *acs_info, const bool forwardModelOnly) {
 
                     clock_t begin = (double)clock();
 
-                    /* Perform the serial CTE correction for only full-frame, post-SM4 data */
-                    if ((acs_info->expstart >= SM4MJD) && (!acs[i].subarray)) {
+                    /* Perform the serial CTE correction for only post-SM4 data */
+                    if (acs_info->expstart >= SM4MJD) {
                         /* Serial correction */
                         strcpy(corrType, "serial");
                         if ((status = doPCTEGen3(&acs[i], &ctePars, &x[i], forwardModelOnly, corrType, ccdamp, nthAmp, amploc, ampID)))

pkg/acs/lib/acscte/dopcte-gen3.c

@@ -411,7 +411,6 @@ int rotateAmpData_acscte(FloatTwoDArray * amp, const unsigned ampID)
        Rotate the amp to put the serial trails in the same orientation
        as the parallel trails would be. A rotation requires a transpose
        and then a flip. Always transpose the data first.
-
     */
     transpose(amp);
 
@@ -600,7 +599,7 @@ static int alignAmpData(FloatTwoDArray * amp, const unsigned ampID)
    Flip the amp about the X-axis central row (i.e., flip from top to bottom)
 
    Note: This routine was originally in alignAmpData flow of processing.  It
-   is now encapulated here as it is used multiple times due to the rotations
+   is now encapsulated here as it is used multiple times due to the rotations
    needed to accommodate the serial CTE correction.  The original OPENMP
    specifications have been left intact.
 */