LSP Startup error: FileNotFoundException: logs\sdl-lsp.log

[zzeekk]

When starting LSP i get the following IDE error notification:

11:02:08,864 |-ERROR in ch.qos.logback.core.rolling.RollingFileAppender[FILE] - Failed to create parent directories for [C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2023.3.0\bin\logs\sdl-lsp.log]
11:02:08,869 |-ERROR in ch.qos.logback.core.rolling.RollingFileAppender[FILE] - openFile(logs/sdl-lsp.log,true) call failed. java.io.FileNotFoundException: logs\sdl-lsp.log (Das System kann den angegebenen Pfad nicht finden)
	at java.io.FileNotFoundException: logs\sdl-lsp.log (Das System kann den angegebenen Pfad nicht finden)

Note1: C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2023.3.0\bin\logs directory doesnt exist on my installation, and probably there are no permissions to create it.

Note2: the plugin still works.

Suggestion: could we write sdl-lsp.log to .sdlb/lsp.log instead?

[dsalathe]

@zzeekk Currently, logback is set up to write in the path:
logs/sdl-lsp.log
Which means it will write it from where the jar command of this server launch is executed. In other words, the path will depend on the behavior of the LSP Client.
Interestingly enough, on my side LSP4IJ is correctly executing from the root of the current project, creating the logs folder as expected.

I don't like the idea to change parent folder from logs to .sdlb, because .sdlb will handle the LSP Server config and may be intended to be synced into a git repo of the project, while logs are likely to be included in the .gitignore, ie. excluded from the git repo.

What we could do instead is to use ${user.home} in front to ensure writing it consistently in the user home directory, but it has the disadvantage of moving the logs outside of the current project.

There is unfortunately no easy setup to force the "current" project as it is not easily specifiable.
I would suggest first to understand why your path is trying to access "Intellij 2023.3", but I am unable to reproduce this behavior alone, so I will need your help for that.

Otherwise the simplest decision we can take here is to just remove the file appender since now we're streaming the logs into the LSP client directly, but I need to double check how it behaves with our VSCode client first.