Skip to content

Commit ac0182a

Browse files
authored
Merge pull request #416 from slok/slok/helm-scrape-interval
2 parents 4027a0a + 390c1af commit ac0182a

File tree

7 files changed

+20
-14
lines changed

7 files changed

+20
-14
lines changed

deploy/kubernetes/helm/sloth/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ description: Base chart for Sloth.
44
type: application
55
home: https://github.com/slok/sloth
66
kubeVersion: ">= 1.19.0-0"
7-
version: 0.6.3
7+
version: 0.6.4

deploy/kubernetes/helm/sloth/templates/pod-monitor.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,7 @@ spec:
1616
{{- include "sloth.selectorLabels" . | nindent 6 }}
1717
podMetricsEndpoints:
1818
- port: metrics
19+
{{- with .Values.metrics.scrapeInterval }}
20+
interval: {{.}}
21+
{{- end }}
1922
{{- end }}

deploy/kubernetes/helm/sloth/tests/testdata/output/pod_monitor_custom.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,4 @@ spec:
2222
app.kubernetes.io/instance: test
2323
podMetricsEndpoints:
2424
- port: metrics
25+
interval: 45s

deploy/kubernetes/helm/sloth/tests/values_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ func customValues() msi {
3838
},
3939

4040
"metrics": msi{
41-
"enabled": true,
41+
"enabled": true,
42+
"scrapeInterval": "45s",
4243
"prometheusLabels": msi{
4344
"kp1": "vp1",
4445
"kp2": "vp2",

deploy/kubernetes/helm/sloth/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ commonPlugins:
4646

4747
metrics:
4848
enabled: true
49+
#scrapeInterval: 30s
4950
prometheusLabels: {}
5051

5152
customSloConfig:

deploy/kubernetes/raw/sloth-with-common-plugins.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: sloth
77
namespace: monitoring
88
labels:
9-
helm.sh/chart: sloth-0.6.3
9+
helm.sh/chart: sloth-0.6.4
1010
app.kubernetes.io/managed-by: Helm
1111
app: sloth
1212
app.kubernetes.io/name: sloth
@@ -18,7 +18,7 @@ kind: ClusterRole
1818
metadata:
1919
name: sloth
2020
labels:
21-
helm.sh/chart: sloth-0.6.3
21+
helm.sh/chart: sloth-0.6.4
2222
app.kubernetes.io/managed-by: Helm
2323
app: sloth
2424
app.kubernetes.io/name: sloth
@@ -38,7 +38,7 @@ kind: ClusterRoleBinding
3838
metadata:
3939
name: sloth
4040
labels:
41-
helm.sh/chart: sloth-0.6.3
41+
helm.sh/chart: sloth-0.6.4
4242
app.kubernetes.io/managed-by: Helm
4343
app: sloth
4444
app.kubernetes.io/name: sloth
@@ -59,7 +59,7 @@ metadata:
5959
name: sloth
6060
namespace: monitoring
6161
labels:
62-
helm.sh/chart: sloth-0.6.3
62+
helm.sh/chart: sloth-0.6.4
6363
app.kubernetes.io/managed-by: Helm
6464
app: sloth
6565
app.kubernetes.io/name: sloth
@@ -74,7 +74,7 @@ spec:
7474
template:
7575
metadata:
7676
labels:
77-
helm.sh/chart: sloth-0.6.3
77+
helm.sh/chart: sloth-0.6.4
7878
app.kubernetes.io/managed-by: Helm
7979
app: sloth
8080
app.kubernetes.io/name: sloth
@@ -132,7 +132,7 @@ metadata:
132132
name: sloth
133133
namespace: monitoring
134134
labels:
135-
helm.sh/chart: sloth-0.6.3
135+
helm.sh/chart: sloth-0.6.4
136136
app.kubernetes.io/managed-by: Helm
137137
app: sloth
138138
app.kubernetes.io/name: sloth

deploy/kubernetes/raw/sloth.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: sloth
77
namespace: monitoring
88
labels:
9-
helm.sh/chart: sloth-0.6.3
9+
helm.sh/chart: sloth-0.6.4
1010
app.kubernetes.io/managed-by: Helm
1111
app: sloth
1212
app.kubernetes.io/name: sloth
@@ -18,7 +18,7 @@ kind: ClusterRole
1818
metadata:
1919
name: sloth
2020
labels:
21-
helm.sh/chart: sloth-0.6.3
21+
helm.sh/chart: sloth-0.6.4
2222
app.kubernetes.io/managed-by: Helm
2323
app: sloth
2424
app.kubernetes.io/name: sloth
@@ -38,7 +38,7 @@ kind: ClusterRoleBinding
3838
metadata:
3939
name: sloth
4040
labels:
41-
helm.sh/chart: sloth-0.6.3
41+
helm.sh/chart: sloth-0.6.4
4242
app.kubernetes.io/managed-by: Helm
4343
app: sloth
4444
app.kubernetes.io/name: sloth
@@ -59,7 +59,7 @@ metadata:
5959
name: sloth
6060
namespace: monitoring
6161
labels:
62-
helm.sh/chart: sloth-0.6.3
62+
helm.sh/chart: sloth-0.6.4
6363
app.kubernetes.io/managed-by: Helm
6464
app: sloth
6565
app.kubernetes.io/name: sloth
@@ -74,7 +74,7 @@ spec:
7474
template:
7575
metadata:
7676
labels:
77-
helm.sh/chart: sloth-0.6.3
77+
helm.sh/chart: sloth-0.6.4
7878
app.kubernetes.io/managed-by: Helm
7979
app: sloth
8080
app.kubernetes.io/name: sloth
@@ -107,7 +107,7 @@ metadata:
107107
name: sloth
108108
namespace: monitoring
109109
labels:
110-
helm.sh/chart: sloth-0.6.3
110+
helm.sh/chart: sloth-0.6.4
111111
app.kubernetes.io/managed-by: Helm
112112
app: sloth
113113
app.kubernetes.io/name: sloth

0 commit comments

Comments
 (0)