Merge pull request #20 from shopwareLabs/feat/eslint-10

feat: eslint 10 upgrade

Author: shyim

.github/workflows/publish.yml

@@ -13,15 +13,15 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
-      
+
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
 
       - name: Setup Node.js
         uses: actions/setup-node@v6
         with:
           node-version: "24"
-          cache: 'pnpm'
+          cache: "pnpm"
           registry-url: "https://registry.npmjs.org"
 
       - name: Update npm

.github/workflows/test.yml

@@ -7,20 +7,49 @@ on:
   pull_request:
 
 jobs:
-  biome:
-    name: Biome
+  oxlint:
+    name: oxlint
     runs-on: ubuntu-latest
     steps:
-        - name: Checkout
-          uses: actions/checkout@v6
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: "24"
+          cache: "pnpm"
 
-        - name: Setup Biome
-          uses: biomejs/setup-biome@v2
-          with:
-            version: latest
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Run oxlint
+        run: pnpm oxlint
+
+  oxfmt:
+    name: oxfmt
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: "24"
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install
 
-        - name: Run Biome
-          run: biome ci .
+      - name: Run oxfmt
+        run: pnpm oxfmt:check
 
   test:
     name: Vitest
@@ -37,7 +66,7 @@ jobs:
         uses: actions/setup-node@v6
         with:
           node-version: "24"
-          cache: 'pnpm'
+          cache: "pnpm"
 
       - name: Install dependencies
         run: pnpm install

.github/workflows/update-biome-schema.yml

@@ -0,0 +1,5 @@
+{
+	"$schema": "./node_modules/oxfmt/configuration_schema.json",
+	"useTabs": true,
+	"singleQuote": false
+}

.oxfmtrc.json

@@ -0,0 +1,7 @@
+{
+	"$schema": "./node_modules/oxlint/configuration_schema.json",
+	"categories": {
+		"correctness": "error"
+	},
+	"plugins": ["eslint", "typescript", "unicorn", "oxc", "import"]
+}

.oxlintrc.json

@@ -10,4 +10,4 @@ This repository is a monorepo for ESLint and Stylelint rules for Shopware.
 
 ## License
 
-[MIT](./LICENSE)
+[MIT](./LICENSE)

README.md

@@ -1,11 +1,13 @@
 {
-	"packageManager": "[email protected]",
+	"scripts": {
+		"oxlint": "oxlint .",
+		"oxlint:fix": "oxlint --fix .",
+		"oxfmt": "oxfmt .",
+		"oxfmt:check": "oxfmt --check"
+	},
 	"devDependencies": {
-		"@biomejs/biome": "~2.3.11"
+		"oxfmt": "^0.33.0",
+		"oxlint": "^1.48.0"
 	},
-	"scripts": {
-		"biome": "biome",
-		"biome:fix": "biome format --write . && biome lint --fix --unsafe . && biome check --fix --unsafe .",
-		"biome:check": "biome ci ."
-	}
+	"packageManager": "[email protected]"
 }

biome.json

@@ -49,9 +49,7 @@ export default {
 			if (isComponentDefinition(objectNode)) {
 				componentNode = objectNode;
 				emitsNode = objectNode.properties.find(
-					(property) =>
-						property.key?.name === "emits" &&
-						property.value.type === "ArrayExpression",
+					(property) => property.key?.name === "emits" && property.value.type === "ArrayExpression",
 				)?.value;
 			}
 		}
@@ -70,15 +68,10 @@ export default {
 		function getEmitCallsFromTemplate(importNode) {
 			if (importNode.name === "template") {
 				const templateFileName = importNode.parent.parent.source.value;
-				const directoryPath = dirname(context.getFilename());
-				const templateSource = readFileSync(
-					resolve(directoryPath, templateFileName),
-					"utf8",
-				);
-
-				const templateEventsNames = Array.from(
-					templateSource.matchAll(EVENT_NAME_REGEXP),
-				)
+				const directoryPath = dirname(context.filename);
+				const templateSource = readFileSync(resolve(directoryPath, templateFileName), "utf8");
+
+				const templateEventsNames = Array.from(templateSource.matchAll(EVENT_NAME_REGEXP))
 					.map(([, capturedGroup]) => capturedGroup)
 					.filter(Boolean);
 
@@ -145,8 +138,7 @@ export default {
 		}
 
 		function fixMissingEmitDefinitions(programNode) {
-			const emitsDefinition =
-				emitsNode?.elements.map((element) => element.value) ?? [];
+			const emitsDefinition = emitsNode?.elements.map((element) => element.value) ?? [];
 			const pendingEmitDefinitions = Array.from(emittedEvents).filter(
 				(e) => e && !emitsDefinition.includes(e),
 			);
@@ -170,10 +162,7 @@ export default {
 						// emits with already some event in the component
 						const lastElement = emitsNode.elements.at(-1);
 						if (lastElement) {
-							return fixer.insertTextAfter(
-								lastElement,
-								`, ${stringEmitEvents}`,
-							);
+							return fixer.insertTextAfter(lastElement, `, ${stringEmitEvents}`);
 						}
 
 						// emits without any event in
@@ -201,15 +190,12 @@ export default {
 				"provide",
 			];
 
-			const nodeAfterWhichToInsert = componentNode.properties.findLast(
-				(property) => fieldsBeforeEmits.includes(property.key.name),
+			const nodeAfterWhichToInsert = componentNode.properties.findLast((property) =>
+				fieldsBeforeEmits.includes(property.key.name),
 			);
 
 			if (nodeAfterWhichToInsert) {
-				return fixer.insertTextAfter(
-					nodeAfterWhichToInsert,
-					`,\n\nemits: [${stringEmitEvents}]`,
-				);
+				return fixer.insertTextAfter(nodeAfterWhichToInsert, `,\n\nemits: [${stringEmitEvents}]`);
 			}
 
 			// in the case there is no fields that should be before emits, then we insert at the beginning of the component