feat: add identifiers for PhpStan 2

Author: shyim

src/Rule/DisallowDefaultContextCreation.php

@@ -25,10 +25,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        if (!$node instanceof StaticCall) {
-            return [];
-        }
-
         if (!$node->name instanceof Node\Identifier) {
             return [];
         }
@@ -55,6 +51,7 @@ public function processNode(Node $node, Scope $scope): array
             RuleErrorBuilder::message(sprintf('Do not use %s::createDefaultContext() function in code.', $node->class->toString()))
                 ->addTip('If you are in a CLI context, use %s::createCliContext() instead.')
                 ->addTip('If you are in a web context, pass down the context from the controller.')
+                ->identifier('shopware.disallow.default.context.creation')
                 ->build(),
         ];
     }

src/Rule/DisallowFunctionsRule.php

@@ -34,10 +34,6 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (!$node instanceof FuncCall) {
-            return [];
-        }
-
         if (!$node->name instanceof Node\Name) {
             return [];
         }
@@ -46,7 +42,10 @@ public function processNode(Node $node, Scope $scope): array
 
         if (\in_array($name, self::NOT_ALLOWED_FUNCTIONS, true)) {
             return [
-                RuleErrorBuilder::message(\sprintf('Do not use %s function in code.', $name))->build(),
+                RuleErrorBuilder::message(\sprintf('Do not use %s function in code.', $name))
+                    ->line($node->getLine())
+                    ->identifier('shopware.disallow_functions')
+                    ->build(),
             ];
         }
 

src/Rule/InternalFunctionCallRule.php

@@ -11,6 +11,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 use Shopware\PhpStan\Helper\NamespaceChecker;
 
 /**
@@ -34,8 +35,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof FuncCall);
-
         if (!$node->name instanceof Node\Name) {
             return [];
         }
@@ -54,7 +53,10 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         return [
-            sprintf('Call of internal function %s Please refrain from using functions which are annotated with @internal in the Shopware 6 repository.', $function->getName()),
+            RuleErrorBuilder::message(sprintf('Call of internal function %s Please refrain from using functions which are annotated with @internal in the Shopware 6 repository.', $function->getName()))
+                ->line($node->getLine())
+                ->identifier('shopware.internal_function_call')
+                ->build(),
         ];
     }
 }

src/Rule/InternalMethodCallRule.php

@@ -13,6 +13,7 @@
 use PHPStan\Reflection\MissingMethodFromReflectionException;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
 use Shopware\PhpStan\Helper\NamespaceChecker;
 
 /**
@@ -31,8 +32,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        assert($node instanceof MethodCall);
-
         if (!$node->name instanceof Identifier) {
             return [];
         }
@@ -63,7 +62,9 @@ public function processNode(Node $node, Scope $scope): array
             }
             if (!NamespaceChecker::arePartOfTheSamePackage($scope->getNamespace(), $methodOwnerNamespace)) {
                 return [
-                    sprintf('Call of internal method %s::%s Please refrain from using methods which are annotated with @internal in the Shopware 6 repository.', $classInfo->getName(), $methodDetails->getName()),
+                    RuleErrorBuilder::message(sprintf('Call of internal method %s::%s Please refrain from using methods which are annotated with @internal in the Shopware 6 repository.', $classInfo->getName(), $methodDetails->getName()))
+                        ->identifier('shopware.internal_method_call')
+                        ->build(),
                 ];
             }
         }

src/Rule/SetForeignKeyRule.php

@@ -23,10 +23,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-        if (!$node instanceof Node\Stmt\ClassMethod) {
-            return [];
-        }
-
         if ($node->name->name !== 'update') {
             return [];
         }
@@ -52,6 +48,7 @@ public function processNode(Node $node, Scope $scope): array
             if (str_contains($string->value, 'FOREIGN_KEY_CHECKS')) {
                 $errors[] = RuleErrorBuilder::message('Do not disable FOREIGN KEY checks in migrations. Delete the data in the right order')
                     ->line($string->getLine())
+                    ->identifier('shopware.foreign.key.checks')
                     ->build();
             }
         }