Merge pull request #26 from shopwareLabs/fix/create-cli-context-rule

fix: typo in method name

Author: shyim

composer.json

@@ -33,6 +33,9 @@
     "allow-plugins": {
       "phpstan/extension-installer": true,
       "symfony/runtime": false
+    },
+    "audit": {
+      "block-insecure": false
     }
   },
   "extra": {

src/Rule/DisallowDefaultContextCreation.php

@@ -43,15 +43,19 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if (!$this->reflectionProvider->hasClass('Shopware\Core\Framework\Context')) {
+            return [];
+        }
+
         $class = $this->reflectionProvider->getClass('Shopware\Core\Framework\Context');
 
-        if (!$class->hasMethod('createCliContext')) {
+        if (!$class->hasMethod('createCLIContext')) {
             return [];
         }
 
         return [
             RuleErrorBuilder::message(sprintf('Do not use %s::createDefaultContext() function in code.', $node->class->toString()))
-                ->addTip('If you are in a CLI context, use %s::createCliContext() instead.')
+                ->addTip('If you are in a CLI context, use %s::createCLIContext() instead.')
                 ->addTip('If you are in a web context, pass down the context from the controller.')
                 ->identifier('shopware.disallow.default.context.creation')
                 ->build(),

tests/Rule/DisallowDefaultContextCreationTest.php

@@ -21,7 +21,7 @@ public function testAnalyse(): void
             [
                 <<<EOF
 Do not use Shopware\Core\Framework\Context::createDefaultContext() function in code.
-    💡 • If you are in a CLI context, use %s::createCliContext() instead.
+    💡 • If you are in a CLI context, use %s::createCLIContext() instead.
 • If you are in a web context, pass down the context from the controller.
 EOF,
                 5,

tests/Rule/fixtures/DisallowDefaultContextCreation/context.php

@@ -4,4 +4,4 @@
 
 $context = \Shopware\Core\Framework\Context::createDefaultContext();
 
-$context = \Shopware\Core\Framework\Context::createCliContext();
+$context = \Shopware\Core\Framework\Context::createCLIContext();