Merge pull request #927 from shopware/fix/project-create-smarter-defaults

fix(project): use smarter defaults when git or AMQP are unavailable

Author: shyim

cmd/project/project_create.go

@@ -11,6 +11,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"slices"
 	"sort"
 	"strings"
 	"text/template"
@@ -182,6 +183,17 @@ var projectCreateCmd = &cobra.Command{
 			selectGit := tui.Yes
 			selectElasticsearch := tui.No
 			selectAMQP := tui.Yes
+
+			if !system.IsGitInstalled() {
+				selectGit = tui.No
+			}
+
+			if !useDocker {
+				extensions, err := system.GetAvailablePHPExtensions(cmd.Context())
+				if err == nil && !slices.Contains(extensions, "amqp") {
+					selectAMQP = tui.No
+				}
+			}
 			selectedMinor := versionLatest
 
 			theme := huh.ThemeFunc(func(isDark bool) *huh.Styles {

internal/system/git.go

@@ -0,0 +1,8 @@
+package system
+
+import "os/exec"
+
+func IsGitInstalled() bool {
+	_, err := exec.LookPath("git")
+	return err == nil
+}

internal/system/php.go

@@ -35,6 +35,31 @@ func GetInstalledPHPVersion(ctx context.Context) (string, error) {
 	return strings.TrimSpace(version), nil
 }
 
+// GetAvailablePHPExtensions returns the list of loaded PHP extensions by parsing `php -m` output.
+func GetAvailablePHPExtensions(ctx context.Context) ([]string, error) {
+	phpPath, err := exec.LookPath("php")
+	if err != nil {
+		return nil, fmt.Errorf("PHP is not installed: %w", err)
+	}
+
+	cmd := exec.CommandContext(ctx, phpPath, "-m")
+	output, err := cmd.Output()
+	if err != nil {
+		return nil, fmt.Errorf("failed to get PHP extensions: %w, output: %s", err, string(output))
+	}
+
+	var extensions []string
+	for line := range strings.SplitSeq(string(output), "\n") {
+		line = strings.TrimSpace(line)
+		if line == "" || strings.HasPrefix(line, "[") {
+			continue
+		}
+		extensions = append(extensions, line)
+	}
+
+	return extensions, nil
+}
+
 func IsPHPVersionAtLeast(ctx context.Context, requiredVersion string) (bool, error) {
 	installedVersion, err := GetInstalledPHPVersion(ctx)
 	if err != nil {

internal/system/php_test.go

@@ -41,11 +41,35 @@ func TestPHPVersionIsNotAtLeast(t *testing.T) {
 	assert.False(t, hit, "PHP version should not be at least 8.0.0")
 }
 
+func TestGetAvailablePHPExtensionsNotInstalled(t *testing.T) {
+	t.Setenv("PATH", "")
+	_, err := GetAvailablePHPExtensions(t.Context())
+	assert.ErrorContains(t, err, "PHP is not installed")
+}
+
+func TestGetAvailablePHPExtensions(t *testing.T) {
+	tmpDir := t.TempDir()
+
+	setupFakePHP(t, tmpDir, "8.0.0")
+
+	extensions, err := GetAvailablePHPExtensions(t.Context())
+	assert.NoError(t, err)
+	assert.ElementsMatch(t, []string{"Core", "curl", "json", "mbstring"}, extensions)
+}
+
 func setupFakePHP(t *testing.T, tmpDir string, version string) {
 	t.Helper()
 	shPath, err := exec.LookPath("sh")
 	assert.NoError(t, err)
 
-	assert.NoError(t, os.WriteFile(tmpDir+"/php", []byte(fmt.Sprintf("#!%s\necho PHP %s", shPath, version)), 0755))
+	script := fmt.Sprintf(`#!%s
+if [ "$1" = "-m" ]; then
+  printf '[PHP Modules]\nCore\ncurl\njson\nmbstring\n\n[Zend Modules]\n'
+else
+  echo PHP %s
+fi
+`, shPath, version)
+
+	assert.NoError(t, os.WriteFile(tmpDir+"/php", []byte(script), 0755))
 	t.Setenv("PATH", tmpDir)
 }