fix: check for system installed node and php version before setting up tools

Author: shyim

internal/system/node.go

@@ -0,0 +1,53 @@
+package system
+
+import (
+	"fmt"
+	"os/exec"
+	"strings"
+
+	"github.com/shyim/go-version"
+)
+
+// GetInstalledNodeVersion checks the installed Node.js version on the system.
+func GetInstalledNodeVersion() (string, error) {
+	// Check if Node.js is installed
+	nodePath, err := exec.LookPath("node")
+	if err != nil {
+		return "", fmt.Errorf("Node.js is not installed: %w", err)
+	}
+
+	// Get the Node.js version
+	cmd := exec.Command(nodePath, "-v")
+	output, err := cmd.Output()
+	if err != nil {
+		return "", fmt.Errorf("failed to get Node.js version: %w, output: %s", err, string(output))
+	}
+
+	// Node.js outputs version in format "vX.Y.Z", we need to trim the "v" prefix
+	version := strings.TrimSpace(string(output))
+	if len(version) > 0 && version[0] == 'v' {
+		version = version[1:]
+	}
+
+	return version, nil
+}
+
+// IsNodeVersionAtLeast checks if the installed Node.js version meets the minimum required version.
+func IsNodeVersionAtLeast(requiredVersion string) (bool, error) {
+	installedVersion, err := GetInstalledNodeVersion()
+	if err != nil {
+		return false, err
+	}
+
+	nodeVersion, err := version.NewVersion(installedVersion)
+	if err != nil {
+		return false, fmt.Errorf("failed to parse installed Node.js version: %w", err)
+	}
+
+	constraint, err := version.NewConstraint(fmt.Sprintf(">= %s", requiredVersion))
+	if err != nil {
+		return false, fmt.Errorf("failed to parse required Node.js version constraint: %w", err)
+	}
+
+	return constraint.Check(nodeVersion), nil
+}

internal/system/node_test.go

@@ -0,0 +1,52 @@
+package system
+
+import (
+	"fmt"
+	"os"
+	"os/exec"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetNodeVersionNotInstalled(t *testing.T) {
+	t.Setenv("PATH", "")
+	_, err := GetInstalledNodeVersion()
+	assert.ErrorContains(t, err, "Node.js is not installed")
+}
+
+func TestGetNodeVersion(t *testing.T) {
+	tmpDir := t.TempDir()
+
+	setupFakeNode(t, tmpDir, "18.16.0")
+
+	nodeVersion, err := GetInstalledNodeVersion()
+	assert.NoError(t, err)
+	assert.Equal(t, "18.16.0", nodeVersion)
+}
+
+func TestNodeVersionIsAtLeast(t *testing.T) {
+	setupFakeNode(t, t.TempDir(), "18.16.0")
+	hit, err := IsNodeVersionAtLeast("16.0.0")
+
+	assert.NoError(t, err)
+	assert.True(t, hit, "Node.js version should be at least 16.0.0")
+}
+
+func TestNodeVersionIsNotAtLeast(t *testing.T) {
+	setupFakeNode(t, t.TempDir(), "14.17.0")
+	hit, err := IsNodeVersionAtLeast("16.0.0")
+
+	assert.NoError(t, err)
+	assert.False(t, hit, "Node.js version should not be at least 16.0.0")
+}
+
+func setupFakeNode(t *testing.T, tmpDir string, version string) {
+	t.Helper()
+	shPath, err := exec.LookPath("sh")
+	assert.NoError(t, err)
+
+	// Node returns version with 'v' prefix
+	assert.NoError(t, os.WriteFile(tmpDir+"/node", []byte(fmt.Sprintf("#!%s\necho v%s", shPath, version)), 0755))
+	t.Setenv("PATH", tmpDir)
+}

internal/system/php.go

@@ -0,0 +1,54 @@
+package system
+
+import (
+	"fmt"
+	"os/exec"
+	"strings"
+
+	"github.com/shyim/go-version"
+)
+
+// GetInstalledPHPVersion checks the installed PHP version on the system.
+func GetInstalledPHPVersion() (string, error) {
+	// Check if PHP is installed
+	phpPath, err := exec.LookPath("php")
+	if err != nil {
+		return "", fmt.Errorf("PHP is not installed: %w", err)
+	}
+
+	// Get the PHP version
+	cmd := exec.Command(phpPath, "-v")
+	output, err := cmd.Output()
+	if err != nil {
+		return "", fmt.Errorf("failed to get PHP version: %w, output: %s", err, string(output))
+	}
+
+	splitt := strings.Split(string(output), " ")
+
+	if len(splitt) < 2 {
+		return "", fmt.Errorf("unexpected output format: %s", string(output))
+	}
+
+	// Parse the version from the output
+	version := splitt[1]
+	return strings.TrimSpace(version), nil
+}
+
+func IsPHPVersionAtLeast(requiredVersion string) (bool, error) {
+	installedVersion, err := GetInstalledPHPVersion()
+	if err != nil {
+		return false, err
+	}
+
+	phpVersion, err := version.NewVersion(installedVersion)
+	if err != nil {
+		return false, fmt.Errorf("failed to parse installed PHP version: %w", err)
+	}
+
+	constraint, err := version.NewConstraint(fmt.Sprintf(">= %s", requiredVersion))
+	if err != nil {
+		return false, fmt.Errorf("failed to parse required PHP version constraint: %w", err)
+	}
+
+	return constraint.Check(phpVersion), nil
+}

internal/system/php_test.go

@@ -0,0 +1,51 @@
+package system
+
+import (
+	"fmt"
+	"os"
+	"os/exec"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetPHPVersionNotInstalled(t *testing.T) {
+	t.Setenv("PATH", "")
+	_, err := GetInstalledPHPVersion()
+	assert.ErrorContains(t, err, "PHP is not installed")
+}
+
+func TestGetPHPVersion(t *testing.T) {
+	tmpDir := t.TempDir()
+
+	setupFakePHP(t, tmpDir, "8.0.0")
+
+	phpVersion, err := GetInstalledPHPVersion()
+	assert.NoError(t, err)
+	assert.Equal(t, "8.0.0", phpVersion)
+}
+
+func TestPHPVersionIsAtLeast(t *testing.T) {
+	setupFakePHP(t, t.TempDir(), "8.0.0")
+	hit, err := IsPHPVersionAtLeast("8.0.0")
+
+	assert.NoError(t, err)
+	assert.True(t, hit, "PHP version should be at least 8.0.0")
+}
+
+func TestPHPVersionIsNotAtLeast(t *testing.T) {
+	setupFakePHP(t, t.TempDir(), "7.4.0")
+	hit, err := IsPHPVersionAtLeast("8.0.0")
+
+	assert.NoError(t, err)
+	assert.False(t, hit, "PHP version should not be at least 8.0.0")
+}
+
+func setupFakePHP(t *testing.T, tmpDir string, version string) {
+	t.Helper()
+	shPath, err := exec.LookPath("sh")
+	assert.NoError(t, err)
+
+	assert.NoError(t, os.WriteFile(tmpDir+"/php", []byte(fmt.Sprintf("#!%s\necho PHP %s", shPath, version)), 0755))
+	t.Setenv("PATH", tmpDir)
+}

internal/verifier/embed.go

@@ -33,6 +33,18 @@ func SetupTools(ctx context.Context, currentVersion string) error {
 		return nil
 	}
 
+	if ok, err := system.IsPHPVersionAtLeast("8.2.0"); err != nil {
+		return fmt.Errorf("failed to check installed PHP version: %w", err)
+	} else if !ok {
+		return fmt.Errorf("PHP version must be at least 8.2.0 to use this. Update your PHP version or use the shopware-cli docker image")
+	}
+
+	if ok, err := system.IsNodeVersionAtLeast("22.0.0"); err != nil {
+		return fmt.Errorf("failed to check installed Node.js version: %w", err)
+	} else if !ok {
+		return fmt.Errorf("Node.js version must be at least 22.0.0 to use this. Update your Node.js version or use the shopware-cli docker image")
+	}
+
 	logging.FromContext(ctx).Debugf("Using tool directory: %s", toolsDir)
 	if err := os.MkdirAll(toolsDir, os.ModePerm); err != nil {
 		return fmt.Errorf("failed to create directory %s: %w", toolsDir, err)