feat: upgrade golangcilint to v2

Author: shyim

.golangci.yml

@@ -1,22 +1,17 @@
+version: "2"
+
 linters:
-  # please, do not use `enable-all`: it's deprecated and will be removed soon.
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
-  disable-all: true
   enable:
     - bodyclose
     - exhaustive
     - goconst
-    - gofmt
     - goprintffuncname
-    #    - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
     - nakedret
     - noctx
     - staticcheck
-    - typecheck
     - unconvert
     - unparam
     - unused
@@ -48,18 +43,20 @@ linters:
     - godot
     - godox
     - nilnil
+  exclusions:
+    rules:
+      - path: cmd\/*
+        linters:
+          - forbidigo
 
-linters-settings:
-  gci:
-    sections:
-      - Standard
-      - Default
-      - "Prefix(github.com/shopware/shopware-cli)"
-
-issues:
-  exclude-dirs:
-    - version
-  exclude-rules:
-    - path: cmd\/*
-      linters:
-        - forbidigo
+formatters:
+  enable:
+    - gofmt
+    - gci
+  settings:
+    gci:
+      sections:
+        - Standard
+        - Default
+        - "Prefix(github.com/shopware/shopware-cli)"
+  

cmd/account/account_producer_extension_info_push.go

@@ -282,9 +282,10 @@ func updateStoreInfo(ext *accountApi.Extension, zipExt extension.Extension, cfg
 }
 
 func getTranslation[T extension.Translatable](language string, config extension.ConfigTranslated[T]) *T {
-	if language == "de" {
+	switch language {
+	case "de":
 		return config.German
-	} else if language == "en" {
+	case "en":
 		return config.English
 	}
 

cmd/extension/extension_admin_watch.go

@@ -12,21 +12,18 @@ import (
 	"strings"
 	"time"
 
-	"github.com/shopware/shopware-cli/shop"
-	"golang.org/x/net/html"
-
-	"github.com/shopware/shopware-cli/internal/asset"
-
-	htmlprinter "github.com/shyim/go-htmlprinter"
-
 	"github.com/NYTimes/gziphandler"
 	"github.com/evanw/esbuild/pkg/api"
+	htmlprinter "github.com/shyim/go-htmlprinter"
 	"github.com/spf13/cobra"
 	"github.com/vulcand/oxy/v2/forward"
+	"golang.org/x/net/html"
 
 	"github.com/shopware/shopware-cli/extension"
+	"github.com/shopware/shopware-cli/internal/asset"
 	"github.com/shopware/shopware-cli/internal/esbuild"
 	"github.com/shopware/shopware-cli/logging"
+	"github.com/shopware/shopware-cli/shop"
 )
 
 const schemeHostSeparator = "://"

cmd/project/ci.go

@@ -11,13 +11,14 @@ import (
 	"strings"
 
 	"dario.cat/mergo"
+	"github.com/spf13/cobra"
+	"golang.org/x/text/language"
+
 	"github.com/shopware/shopware-cli/extension"
 	"github.com/shopware/shopware-cli/internal/packagist"
 	"github.com/shopware/shopware-cli/internal/phpexec"
 	"github.com/shopware/shopware-cli/logging"
 	"github.com/shopware/shopware-cli/shop"
-	"github.com/spf13/cobra"
-	"golang.org/x/text/language"
 )
 
 // cleanupPaths are paths that are not nesscarry for the production build.
@@ -57,7 +58,7 @@ var projectCI = &cobra.Command{
 		}
 
 		// Remove annoying cache invalidation errors while asset install
-		os.Setenv("SHOPWARE_SKIP_ASSET_INSTALL_CACHE_INVALIDATION", "1")
+		_ = os.Setenv("SHOPWARE_SKIP_ASSET_INSTALL_CACHE_INVALIDATION", "1")
 
 		shopCfg, err := shop.ReadConfig(projectConfigPath, true)
 		if err != nil {

cmd/project/platform.go

@@ -9,11 +9,12 @@ import (
 	"slices"
 	"strings"
 
+	"github.com/spf13/cobra"
+
 	"github.com/shopware/shopware-cli/extension"
 	"github.com/shopware/shopware-cli/internal/asset"
 	"github.com/shopware/shopware-cli/logging"
 	"github.com/shopware/shopware-cli/shop"
-	"github.com/spf13/cobra"
 )
 
 func findClosestShopwareProject() (string, error) {

cmd/project/project.go

@@ -1,8 +1,9 @@
 package project
 
 import (
-	"github.com/shopware/shopware-cli/shop"
 	"github.com/spf13/cobra"
+
+	"github.com/shopware/shopware-cli/shop"
 )
 
 var projectConfigPath string

cmd/project/project_admin_build.go

@@ -3,12 +3,12 @@ package project
 import (
 	"path/filepath"
 
-	"github.com/shopware/shopware-cli/internal/phpexec"
-	"github.com/shopware/shopware-cli/shop"
+	"github.com/spf13/cobra"
 
 	"github.com/shopware/shopware-cli/extension"
+	"github.com/shopware/shopware-cli/internal/phpexec"
 	"github.com/shopware/shopware-cli/logging"
-	"github.com/spf13/cobra"
+	"github.com/shopware/shopware-cli/shop"
 )
 
 var projectAdminBuildCmd = &cobra.Command{

cmd/project/project_admin_watch.go

@@ -5,10 +5,11 @@ import (
 	"os/exec"
 	"path"
 
+	"github.com/spf13/cobra"
+
 	"github.com/shopware/shopware-cli/extension"
 	"github.com/shopware/shopware-cli/internal/phpexec"
 	"github.com/shopware/shopware-cli/shop"
-	"github.com/spf13/cobra"
 )
 
 var projectAdminWatchCmd = &cobra.Command{

cmd/project/project_autofix_composer.go

@@ -9,10 +9,11 @@ import (
 	"github.com/charmbracelet/huh"
 	"github.com/charmbracelet/huh/spinner"
 	"github.com/charmbracelet/lipgloss"
+	"github.com/spf13/cobra"
+
 	"github.com/shopware/shopware-cli/extension"
 	"github.com/shopware/shopware-cli/internal/packagist"
 	"github.com/shopware/shopware-cli/logging"
-	"github.com/spf13/cobra"
 )
 
 var projectAutofixComposerCmd = &cobra.Command{

cmd/project/project_autofix_flex.go

@@ -6,9 +6,10 @@ import (
 	"path"
 
 	"github.com/charmbracelet/huh"
+	"github.com/spf13/cobra"
+
 	"github.com/shopware/shopware-cli/internal/color"
 	"github.com/shopware/shopware-cli/internal/flexmigrator"
-	"github.com/spf13/cobra"
 )
 
 var projectAutofixFlexCmd = &cobra.Command{