fix: update icon size validation and compression settings

Author: shyim

extension/icon.go

@@ -49,7 +49,11 @@ func ResizeExtensionIcon(ctx context.Context, ext Extension) error {
 		return fmt.Errorf("cannot create icon file: %w", err)
 	}
 
-	if err := png.Encode(writeFile, dst); err != nil {
+	encoder := png.Encoder{
+		CompressionLevel: png.BestCompression,
+	}
+
+	if err := encoder.Encode(writeFile, dst); err != nil {
 		return fmt.Errorf("cannot encode icon: %w", err)
 	}
 

extension/platform_test.go

@@ -109,9 +109,8 @@ func TestPluginIconIsTooBig(t *testing.T) {
 
 	plugin.Validate(getTestContext(), ctx)
 
-	assert.Len(t, ctx.errors, 2)
-	assert.Equal(t, "The extension icon Resources/config/plugin.png is bigger than 50kb", ctx.errors[0].Message)
-	assert.Equal(t, "The extension icon Resources/config/plugin.png dimensions (1000x1000) are larger than maximum 256x256 pixels with max file size 50kb and 72dpi", ctx.errors[1].Message)
+	assert.Len(t, ctx.errors, 1)
+	assert.Equal(t, "The extension icon Resources/config/plugin.png dimensions (1000x1000) are larger than maximum 256x256 pixels with max file size 30kb and 72dpi", ctx.errors[0].Message)
 }
 
 func TestPluginGermanDescriptionMissing(t *testing.T) {

extension/test_helper.go

@@ -4,7 +4,6 @@ import (
 	"image"
 	"image/color"
 	"image/png"
-	"math/rand"
 	"os"
 )
 
@@ -14,9 +13,16 @@ func createTestImage(path string) error {
 
 func createTestImageWithSize(path string, width, height int) error {
 	img := image.NewRGBA(image.Rect(0, 0, width, height))
+
+	// Create a simple pattern with fewer colors for better compression
 	for x := 0; x < width; x++ {
 		for y := 0; y < height; y++ {
-			img.Set(x, y, color.RGBA{uint8(rand.Intn(255)), uint8(rand.Intn(255)), uint8(rand.Intn(255)), 255})
+			// Simple checkerboard pattern with just 2 colors
+			if (x/4+y/4)%2 == 0 {
+				img.Set(x, y, color.RGBA{220, 220, 220, 255}) // Light gray
+			} else {
+				img.Set(x, y, color.RGBA{180, 180, 180, 255}) // Slightly darker gray
+			}
 		}
 	}
 
@@ -29,5 +35,9 @@ func createTestImageWithSize(path string, width, height int) error {
 		_ = f.Close()
 	}()
 
-	return png.Encode(f, img)
+	encoder := png.Encoder{
+		CompressionLevel: png.BestCompression,
+	}
+
+	return encoder.Encode(f, img)
 }

extension/validator.go

@@ -99,8 +99,8 @@ func validateExtensionIcon(ctx *ValidationContext) {
 	if os.IsNotExist(err) {
 		ctx.AddError("metadata.icon", fmt.Sprintf("The extension icon %s does not exist", relPath))
 	} else if err == nil {
-		if info.Size() > 50*1024 {
-			ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s is bigger than 50kb", relPath))
+		if info.Size() > 30*1024 {
+			ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s is bigger than 30kb", relPath))
 		}
 
 		file, err := os.Open(fullIconPath)
@@ -112,9 +112,9 @@ func validateExtensionIcon(ctx *ValidationContext) {
 				ctx.AddError("metadata.icon", fmt.Sprintf("Could not decode icon image %s: %s", relPath, err.Error()))
 			} else {
 				if config.Width < 112 || config.Height < 112 {
-					ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s dimensions (%dx%d) are smaller than required 112x112 and maximum 256x256 pixels with max file size 50kb and 72dpi", relPath, config.Width, config.Height))
+					ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s dimensions (%dx%d) are smaller than required 112x112 and maximum 256x256 pixels with max file size 30kb and 72dpi", relPath, config.Width, config.Height))
 				} else if config.Width > 256 || config.Height > 256 {
-					ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s dimensions (%dx%d) are larger than maximum 256x256 pixels with max file size 50kb and 72dpi", relPath, config.Width, config.Height))
+					ctx.AddError("metadata.icon.size", fmt.Sprintf("The extension icon %s dimensions (%dx%d) are larger than maximum 256x256 pixels with max file size 30kb and 72dpi", relPath, config.Width, config.Height))
 				}
 			}