Background
During the Babel to SWC migration (#666), we discovered several files with formatting inconsistencies that don't match the project's Prettier and ESLint configurations.
Files with Formatting Issues
The following files have formatting that doesn't match current linter rules:
client/app/packs/server-bundle.js - Uses double quotes instead of single quotes
config/webpack/clientWebpackConfig.js - Missing proper file ending
config/webpack/commonWebpackConfig.js - Inconsistent line wrapping and trailing commas
config/webpack/development.js - Extra blank lines
client/app/bundles/comments/rescript/RescriptShow/ror_components/RescriptShow.jsx - ReScript-generated file with double quotes
Proposed Solution
Create a focused PR to:
- Run
yarn lint --fix across the entire codebase
- Fix any linting errors that can't be auto-fixed
- Ensure all files conform to
.prettierrc.yml and .eslintrc rules
- Consider updating
.prettierignore to exclude ReScript-generated files if needed
Why Separate PR?
- Keeps PRs focused on specific changes
- Makes code review easier
- Separates functional changes from formatting changes
- Establishes a clean baseline for future linting
Acceptance Criteria
Background
During the Babel to SWC migration (#666), we discovered several files with formatting inconsistencies that don't match the project's Prettier and ESLint configurations.
Files with Formatting Issues
The following files have formatting that doesn't match current linter rules:
client/app/packs/server-bundle.js- Uses double quotes instead of single quotesconfig/webpack/clientWebpackConfig.js- Missing proper file endingconfig/webpack/commonWebpackConfig.js- Inconsistent line wrapping and trailing commasconfig/webpack/development.js- Extra blank linesclient/app/bundles/comments/rescript/RescriptShow/ror_components/RescriptShow.jsx- ReScript-generated file with double quotesProposed Solution
Create a focused PR to:
yarn lint --fixacross the entire codebase.prettierrc.ymland.eslintrcrules.prettierignoreto exclude ReScript-generated files if neededWhy Separate PR?
Acceptance Criteria
yarn lintwithout warningsbundle exec rubocopwithout offenses