|
| 1 | +// @ts-check |
| 2 | +const {test, expect} = require('@playwright/test'); |
| 3 | + |
| 4 | +// Regression test for the backpack drag-over highlight. |
| 5 | +// |
| 6 | +// Two bugs prevented the backpack from highlighting when a block was |
| 7 | +// dragged over it: |
| 8 | +// |
| 9 | +// 1. The backpack used onMouseEnter/onMouseLeave, but Blockly calls |
| 10 | +// preventDefault() on pointermove during drags, which suppresses |
| 11 | +// compatibility mouse events on Firefox. Fixed by switching to |
| 12 | +// onPointerEnter/onPointerLeave. |
| 13 | +// |
| 14 | +// 2. The dragged block's SVG children had pointer-events:auto, causing |
| 15 | +// them to steal hover/pointer events from elements underneath. |
| 16 | +// Fixed by setting pointer-events:none on all drag surface children |
| 17 | +// in scratch-blocks. |
| 18 | + |
| 19 | +test('backpack highlights when a block is dragged over it', async ({page}) => { |
| 20 | + await page.goto('index.html?backpack_host=fake'); |
| 21 | + |
| 22 | + // Expand the backpack. |
| 23 | + await page.getByText('Backpack', {exact: true}).click(); |
| 24 | + const backpackList = page.locator('[class*="backpack-list"]').first(); |
| 25 | + await expect(backpackList).toBeVisible(); |
| 26 | + |
| 27 | + // Find a visible flyout block. The flyout contains blocks from all |
| 28 | + // categories (187+), most offscreen. Filter to blocks that are in |
| 29 | + // the viewport and large enough to be a real block (not a field). |
| 30 | + const block = await page.evaluate(() => { |
| 31 | + const blocks = document.querySelectorAll('.blocklyFlyout .blocklyDraggable'); |
| 32 | + for (const b of blocks) { |
| 33 | + const rect = b.getBoundingClientRect(); |
| 34 | + if (rect.y > 80 && rect.y < window.innerHeight && rect.height > 20 && rect.width > 50) { |
| 35 | + return {x: rect.x + (rect.width / 2), y: rect.y + (rect.height / 2)}; |
| 36 | + } |
| 37 | + } |
| 38 | + return null; |
| 39 | + }); |
| 40 | + expect(block, 'should find a visible flyout block').not.toBeNull(); |
| 41 | + |
| 42 | + const backpackBox = await backpackList.boundingBox(); |
| 43 | + |
| 44 | + // Drag a block from the flyout across the workspace to the backpack. |
| 45 | + await page.mouse.move(block.x, block.y); |
| 46 | + await page.mouse.down(); |
| 47 | + await page.mouse.move(block.x + 200, block.y, {steps: 10}); |
| 48 | + await page.mouse.move( |
| 49 | + backpackBox.x + (backpackBox.width / 2), |
| 50 | + backpackBox.y + (backpackBox.height / 2), |
| 51 | + {steps: 10} |
| 52 | + ); |
| 53 | + |
| 54 | + await expect(backpackList).toHaveClass(/drag-over/); |
| 55 | + |
| 56 | + await page.mouse.up(); |
| 57 | +}); |
0 commit comments