Document basic-auth feature

Author: Simon Bernier St-Pierre

Cargo.toml

@@ -14,7 +14,7 @@ readme = "README.md"
 repository = "https://github.com/sbstp/attohttpc"
 
 [dependencies]
-base64 = {version = "0.13", optional=true}
+base64 = {version = "0.13", optional = true}
 encoding_rs = {version = "0.8", optional = true}
 encoding_rs_io = {version = "0.1", optional = true}
 flate2 = {version = "1.0", optional = true}
@@ -47,6 +47,7 @@ tokio-stream = {version = "0.1", features = ["net"]}
 warp = "0.3"
 
 [features]
+basic-auth = ["base64"]
 charsets = ["encoding_rs", "encoding_rs_io"]
 compress = ["flate2"]
 default = ["compress", "tls"]

README.md

@@ -16,6 +16,7 @@ possible to allow users to get just what they need. Here are the goals of the pr
 * Use quality crates from the ecosystem (`http`, `url`, `encoding_rs`), not reinventing the wheel.
 
 ## Features
+* `basic-auth` support for basic auth
 * `charsets` support for decoding more text encodings than just UTF-8
 * `compress` support for decompressing response bodies (**default**)
 * `json` support for serialization and deserialization

run-tests.bash

@@ -13,6 +13,7 @@ fi
 cargo test
 cargo test --all-features
 cargo test --no-default-features
+cargo test --no-default-features --features basic-auth
 cargo test --no-default-features --features charsets
 cargo test --no-default-features --features compress
 cargo test --no-default-features --features form

src/request/builder.rs

@@ -125,7 +125,7 @@ impl<B> RequestBuilder<B> {
     }
 
     /// Enable HTTP basic authentication.
-    #[cfg(feature = "base64")]
+    #[cfg(feature = "basic-auth")]
     pub fn basic_auth(self, username: impl std::fmt::Display, password: Option<impl std::fmt::Display>) -> Self {
         let auth = match password {
             Some(password) => format!("{}:{}", username, password),