Merge pull request #1144 from roboflow/feat/add-frame-seconds-since-start-to-property-definition

Add seconds_since_start to PropertyDefinition extract_frame_metadata

Author: grzegorz-roboflow

inference/core/workflows/core_steps/common/query_language/entities/enums.py

@@ -106,6 +106,7 @@ class ImageProperty(Enum):
 class FrameMetadataProperty(Enum):
     FRAME_NUMBER = "frame_number"
     FRAME_TIMESTAMP = "frame_timestamp"
+    SECONDS_SINCE_START = "seconds_since_start"
 
 
 class DetectionsSelectionMode(Enum):

inference/core/workflows/core_steps/common/query_language/operations/frame_metadata/base.py

@@ -15,6 +15,10 @@
 PROPERTY_EXTRACTORS = {
     FrameMetadataProperty.FRAME_NUMBER: lambda image: image.video_metadata.frame_number,
     FrameMetadataProperty.FRAME_TIMESTAMP: lambda image: image.video_metadata.frame_timestamp,
+    FrameMetadataProperty.SECONDS_SINCE_START: lambda image: (
+        image.video_metadata.frame_number - 1
+    )
+    / image.video_metadata.fps,
 }
 
 

tests/workflows/integration_tests/execution/test_workflow_with_property_extraction.py

@@ -856,6 +856,14 @@ def test_workflow_with_frame_number_extraction_from_photo(
                 {"type": "ExtractFrameMetadata", "property_name": "frame_number"}
             ],
         },
+        {
+            "type": "PropertyDefinition",
+            "name": "seconds_since_start",
+            "data": "$inputs.image",
+            "operations": [
+                {"type": "ExtractFrameMetadata", "property_name": "seconds_since_start"}
+            ],
+        },
     ],
     "outputs": [
         {
@@ -868,6 +876,11 @@ def test_workflow_with_frame_number_extraction_from_photo(
             "name": "frame_number",
             "selector": "$steps.frame_number.output",
         },
+        {
+            "type": "JsonField",
+            "name": "seconds_since_start",
+            "selector": "$steps.seconds_since_start.output",
+        },
     ],
 }
 
@@ -895,6 +908,7 @@ def test_workflow_with_timestamp_extraction_from_photo(
     assert set(result[0].keys()) == {
         "frame_timestamp",
         "frame_number",
+        "seconds_since_start",
     }, "Expected all declared outputs to be delivered"
 
 
@@ -942,10 +956,12 @@ def on_prediction(prediction: dict, video_frame: VideoFrame) -> None:
     assert set(predictions[0].keys()) == {
         "frame_timestamp",
         "frame_number",
+        "seconds_since_start",
     }, "Expected all declared outputs to be delivered"
 
     for i in range(1, frames_count + 1):
         assert predictions[i - 1]["frame_number"] == i
         assert predictions[i - 1][
             "frame_timestamp"
         ] == timestamp_created + datetime.timedelta(seconds=(i - 1) / fps)
+        assert predictions[i - 1]["seconds_since_start"] == (i - 1) / fps