Skip to content

feat: Replace keyboard.json dialogs with tabbed editor #987

feat: Replace keyboard.json dialogs with tabbed editor

feat: Replace keyboard.json dialogs with tabbed editor #987

Triggered via pull request March 25, 2026 22:37
Status Failure
Total duration 1m 39s
Artifacts

pullrequest.yaml

on: pull_request
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 11 warnings
Build (20.x)
Process completed with exit code 1.
Build (20.x): src/components/workbench/dialogs/LayoutPreviewDialog.tsx#L571
Definition for rule 'react-hooks/exhaustive-deps' was not found
Build (20.x): src/components/workbench/dialogs/KeyboardJsonEditorDialog.tsx#L654
Definition for rule 'react-hooks/exhaustive-deps' was not found
Build (20.x)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build (20.x): src/components/workbench/visualeditor/VisualKeymapEditor.tsx#L137
Replace `⏎····window.innerWidth·-·200·<·right·||⏎····(isThin·&&·!isLeftSideKey)⏎··` with `window.innerWidth·-·200·<·right·||·(isThin·&&·!isLeftSideKey)`
Build (20.x): src/components/workbench/visualeditor/VisualKeymapEditor.tsx#L115
Replace `⏎··target:·HTMLElement⏎` with `target:·HTMLElement`
Build (20.x): src/components/workbench/visualeditor/VisualKeymapEditor.tsx#L1
Replace `·useState,·useMemo,·useCallback,·useEffect,·useRef·` with `⏎··useState,⏎··useMemo,⏎··useCallback,⏎··useEffect,⏎··useRef,⏎`
Build (20.x): src/components/workbench/visualeditor/VisualKeycap.tsx#L73
Replace `'"{{name}}"·is·a·custom·keycode·defined·in·the·source·code.·It·cannot·be·edited·in·the·Visual·Editor.',·{·name:·label·}` with `⏎········'"{{name}}"·is·a·custom·keycode·defined·in·the·source·code.·It·cannot·be·edited·in·the·Visual·Editor.',⏎········{·name:·label·}⏎······`
Build (20.x): src/components/workbench/header/Header.tsx#L34
'set' is defined but never used. Allowed unused vars must match /^_/u
Build (20.x): src/components/workbench/header/Header.container.ts#L8
'IWorkbenchProjectFile' is defined but never used. Allowed unused vars must match /^_/u
Build (20.x): src/components/common/customkey/TabKey.tsx#L131
Replace `⏎········labelLang,⏎········this.props.customKeycodes⏎······` with `labelLang,·this.props.customKeycodes`