Gracefully handle invalid preference/propellant files

Author: reilleya

uilib/fileManager.py

@@ -251,7 +251,8 @@ def checkPropellant(self, motor):
     def loadRecentlyOpenedFilesList(self):
         try:
             self.recentFilesList = loadFile(self.recentFilesPath, fileTypes.RECENT_FILES)['recentFilesList']
-        except FileNotFoundError:
+        except:
+            # No need to back up any existing file because a user likely doesn't care about the contents
             logger.warn('Unable to load recent files, creating new file at {}'.format(self.recentFilesPath))
             self.recentFilesList = []
             saveFile(self.recentFilesPath, {'recentFilesList': self.recentFilesList}, fileTypes.RECENT_FILES)

uilib/preferencesManager.py

@@ -1,4 +1,8 @@
+from os.path import join
+from os import replace
+
 from PyQt6.QtCore import QObject, pyqtSignal
+from PyQt6.QtWidgets import QApplication
 
 from motorlib.properties import PropertyCollection, EnumProperty
 from motorlib.units import unitLabels, getAllConversions
@@ -54,12 +58,19 @@ def newPreferences(self, prefDict):
         self.publishPreferences()
 
     def loadPreferences(self):
+        preferencesPath = join(getConfigPath(), 'preferences.yaml')
         try:
-            prefDict = loadFile(getConfigPath() + 'preferences.yaml', fileTypes.PREFERENCES)
+            prefDict = loadFile(preferencesPath, fileTypes.PREFERENCES)
             self.preferences.applyDict(prefDict)
             self.publishPreferences()
         except FileNotFoundError:
-            logger.warn('Unable to load preferences, creating new file')
+            logger.warn('Preferences file does not exist, creating new file')
+            self.savePreferences()
+        except Exception as error:
+            backupPath = join(getConfigPath(), 'preferences_backup.yaml')
+            logger.warn('Error loading preferences: {}'.format(error))
+            QApplication.instance().outputException(error, "Failed to load preferences. Backing up file to '{}' and starting fresh.".format(backupPath))
+            replace(preferencesPath, backupPath)
             self.savePreferences()
 
     def savePreferences(self):

uilib/propellantManager.py

@@ -1,4 +1,8 @@
+from os.path import join
+from os import replace
+
 from PyQt6.QtCore import QObject, pyqtSignal
+from PyQt6.QtWidgets import QApplication
 
 import motorlib
 
@@ -20,6 +24,7 @@ def __init__(self):
         self.propMenu.closed.connect(self.updated.emit)
 
     def loadPropellants(self):
+        propellantsPath = join(getConfigPath(), 'propellants.yaml')
         try:
             propList = loadFile(getConfigPath() + 'propellants.yaml', fileTypes.PROPELLANTS)
             for propDict in propList:
@@ -30,6 +35,13 @@ def loadPropellants(self):
             logger.warn('No propellant file found, saving defaults')
             self.propellants = [motorlib.propellant.Propellant(prop) for prop in DEFAULT_PROPELLANTS]
             self.savePropellants()
+        except Exception as error:
+            backupPath = join(getConfigPath(), 'propellants_backup.yaml')
+            logger.warn('Error loading propellants: {}'.format(error))
+            QApplication.instance().outputException(error, "Failed to load propellants. Backing up file to '{}' and starting fresh.".format(backupPath))
+            replace(propellantsPath, backupPath)
+            self.propellants = [motorlib.propellant.Propellant(prop) for prop in DEFAULT_PROPELLANTS]
+            self.savePropellants()
 
     def savePropellants(self):
         propellants = [prop.getProperties() for prop in self.propellants]