Skip to content

Commit d231278

Browse files
committed
code review changes
1 parent c205b20 commit d231278

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/skills/build.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ sudo make install
152152

153153
All flags are defined in `CMake/lrs_options.cmake`.
154154

155+
> **Rule:** When adding a new CMake build flag, always declare it with `option()` in `CMake/lrs_options.cmake` — never inline in a subdirectory `CMakeLists.txt`. This keeps all flags discoverable in one place and ensures they appear in `cmake-gui`/`ccmake` regardless of which subdirectory is being configured.
156+
155157
| Flag | Default | Description |
156158
|---|---|---|
157159
| `BUILD_SHARED_LIBS` | ON | Build as shared library (`OFF` for static) |

0 commit comments

Comments
 (0)