Skip to content

Commit 83fcdcb

Browse files
committed
fix(sdk): remove non-secret flags from SENSITIVE_ARGUMENTS
Remove --atlas-public-key (API key identifier, not a secret), --github-app-key and --github-app-key-path (file paths, not secret values) from redaction lists.
1 parent 42f10ab commit 83fcdcb

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

prowler/providers/github/lib/arguments/arguments.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
1-
SENSITIVE_ARGUMENTS = frozenset(
2-
{
3-
"--personal-access-token",
4-
"--oauth-app-token",
5-
"--github-app-key",
6-
"--github-app-key-path",
7-
}
8-
)
1+
SENSITIVE_ARGUMENTS = frozenset({"--personal-access-token", "--oauth-app-token"})
92

103

114
def init_parser(self):

prowler/providers/mongodbatlas/lib/arguments/arguments.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SENSITIVE_ARGUMENTS = frozenset({"--atlas-private-key", "--atlas-public-key"})
1+
SENSITIVE_ARGUMENTS = frozenset({"--atlas-private-key"})
22

33

44
def init_parser(self):

tests/lib/cli/redact_test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,7 @@ def test_discovers_known_sensitive_arguments(self):
9595
assert "--shodan" in result
9696
assert "--personal-access-token" in result
9797
assert "--oauth-app-token" in result
98-
assert "--github-app-key" in result
99-
assert "--github-app-key-path" in result
10098
assert "--atlas-private-key" in result
101-
assert "--atlas-public-key" in result
10299
assert "--nhn-password" in result
103100
assert "--os-password" in result
104101

0 commit comments

Comments
 (0)