finalizing

Author: Mzack9999

pkg/catalog/index/filter.go

@@ -184,23 +184,6 @@ func (f *Filter) matchesIncludes(m *Metadata) bool {
 	return true
 }
 
-// matchesID checks if template ID matches pattern (supports wildcards).
-// Deprecated: replaced by matchesIncludeID, only here for benchmark (and PR)
-// TODO: Remove before PR merged.
-func matchesID(templateID, pattern string) bool {
-	// Convert to lowercase for case-insensitive matching
-	templateID = strings.ToLower(templateID)
-	pattern = strings.ToLower(pattern)
-
-	if templateID == pattern {
-		return true
-	}
-
-	matched, _ := filepath.Match(pattern, templateID)
-
-	return matched
-}
-
 // Compile pre-processes IDs and ExcludeIDs into fast lookup structures.
 // The first time Matches is called, this is called automatically.
 // If IDs or ExcludeIDs are modified after calling Matches, this must be called manually.

pkg/catalog/index/filter_bench_test.go

@@ -59,36 +59,3 @@ func BenchmarkFilterMatches(b *testing.B) {
 		})
 	}
 }
-
-func BenchmarkFilterMatches_Old(b *testing.B) {
-	corpus := makeMetadataCorpus(templateCount)
-
-	cases := []struct{ exact, wildcards int }{
-		{10, 0},
-		{100, 0},
-		{1000, 0},
-		{100, 1},
-		{100, 3},
-		{100, 5},
-	}
-
-	for _, tc := range cases {
-		b.Run(fmt.Sprintf("ids=%d,patterns=%d", tc.exact, tc.wildcards), func(b *testing.B) {
-			b.ReportAllocs()
-
-			ids := mixedFilter(tc.exact, tc.wildcards).IDs
-			for b.Loop() {
-				for _, meta := range corpus {
-					matched := false
-					for _, id := range ids {
-						if matchesID(meta.ID, id) {
-							matched = true
-							break
-						}
-					}
-					_ = matched
-				}
-			}
-		})
-	}
-}