refactor: replace has-own-prop with local utility, remove unused deps

Author: privatenumber

package.json

@@ -62,13 +62,11 @@
 		"webpack": "^4.42.0 || ^5.10.0"
 	},
 	"devDependencies": {
-		"@types/webpack": "^4.41.32",
-		"@types/webpack-manifest-plugin": "^3.0.5",
+		"@types/webpack": "^4.41.40",
 		"@types/webpack-sources": "^3.2.0",
 		"alias-imports": "^1.0.0",
 		"clean-pkg-json": "^1.2.0",
 		"css-loader": "^5.2.4",
-		"has-own-prop": "^3.1.0",
 		"lintroll": "^1.30.0",
 		"manten": "^2.0.0",
 		"mini-css-extract-plugin": "^1.6.0",

pnpm-lock.yaml

@@ -24,3 +24,4 @@ declare module 'webpack/lib/WebpackError.js' {
 /* eslint-enable @typescript-eslint/no-explicit-any */
 
 declare module 'mini-css-extract-plugin';
+declare module 'webpack-manifest-plugin';

src/@types/webpack.d.ts

@@ -10,8 +10,7 @@ import { stringifyAstNode } from './utils/stringify-ast-node.ts';
 import { handleSingleLocaleLocalization } from './single-locale.ts';
 import { handleMultiLocaleLocalization } from './multi-locale/index.ts';
 import { warnOnUnusedKeys } from './utils/warn-on-unused-keys.ts';
-
-const name = 'webpack-localize-assets-plugin';
+import { name } from './plugin-name.ts';
 
 const defaultLocalizerName = '__';
 

src/index.ts

@@ -11,12 +11,11 @@ import {
 } from '../utils/on-localizer-call.ts';
 import { onAssetPath, onOptimizeAssets } from '../utils/webpack.ts';
 import { replaceLocaleInAssetName } from '../utils/localize-filename.ts';
+import { name } from '../plugin-name.ts';
 import { insertPlaceholderFunction } from './localizer-function.ts';
 import { generateLocalizedAssets } from './generate-localized-assets.ts';
 import { assetNamePlaceholder } from './asset-name.ts';
 
-const name = 'webpack-localize-assets-plugin';
-
 export const handleMultiLocaleLocalization = (
 	compilation: WP5.Compilation,
 	normalModuleFactory: NormalModuleFactory,

src/multi-locale/index.ts

@@ -15,8 +15,7 @@ import type {
 } from '../types-internal.ts';
 import { pushUniqueError } from '../utils/webpack.ts';
 import { callLocalizeCompiler } from '../utils/call-localize-compiler.ts';
-
-const name = 'webpack-localize-assets-plugin';
+import { name } from '../plugin-name.ts';
 
 const placeholderFunctionName = `_placeholder${sha256(name).slice(0, 8)}`;
 

src/multi-locale/localizer-function.ts

@@ -0,0 +1 @@
+export const name = 'webpack-localize-assets-plugin';

src/plugin-name.ts

@@ -1,6 +1,6 @@
 import type WP4 from 'webpack';
 import type WP5 from 'webpack5';
-import hasOwnProp from 'has-own-prop';
+import { hasOwn } from './utils/has-own.ts';
 import type {
 	LocaleName,
 	LocaleStrings,
@@ -20,7 +20,7 @@ export const validateOptions = <LocalizedData>(options: Options<LocalizedData>):
 		throw new Error('locales must contain at least one locale');
 	}
 	if (options.sourceMapForLocales
-		&& options.sourceMapForLocales.some(locale => !hasOwnProp(options.locales, locale))) {
+		&& options.sourceMapForLocales.some(locale => !hasOwn(options.locales, locale))) {
 		throw new Error('sourceMapForLocales must contain valid locales');
 	}
 	if (options.localizeCompiler) {

src/types-internal.ts

@@ -0,0 +1,6 @@
+const { hasOwnProperty } = Object.prototype;
+
+export const hasOwn = (
+	object: object,
+	property: PropertyKey,
+) => hasOwnProperty.call(object, property);

src/utils/has-own.ts

@@ -1,13 +1,13 @@
 import path from 'path';
 import type { readFileSync } from 'fs';
-import hasOwnProp from 'has-own-prop';
 import type {
 	Compiler,
 	UnprocessedLocalesMap,
 	LocaleName,
 	LocalesMap,
 	LocaleFilePath,
 } from '../types-internal.ts';
+import { hasOwn } from './has-own.ts';
 
 type FSLike = {
 	readFileSync: typeof readFileSync;
@@ -35,7 +35,7 @@ export const loadLocaleData = (
 	const paths = new Set<LocaleFilePath>();
 
 	for (const localeName in unprocessedLocales) {
-		if (!hasOwnProp(unprocessedLocales, localeName)) {
+		if (!hasOwn(unprocessedLocales, localeName)) {
 			continue;
 		}