Add stricter analysis options and fix problems

Author: MatthewLM

coinlib/analysis_options.yaml

@@ -1,5 +1,11 @@
 include: package:lints/recommended.yaml
 
+analyzer:
+  language:
+    strict-casts: true
+    strict-inference: true
+    strict-raw-types: true
+
 # Lint rules and documentation, see http://dart-lang.github.io/linter/lints
 linter:
   rules:
@@ -10,3 +16,4 @@ linter:
     - unrelated_type_equality_checks
     - valid_regexps
     - require_trailing_commas
+    - comment_references

coinlib/lib/src/common/bytes.dart

@@ -16,9 +16,8 @@ Uint8List copyCheckBytes(
   Uint8List bytes, int length, { String name = "Bytes", }
 ) => Uint8List.fromList(checkBytes(bytes, length, name: name));
 
-/// Determines if two objects are equal Uint8List data
-bool bytesEqual(Object? a, Object? b)
-  => (a is Uint8List) && (b is Uint8List) && ListEquality().equals(a, b);
+/// Determines if two [Uint8List] lists are equal
+bool bytesEqual(Uint8List a, Uint8List b) => ListEquality<int>().equals(a, b);
 
 /// Compares two Uint8List bytes from the left-most to right-most byte. If all
 /// bytes are the same apart from one list being longer, the shortest list comes

coinlib/lib/src/common/checks.dart

@@ -1,25 +1,25 @@
 
-_checkInt(int i, int min, int max, String type, String name) {
+void _checkInt(int i, int min, int max, String type, String name) {
   if (i < min || i > max) {
     throw ArgumentError.value(i, name, "must be a $type");
   }
 }
 
-checkUint8(int i, [String name = "i"])
+void checkUint8(int i, [String name = "i"])
   => _checkInt(i, 0, 0xff, "uint8", name);
 
-checkUint16(int i, [String name = "i"])
+void checkUint16(int i, [String name = "i"])
   => _checkInt(i, 0, 0xffff, "uint16", name);
 
-checkUint32(int i, [String name = "i"])
+void checkUint32(int i, [String name = "i"])
   => _checkInt(i, 0, 0xffffffff, "uint32", name);
 
-checkInt32(int i, [String name = "i"])
+void checkInt32(int i, [String name = "i"])
   => _checkInt(i, -0x80000000, 0x7fffffff, "int32", name);
 
 final BigInt maxUint64 = (BigInt.from(1) << 64) - BigInt.one;
 
-checkUint64(BigInt i, [String name = "i"]) {
+void checkUint64(BigInt i, [String name = "i"]) {
   if (i.isNegative || i > maxUint64) {
     throw ArgumentError.value(i, name, "must be a uint64");
   }

coinlib/lib/src/crypto/ec_public_key.dart

@@ -2,7 +2,6 @@ import 'dart:typed_data';
 import 'package:coinlib/src/secp256k1/secp256k1.dart';
 import 'package:coinlib/src/common/bytes.dart';
 import 'package:coinlib/src/common/hex.dart';
-import 'package:collection/collection.dart';
 
 class InvalidPublicKey implements Exception {}
 
@@ -70,7 +69,7 @@ class ECPublicKey {
 
   @override
   bool operator ==(Object other)
-    => (other is ECPublicKey) && ListEquality().equals(_data, other._data);
+    => (other is ECPublicKey) && bytesEqual(_data, other._data);
 
   @override
   int get hashCode => _data[1] | _data[2] << 8 | _data[3] << 16 | _data[4] << 24;

coinlib/lib/src/crypto/ecdsa_signature.dart

@@ -45,7 +45,7 @@ class ECDSASignature {
     }
   }
 
-  /// Takes a BIP66 DER formatted [signature] as a HEX string.
+  /// Takes a BIP66 DER formatted signature as a HEX string.
   /// See [ECDSASignature.fromDer].
   factory ECDSASignature.fromDerHex(String hex)
     => ECDSASignature.fromDer(hexToBytes(hex));

coinlib/lib/src/crypto/message_signature.dart

@@ -14,7 +14,7 @@ class MagicHash with Writable {
   final String prefix;
   MagicHash(this.message, this.prefix);
 
-  static _writeUtf8(Writer writer, String msg)
+  static void _writeUtf8(Writer writer, String msg)
     => writer.writeVarSlice(utf8.encode(msg));
 
   @override
@@ -33,7 +33,7 @@ class MessageSignature {
 
   final ECDSARecoverableSignature signature;
 
-  static magicHash(String message, String prefix)
+  static Uint8List magicHash(String message, String prefix)
     => MagicHash(message, prefix).hash;
 
   MessageSignature.fromBase64(String str)

coinlib/lib/src/crypto/nums_public_key.dart

@@ -4,10 +4,10 @@ import 'package:coinlib/src/crypto/random.dart';
 
 /// A "nothing up my sleeve" [ECPublicKey] that is created from a point with no
 /// known private key and tweaked with a scalar value named [rTweak]. The key is
-/// reproduceable from this scalar using [fromRTweak]. Any of these keys have no
-/// known associted private key. Sharing the [rTweak] allows others to verify
-/// this. These keys can be used as Taproot internal keys where no key-path
-/// spending is desired.
+/// reproduceable from this scalar using [fromRTweak()]. Any of
+/// these keys have no known associted private key. Sharing the [rTweak] allows
+/// others to verify this. These keys can be used as Taproot internal keys where
+/// no key-path spending is desired.
 class NUMSPublicKey extends ECPublicKey {
 
   /// To prove that this point does not have an associated private key, the

coinlib/lib/src/scripts/operations.dart

@@ -1,9 +1,9 @@
 import 'dart:typed_data';
+import 'package:coinlib/src/common/bytes.dart';
 import 'package:coinlib/src/common/hex.dart';
 import 'package:coinlib/src/common/serial.dart';
 import 'package:coinlib/src/crypto/ec_public_key.dart';
 import 'package:coinlib/src/tx/inputs/input_signature.dart';
-import 'package:collection/collection.dart';
 import 'codes.dart';
 
 class InvalidScriptAsm implements Exception {}
@@ -312,7 +312,7 @@ class ScriptPushData implements ScriptOp {
 
   @override
   bool match(ScriptOp other)
-    => (other is ScriptPushData && ListEquality().equals(_data, other._data))
+    => (other is ScriptPushData && bytesEqual(_data, other._data))
     || (other is ScriptPushDataMatcher && _data.length == other.size);
 
 }

coinlib/lib/src/scripts/program.dart

@@ -20,8 +20,8 @@ abstract class Program {
 
   /// Takes a [script] and constructs a matching Program subclass if one exists,
   /// or a basic [RawProgram] if there is no match. The script should use
-  /// minimal pushes. [decompile] can be used directly on compiled scripts or
-  /// [fromAsm] can be used to match directly against ASM.
+  /// minimal pushes. [Program.decompile] can be used directly on compiled
+  /// scripts or [Program.fromAsm] can be used to match directly against ASM.
   factory Program.match(Script script) {
 
     try {

coinlib/lib/src/scripts/programs/p2sh.dart

@@ -15,7 +15,7 @@ class P2SH implements Program {
   late final Uint8List _scriptHash;
 
   /// Construct using an output script, not to be confused with the redeem
-  /// script. For that use [fromRedeemScript].
+  /// script. For that use [fromRedeemScript()].
   P2SH.fromScript(this.script) {
     if (!template.match(script)) throw NoProgramMatch();
     _scriptHash = (script[1] as ScriptPushData).data;