feat(sharing): opt-in per-user rate limiting on sharing operations#24
Closed
doctatortot wants to merge 1 commit into
Closed
feat(sharing): opt-in per-user rate limiting on sharing operations#24doctatortot wants to merge 1 commit into
doctatortot wants to merge 1 commit into
Conversation
Sharing had no rate limit -- one user could fire thousands of share ops in rapid succession. OmemError::RateLimited (429) existed but was never returned. Add an in-memory per-user token-bucket limiter (api/rate_limit.rs): OMEM_SHARE_RATE_PER_MIN tokens, refilling at per_min/60 per second (bursts up to the per-minute value allowed, then a steady rate); 0 = disabled (default, so no behavior change). Enforced at the top of all eight sharing handlers (share, pull, reshare, batch-share, share-all, share-to-user, share-all-to-user, org/publish) via state.share_rate_limiter.check(&auth.tenant_id)?; an empty bucket returns 429. State is process-local (Mutex<HashMap>); multi-replica deployments would need a shared store. Tests: rate_limit unit tests (burst-then-block, refill-over-time, per-key isolation, disabled) with injected time. Full suite green (392). fmt + clippy clean. Docs: .env.example + docs/SHARING.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Merge conflict after #23 landed (likely |
yhyyz
added a commit
that referenced
this pull request
May 21, 2026
- feat(sharing): opt-in per-user rate limiting (PR #24) Token-bucket limiter on all 8 sharing handlers. OMEM_SHARE_RATE_PER_MIN=0 (default, disabled). - feat(sharing): opt-in lazy auto-refresh stale shares on read (PR #21) Extracts refresh_shared_copy() helper, reused by reshare endpoint and new auto-refresh-on-read path in get_memory. OMEM_AUTO_REFRESH_SHARES=false (default, disabled). Co-authored-by: doctatortot <doctatortot@users.noreply.github.com>
Contributor
|
Applied in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sharing has no per-user/space rate limit — one user with write access can fire thousands of share operations in rapid succession.
OmemError::RateLimited(→ 429) existed but was never returned.Change
Add an opt-in per-user token-bucket limiter (
api/rate_limit.rs):OMEM_SHARE_RATE_PER_MINtokens; refillper_min / 60per second (bursts up to the per-minute value allowed, then steady).0= disabled (default) → no behavior change.share,pull,reshare,batch-share,share-all,share-to-user,share-all-to-user,org/publish):state.share_rate_limiter.check(&auth.tenant_id)?. An empty bucket returns the existing429.State is process-local (
Mutex<HashMap>); a multi-replica deployment would need a shared store (noted in the module docs).Tests
rate_limitunit tests with injected time (no sleeps): burst-then-block, refill-over-time, per-key isolation, disabled. Full suite green (392 passed); fmt + clippy clean (no new warnings).Docs
.env.example+docs/SHARING.md(the "No rate limiting" entry now reads "opt-in").