-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathconsumer_group_assignment_test.go
More file actions
533 lines (431 loc) · 14.1 KB
/
consumer_group_assignment_test.go
File metadata and controls
533 lines (431 loc) · 14.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
//go:build integration
package comet
import (
"context"
"fmt"
"os"
"sync"
"sync/atomic"
"testing"
"time"
)
// TestConsumerGroupShardAssignment tests that only one consumer per group can claim a shard
func TestConsumerGroupShardAssignment(t *testing.T) {
dir := t.TempDir()
// Write test data using default config (no process restrictions)
client, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
stream := "test:v1:shard:0000"
var messages [][]byte
for i := 0; i < 100; i++ {
messages = append(messages, []byte(fmt.Sprintf("msg-%03d", i)))
}
ctx := context.Background()
_, err = client.Append(ctx, stream, messages)
if err != nil {
t.Fatal(err)
}
// Sync to ensure messages are durable
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
client.Close()
// Small delay to ensure multi-process state is fully persisted
time.Sleep(100 * time.Millisecond)
// Test: Multiple consumers in same group with proper multi-process coordination
t.Run("SameGroup_ExclusiveAccess", func(t *testing.T) {
var totalProcessed int64
var wg sync.WaitGroup
// Start 3 consumers in same group, each with their own process ID
for i := 0; i < 3; i++ {
wg.Add(1)
go func(consumerID int) {
defer wg.Done()
// Each consumer gets its own process ID to avoid race conditions
processConfig := DeprecatedMultiProcessConfig(consumerID, 3)
client, err := NewClient(dir, processConfig)
if err != nil {
t.Errorf("Consumer %d failed to create client: %v", consumerID, err)
return
}
defer client.Close()
consumer := NewConsumer(client, ConsumerOptions{
Group: "exclusive-group", // Same group
})
defer consumer.Close()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
// Only process shards owned by this process
ownedShards := []uint32{}
for shardID := uint32(0); shardID < 1; shardID++ {
if processConfig.Concurrency.Owns(shardID) {
ownedShards = append(ownedShards, shardID)
}
}
if len(ownedShards) == 0 {
t.Logf("Consumer %d: No owned shards, skipping", consumerID)
return
}
processed := 0
err = consumer.Process(ctx, func(ctx context.Context, msgs []StreamMessage) error {
processed += len(msgs)
atomic.AddInt64(&totalProcessed, int64(len(msgs)))
return nil
}, WithShards(ownedShards...), WithBatchSize(10), WithAutoAck(true))
t.Logf("Consumer %d (Process %d) processed %d messages from shards %v", consumerID, consumerID, processed, ownedShards)
}(i)
}
wg.Wait()
// Verify: All messages processed exactly once
if totalProcessed != 100 {
t.Errorf("Expected 100 messages processed, got %d", totalProcessed)
}
})
// Test: Different groups should work independently
t.Run("DifferentGroups_IndependentAccess", func(t *testing.T) {
var wg sync.WaitGroup
results := make([]int, 3)
// Start 3 consumers in different groups, each with its own client to avoid race conditions
for i := 0; i < 3; i++ {
wg.Add(1)
go func(consumerID int) {
defer wg.Done()
// Each consumer gets its own client to avoid race conditions
client, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Errorf("Consumer %d failed to create client: %v", consumerID, err)
return
}
defer client.Close()
consumer := NewConsumer(client, ConsumerOptions{
Group: fmt.Sprintf("group-%d", consumerID), // Different groups
})
defer consumer.Close()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
processed := 0
consumer.Process(ctx, func(ctx context.Context, msgs []StreamMessage) error {
processed += len(msgs)
return nil
}, WithStream("test:v1:shard:*"), WithBatchSize(10), WithAutoAck(true))
results[consumerID] = processed
t.Logf("Consumer %d (group-%d) processed %d messages", consumerID, consumerID, processed)
}(i)
}
wg.Wait()
// Verify: Each group processed all messages independently
for i, processed := range results {
if processed != 100 {
t.Errorf("Group %d should process all 100 messages, got %d", i, processed)
}
}
})
}
// TestConsumerFailover tests that when a consumer dies, another can take over
func TestConsumerFailover(t *testing.T) {
dir := t.TempDir()
// Write test data using default config
client, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
stream := "failover:v1:shard:0000"
var messages [][]byte
for i := 0; i < 50; i++ {
messages = append(messages, []byte(fmt.Sprintf("msg-%03d", i)))
}
ctx := context.Background()
_, err = client.Append(ctx, stream, messages)
if err != nil {
t.Fatal(err)
}
// Sync to ensure messages are durable
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
client.Close()
// Small delay to ensure multi-process state is fully persisted
time.Sleep(100 * time.Millisecond)
// Consumer 1: Process some messages then "die"
client1, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
consumer1 := NewConsumer(client1, ConsumerOptions{Group: "failover-group"})
processed1 := 0
ctx1, cancel1 := context.WithTimeout(context.Background(), 1*time.Second)
consumer1.Process(ctx1, func(ctx context.Context, msgs []StreamMessage) error {
processed1 += len(msgs)
return nil
}, WithStream("failover:v1:shard:*"), WithBatchSize(5), WithAutoAck(true))
// Consumer 1 "dies"
consumer1.Close()
client1.Close()
cancel1()
t.Logf("Consumer 1 processed %d messages before dying", processed1)
// Consumer 2: Should take over and process remaining messages
client2, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
defer client2.Close()
consumer2 := NewConsumer(client2, ConsumerOptions{Group: "failover-group"})
defer consumer2.Close()
processed2 := 0
ctx2, cancel2 := context.WithTimeout(context.Background(), 3*time.Second)
defer cancel2()
consumer2.Process(ctx2, func(ctx context.Context, msgs []StreamMessage) error {
processed2 += len(msgs)
return nil
}, WithStream("failover:v1:shard:*"), WithBatchSize(5), WithAutoAck(true))
t.Logf("Consumer 2 processed %d messages after takeover", processed2)
// Verify: Total processed = 50, no duplicates, no losses
totalProcessed := processed1 + processed2
if totalProcessed != 50 {
t.Errorf("Expected 50 total messages processed, got %d (consumer1: %d, consumer2: %d)",
totalProcessed, processed1, processed2)
}
// Verify: Consumer 2 processed the remaining messages (no overlap)
if processed2 != (50 - processed1) {
t.Errorf("Expected consumer2 to process %d remaining messages, got %d",
50-processed1, processed2)
}
}
// TestMultiShardConsumerGroup tests consumer group behavior across multiple shards
func TestMultiShardConsumerGroup(t *testing.T) {
dir := t.TempDir()
// Write data to multiple shards using default config (no process restrictions)
client, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
streams := []string{
"multi:v1:shard:0000",
"multi:v1:shard:0001",
"multi:v1:shard:0002",
}
for _, stream := range streams {
var messages [][]byte
for i := 0; i < 30; i++ {
messages = append(messages, []byte(fmt.Sprintf("%s-msg-%03d", stream, i)))
}
ctx := context.Background()
_, err = client.Append(ctx, stream, messages)
if err != nil {
t.Fatal(err)
}
}
// Sync to ensure messages are durable
if err := client.Sync(context.Background()); err != nil {
t.Fatal(err)
}
client.Close()
// Small delay to ensure multi-process state is fully persisted
time.Sleep(100 * time.Millisecond)
// Start 3 consumers in same group - each gets its own process ID
var wg sync.WaitGroup
results := make([]int, 3)
shardAssignments := make([]map[uint32]int, 3) // Track which consumer got which shard
for i := 0; i < 3; i++ {
shardAssignments[i] = make(map[uint32]int)
wg.Add(1)
go func(consumerID int) {
defer wg.Done()
// Each consumer gets its own process ID to avoid race conditions
processConfig := DeprecatedMultiProcessConfig(consumerID, 3)
client, err := NewClient(dir, processConfig)
if err != nil {
t.Errorf("Consumer %d failed: %v", consumerID, err)
return
}
defer client.Close()
consumer := NewConsumer(client, ConsumerOptions{
Group: "multi-shard-group", // Same group
})
defer consumer.Close()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
// Only process shards owned by this process
ownedShards := []uint32{}
for shardID := uint32(0); shardID < 3; shardID++ {
if processConfig.Concurrency.Owns(shardID) {
ownedShards = append(ownedShards, shardID)
}
}
t.Logf("Consumer %d (Process %d) owns shards: %v", consumerID, consumerID, ownedShards)
processed := 0
expectedMessages := 30 // 30 messages per shard, each consumer owns 1 shard
consumer.Process(ctx, func(ctx context.Context, msgs []StreamMessage) error {
for _, msg := range msgs {
shardAssignments[consumerID][msg.ID.ShardID]++
processed++
}
// Cancel context once we've processed all expected messages
if processed >= expectedMessages {
cancel()
}
return nil
}, WithShards(ownedShards...), WithBatchSize(10), WithAutoAck(true))
results[consumerID] = processed
t.Logf("Consumer %d processed %d messages from shards: %v",
consumerID, processed, shardAssignments[consumerID])
}(i)
}
wg.Wait()
// Verify: Total messages = 90 (30 per shard * 3 shards)
total := 0
for _, processed := range results {
total += processed
}
if total != 90 {
t.Errorf("Expected 90 total messages, got %d", total)
}
// Verify: Each shard was assigned to exactly one consumer
shardOwners := make(map[uint32]int) // shardID -> consumerID
for consumerID, shards := range shardAssignments {
for shardID, count := range shards {
if count > 0 {
if existingOwner, exists := shardOwners[shardID]; exists {
t.Errorf("Shard %d assigned to multiple consumers: %d and %d",
shardID, existingOwner, consumerID)
} else {
shardOwners[shardID] = consumerID
}
}
}
}
// Verify: All shards (0,1,2) were assigned
expectedShards := []uint32{0, 1, 2}
for _, shardID := range expectedShards {
if _, assigned := shardOwners[shardID]; !assigned {
t.Errorf("Shard %d was not assigned to any consumer", shardID)
}
}
}
// TestDebugMessageLoss - isolate and debug the 20 missing messages
func TestDebugMessageLoss(t *testing.T) {
dir := t.TempDir()
SetDebug(true)
defer SetDebug(false)
// Write exactly 100 messages
client, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
stream := "debug:v1:shard:0000"
var messages [][]byte
for i := 0; i < 100; i++ {
messages = append(messages, []byte(fmt.Sprintf("debug-msg-%03d", i)))
}
ctx := context.Background()
result, err := client.Append(ctx, stream, messages)
if err != nil {
t.Fatal(err)
}
t.Logf("Append result: %v", result)
// Sync to ensure messages are durable
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
client.Close()
time.Sleep(100 * time.Millisecond)
// Verify data was written
client2, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
length, err := client2.Len(ctx, stream)
if err != nil {
t.Fatal(err)
}
t.Logf("Stream length after write: %d", length)
if length != 100 {
t.Logf("WARNING: Stream length is %d, expected 100. This suggests test isolation issues.", length)
t.Logf("Temp dir: %s", dir)
// Check if there are existing files
files, _ := os.ReadDir(dir)
t.Logf("Directory contents: %d items", len(files))
for _, file := range files {
t.Logf(" - %s", file.Name())
}
}
client2.Close()
// Now try to read all messages with detailed logging
client3, err := NewClient(dir, DefaultCometConfig())
if err != nil {
t.Fatal(err)
}
defer client3.Close()
consumer := NewConsumer(client3, ConsumerOptions{Group: "debug-group"})
defer consumer.Close()
// Read with longer timeout and detailed tracking
ctx2, cancel2 := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel2()
processedMessages := make(map[string]bool)
totalProcessed := 0
batchCount := 0
// Run Process in a goroutine since it's a blocking operation
done := make(chan error, 1)
go func() {
err := consumer.Process(ctx2, func(ctx context.Context, msgs []StreamMessage) error {
batchCount++
t.Logf("BATCH %d: Processing %d messages", batchCount, len(msgs))
for i, msg := range msgs {
msgStr := string(msg.Data)
t.Logf(" Message %d: %s (ID: %s)", i, msgStr, msg.ID.String())
if processedMessages[msgStr] {
t.Errorf("DUPLICATE MESSAGE: %s", msgStr)
}
processedMessages[msgStr] = true
totalProcessed++
}
// Cancel context once we've processed all expected messages
if totalProcessed >= 100 {
cancel2()
}
return nil
}, WithStream("debug:v1:shard:*"), WithBatchSize(10), WithAutoAck(true))
done <- err
}()
// Wait for Process to complete or timeout
select {
case err = <-done:
if err != nil && err != context.Canceled {
t.Errorf("Process failed: %v", err)
}
case <-time.After(15 * time.Second):
t.Error("Test timed out waiting for messages to be processed")
cancel2()
err = <-done // Wait for goroutine to finish
}
t.Logf("Process error: %v", err)
t.Logf("Total processed: %d/100", totalProcessed)
t.Logf("Total batches: %d", batchCount)
// Check which messages are missing
missing := []string{}
for i := 0; i < 100; i++ {
expectedMsg := fmt.Sprintf("debug-msg-%03d", i)
if !processedMessages[expectedMsg] {
missing = append(missing, expectedMsg)
}
}
if len(missing) > 0 {
t.Errorf("MISSING MESSAGES (%d): %v", len(missing), missing)
}
// Check consumer offset state
shard, err := client3.getOrCreateShard(0)
if err != nil {
t.Fatal(err)
}
shard.mu.RLock()
offset := shard.index.ConsumerOffsets["debug-group"]
currentEntry := shard.index.CurrentEntryNumber
shard.mu.RUnlock()
t.Logf("Consumer offset: %d", offset)
t.Logf("Current entry number: %d", currentEntry)
if totalProcessed != 100 {
t.Fatalf("DATA LOSS: Only processed %d/100 messages", totalProcessed)
}
}