Wrong comment in SHA-crypt and derived code

[solardiz]

There should be only one of these per file. Where we have two, the second one is wrong (the code that follows does something else):

./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sha512crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./ztex/fpga-sha512crypt/sha512crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./ztex/fpga-sha256crypt/sha256crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./sha256crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12512hash_fmt_plug.c:		/* For every character in the password add the entire password.  */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */

This was also reported in besser82/libxcrypt#222

[solardiz]

Looks like just one per file here, but we may want to double-check they correspond to code:

opencl/gost94hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/gost12256hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/sm3crypt_kernel.cl:	/* For every character in the password add the entire password. */
opencl/cryptsha256_kernel_DEFAULT.cl:    /* For every character in the password add the entire password. */
opencl/gost12512hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/cryptsha512_kernel_GPU.cl:    /* For every character in the password add the entire password. */
opencl/cryptsha256_kernel_GPU.cl:    /* For every character in the password add the entire password. */
opencl/cryptsha512_kernel_DEFAULT.cl:    /* For every character in the password add the entire password. */

[dchidindu5]

@solardiz Can I work on this too?

[solardiz]

@dchidindu5 Yes, feel free. Thanks.

[dchidindu5]

There should be only one of these per file. Where we have two, the second one is wrong (the code that follows does something else):

./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sha512crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./ztex/fpga-sha512crypt/sha512crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./ztex/fpga-sha256crypt/sha256crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./sha256crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12512hash_fmt_plug.c:		/* For every character in the password add the entire password.  */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */

This was also reported in besser82/libxcrypt#222

Commit

These are the modules with duplicate comments that doesn't correspond to the code beneath it
./sm3crypt_fmt_plug.c:
src/gost12256hash_fmt_plug.c
src/gost94hash_fmt_plug.c

All others where cross checked and it seem to be fine.

[dchidindu5]

Looks like just one per file here, but we may want to double-check they correspond to code:

opencl/gost94hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/gost12256hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/sm3crypt_kernel.cl:	/* For every character in the password add the entire password. */
opencl/cryptsha256_kernel_DEFAULT.cl:    /* For every character in the password add the entire password. */
opencl/gost12512hash_kernel.cl:	/* For every character in the password add the entire password. */
opencl/cryptsha512_kernel_GPU.cl:    /* For every character in the password add the entire password. */
opencl/cryptsha256_kernel_GPU.cl:    /* For every character in the password add the entire password. */
opencl/cryptsha512_kernel_DEFAULT.cl:    /* For every character in the password add the entire password. */

With regards to this, I've fixed it but will be on a different commit and PR

[dchidindu5]

#5962

@solardiz