LGTM, it will be nice to add some test for it. My idea is next:
- have some .Net Framework app that use old version of any Microsoft.Extension. something (that we use) from Main. After it write to consolve AssebmlyVersion
- Load it and validate that application not crashed and loaded expected assembly version
We have customization for IIS test that does not register assemblies in GAC, here we need something similar for non-IIS app. Stating point to look may be: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/test/IntegrationTests/AspNetTests.cs#L59 (Gac.UseLocal).
That test should fail without the fix.
Originally posted by @iskiselev in #4970 (comment)
LGTM, it will be nice to add some test for it. My idea is next:
We have customization for IIS test that does not register assemblies in GAC, here we need something similar for non-IIS app. Stating point to look may be: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/test/IntegrationTests/AspNetTests.cs#L59 (
Gac.UseLocal).That test should fail without the fix.
Originally posted by @iskiselev in #4970 (comment)