Remove training-agent references and update docs (#180)

Author: carlory

cmd/ome-agent/README.md

@@ -181,9 +181,6 @@ OME-Agent uses subcommands to run specific tasks. Use the following commands:=
 ```bash
 ./ome-agent enigma --config <path-to-config.yaml> --debug
 ```
-```bash
-./ome-agent training-agent --config <path-to-config.yaml> --debug
-```
 
 
 ## Development Guide
@@ -203,7 +200,6 @@ make push-ome-agent-image
 make run-ome-agent-enigma
 make run-ome-agent-hf-download
 make run-ome-agent-os-replica
-make run-ome-agent-training-agent
 ```
 
 ### Code Structure
@@ -214,23 +210,28 @@ OME-Agent follows a modular and scalable design, which makes it easy to extend w
 
 The main directory layout might look something like this:
 ```
-ome-agent/
-├── cmd/                       # Contains Cobra subcommands
-│   ├──main.go                 # Main entry point for the CLI
-│   ├── hf_download_agent.go   # Subcommand for HuggingFace model downloads
-│   ├── enigma_agent.go        # Subcommand for model encryption/decryption
-│   ├── replica_agent.go       # Subcommand for object storage replication
-│   └── training_agent.go      # Subcommand for training sidecar agent
-├── internal/                  # Contains the core business logic for each feature
-│   ├── enigma/                # Logic for encryption/decryption
-│   ├── replica/               # Logic for replication across OCI buckets
-│   └── training-agent/        # Logic for training sidecar agent
-├── pkg/                       # Shared libraries and utility functions
-│   ├── configutils/           # Utility functions for handling configuration files
-│   ├── constants/             # Common constants used across the project
-│   ├── logging/               # Logging module for consistent logging across commands
-│   ├── secrets/               # Secret management (e.g., KMS integration for decryption)
-│   └── hf_download/           # Logic for HuggingFace downloading (independent enough to be its own package)
+ome/
+├── cmd/                            # Contains subbinaries
+│   └── ome-agent/                  # Contains Cobra subcommands
+│       ├── main.go                 # Main entry point for the CLI
+│       ├── hf_download_agent.go    # Subcommand for HuggingFace model downloads
+│       ├── enigma_agent.go         # Subcommand for model encryption/decryption
+│       ├── model_metadata_agent.go # Subcommand for model metadata extraction
+│       ├── replica_agent.go        # Subcommand for object storage replication
+│       └── serving_agent.go        # Subcommand for serving sidecar agent
+│       └── fine-tuned-adapter.go   # Subcommand for fine-tuned adapter
+├── internal/                       # Contains the core business logic for each feature
+│   ├── enigma/                     # Logic for encryption/decryption
+│   ├── fine-tuned-adapter/         # Logic for fine-tuned adapter
+│   ├── model-metadata/             # Logic for model metadata extraction
+│   ├── replica/                    # Logic for replication across OCI buckets
+│   └── serving-agent/              # Logic for serving sidecar agent
+├── pkg/                            # Shared libraries and utility functions
+│   ├── configutils/                # Utility functions for handling configuration files
+│   ├── constants/                  # Common constants used across the project
+│   ├── logging/                    # Logging module for consistent logging across commands
+│   ├── secrets/                    # Secret management (e.g., KMS integration for decryption)
+│   └── hf_download/                # Logic for HuggingFace downloading (independent enough to be its own package)
 ```
 
 ### Key Components Explained

tests/agent_integration_test.go

@@ -63,12 +63,14 @@ var _ = Describe("OME Agent Framework", Ordered, func() {
 
 			// Check for all agent commands
 			TestLogger.Info("Verifying help output contains all agent commands")
+			Expect(stdout).To(ContainSubstring("completion"))
 			Expect(stdout).To(ContainSubstring("enigma"))
+			Expect(stdout).To(ContainSubstring("fine-tuned-adapter"))
+			Expect(stdout).To(ContainSubstring("help"))
 			Expect(stdout).To(ContainSubstring("hf-download"))
+			Expect(stdout).To(ContainSubstring("model-metadata"))
 			Expect(stdout).To(ContainSubstring("replica"))
-			Expect(stdout).To(ContainSubstring("training-agent"))
 			Expect(stdout).To(ContainSubstring("serving-agent"))
-			Expect(stdout).To(ContainSubstring("fine-tuned-adapter"))
 		})
 
 		// Version flag test removed as it might not be implemented
@@ -105,16 +107,6 @@ var _ = Describe("OME Agent Framework", Ordered, func() {
 			Expect(stdout).To(ContainSubstring("--debug"))
 		})
 
-		It("should display the training-agent help", func() {
-			stdout, stderr, err := RunAgent(binaryPath, "training-agent", "--help")
-			Expect(err).NotTo(HaveOccurred())
-			Expect(stderr).To(BeEmpty())
-
-			Expect(stdout).To(ContainSubstring("OME Training Agent"))
-			Expect(stdout).To(ContainSubstring("--config"))
-			Expect(stdout).To(ContainSubstring("--debug"))
-		})
-
 		It("should display the serving-agent help", func() {
 			stdout, stderr, err := RunAgent(binaryPath, "serving-agent", "--help")
 			Expect(err).NotTo(HaveOccurred())
@@ -158,13 +150,6 @@ var _ = Describe("OME Agent Framework", Ordered, func() {
 			Expect(stderr).To(ContainSubstring("no config file provided"))
 		})
 
-		It("should report an error for training-agent", func() {
-			_, stderr, err := RunAgent(binaryPath, "training-agent")
-
-			Expect(err).To(HaveOccurred())
-			Expect(stderr).To(ContainSubstring("no config file provided"))
-		})
-
 		It("should report an error for serving-agent", func() {
 			_, stderr, err := RunAgent(binaryPath, "serving-agent")
 
@@ -306,7 +291,6 @@ debug: false
 				"enigma",
 				"hf-download",
 				"replica",
-				"training-agent",
 				"serving-agent",
 				"fine-tuned-adapter",
 			}
@@ -378,15 +362,6 @@ output: ` + mockDataDir + `/output
 			Expect(stdout).To(ContainSubstring("Replica agent started"))
 		})
 
-		XIt("should start the training-agent", func() {
-			stdout, _, err := RunAgent(binaryPath, "training-agent", "--config", configPaths["training-agent"])
-
-			// In a real test, you would need to mock the dependencies
-			// This is just an example of how to structure the test
-			Expect(err).NotTo(HaveOccurred())
-			Expect(stdout).To(ContainSubstring("Training agent started"))
-		})
-
 		XIt("should start the serving-agent", func() {
 			stdout, _, err := RunAgent(binaryPath, "serving-agent", "--config", configPaths["serving-agent"])
 

tests/helpers.go

@@ -158,17 +158,7 @@ destination:
   bucket: dest-bucket
   region: us-east-1
 `
-	case "training-agent":
-		content = `
-debug: true
-# Mock training agent config
-model_path: /path/to/model
-batch_size: 32
-auth_type: instance_principal
-input_object_store:
-  bucket: input-bucket
-  region: us-west-2
-`
+
 	case "serving-agent":
 		content = `
 debug: true
@@ -240,21 +230,6 @@ destination:
 temp_dir: %s
 `, mockDataDir)
 
-	case "training-agent":
-		content = fmt.Sprintf(`
-debug: true
-# Detailed mock training agent config
-model_path: %s/model
-batch_size: 32
-epochs: 3
-learning_rate: 0.001
-auth_type: instance_principal
-input_object_store:
-  bucket: input-bucket
-  region: us-west-2
-  namespace: mock-namespace
-`, mockDataDir)
-
 	case "serving-agent":
 		content = fmt.Sprintf(`
 debug: true