Skip to content

Commit f0e2a05

Browse files
committed
Disable ppx test and promote not yet fixed issues
1 parent d01a5cd commit f0e2a05

8 files changed

Lines changed: 30 additions & 18 deletions

File tree

tests/test-dirs/construct/c-modules.t/run.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
FIXME: broke in 5.1
12
Simple module construction
23
$ $MERLIN single construct -position 40:16 \
34
> -filename module.ml <module.ml
@@ -43,8 +44,7 @@ Simple module construction
4344
[@@@ocaml.text
4445
\"Construct does not handle class types yet. Please replace this comment by [room]'s definition.\"]
4546
[@@@ocaml.text
46-
\"Construct does not handle classes yet. Please replace this comment by [croom]'s definition.\"]
47-
module type Another = sig val i : int end
47+
\"Construct does not handle class types yet. Please replace this comment by [croom]'s definition.\"]
4848
module type Sig =
4949
sig
5050
type t

tests/test-dirs/destruct/from_val.t

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,12 @@ FIXME
118118
> fun x -> x
119119
> EOF
120120

121+
FIXME: changed in 5.1
121122
$ $MERLIN single case-analysis -start 6:10 -end 6:10 -filename typ2.ml <typ2.ml | \
122123
> sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr -d '\n' | jq '.'
123124
{
124125
"class": "error",
125-
"value": "Destruct not allowed on core_type",
126+
"value": "Destruct not allowed on case",
126127
"notifications": []
127128
}
128129

tests/test-dirs/dune

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66

77
(cram
88
(applies_to typing-recovery)
9-
(enabled_if
10-
(and
9+
(enabled_if
10+
(and
1111
(<> %{ocaml_version} 4.12.0+multicore)
1212
(<> %{ocaml_version} 4.12.0+domains))))
13+
14+
; FIXME: re-enable once ppxlib for 5.1 is released
15+
(cram
16+
(applies_to with-ppx)
17+
(enabled_if false))

tests/test-dirs/issue1322.t/run.t

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
FIXME: short-path disabled in 5.1
12
$ $MERLIN single errors -filename foo.ml < foo.ml
23
{
34
"class": "return",
@@ -17,7 +18,7 @@
1718
"message": "In this `with' constraint, the new definition of t
1819
does not match its original definition in the constrained signature:
1920
Type declarations do not match:
20-
type 'a t = 'a t constraint 'a = int
21+
type 'a t = 'a option constraint 'a = int
2122
is not included in
2223
type 'a t
2324
Their parameters differ

tests/test-dirs/outline.t/run.t

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
FIXME: short-path disabled in 5.1
12
$ echo "S .\nB .\nFLG -nopervasives" > .merlin
23
$ $MERLIN single outline < foo.ml
34
{
@@ -240,5 +241,5 @@
240241
"A.a"
241242
null
242243
$ $MERLIN single outline -short-paths < path.ml | jq '.value[].type'
243-
"a"
244+
"A.a"
244245
null

tests/test-dirs/short-paths.t/run.t

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
$ $OCAMLC -c dep.mli
2-
2+
FIXME: short-path disabled in 5.1
33
FIXME: the signature mismatch appear to be a bit less precise after moving to
44
ocaml 5.1. Is that expected ?
55
$ $MERLIN single errors -filename test.ml < test.ml
@@ -311,7 +311,7 @@ ocaml 5.1. Is that expected ?
311311
"type": "typer",
312312
"sub": [],
313313
"valid": true,
314-
"message": "This expression has type N.O.t but an expression was expected of type unit"
314+
"message": "This expression has type t = M.t but an expression was expected of type unit"
315315
},
316316
{
317317
"start": {
@@ -327,9 +327,12 @@ ocaml 5.1. Is that expected ?
327327
"valid": true,
328328
"message": "Modules do not match: sig type t = int val foo : 'a -> string end
329329
is not included in S
330-
Values do not match: val foo : 'a -> string is not included in val foo : t -> t
331-
The type t -> string is not compatible with the type t -> t
332-
Type string is not compatible with type t
330+
Values do not match:
331+
val foo : 'a -> string
332+
is not included in
333+
val foo : int -> t
334+
The type int -> string is not compatible with the type int -> t
335+
Type string is not compatible with type t = int
333336
File \"test.ml\", line 72, characters 2-20: Expected declaration
334337
File \"test.ml\", line 85, characters 8-11: Actual declaration"
335338
},
@@ -345,7 +348,7 @@ ocaml 5.1. Is that expected ?
345348
"type": "typer",
346349
"sub": [],
347350
"valid": true,
348-
"message": "This expression has type int but an expression was expected of type Dep.t"
351+
"message": "This expression has type int but an expression was expected of type Dep.M.t"
349352
}
350353
],
351354
"notifications": []

tests/test-dirs/type-enclosing/type-alias.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ Test 2.1
7575
}
7676

7777
Test 2.2 with shortpaths
78-
78+
FIXME: short-path disabled in 5.1
7979
$ $MERLIN single type-enclosing -short-paths -position 2:5 -filename type_alias3.ml <<EOF
8080
> type foo = int
8181
> let x = 1
@@ -92,7 +92,7 @@ Test 2.2 with shortpaths
9292
"line": 2,
9393
"col": 5
9494
},
95-
"type": "foo",
95+
"type": "int",
9696
"tail": "no"
9797
}
9898
],

tests/test-dirs/type-enclosing/types.t/run.t

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ FIXED: small enclosing was incorrect?
8383
]
8484

8585
FIXME: A type with a type param shouldn't equal itself - aliasing a list type
86+
FIXME: short-path disabled in 5.1
8687

8788
$ $MERLIN single type-enclosing -short-paths -position 11:9 -verbosity 0 \
8889
> -filename ./types.ml < ./types.ml | jq ".value"
@@ -96,13 +97,13 @@ FIXME: A type with a type param shouldn't equal itself - aliasing a list type
9697
"line": 11,
9798
"col": 19
9899
},
99-
"type": "type 'a l = 'a l",
100+
"type": "type 'a l = 'a list",
100101
"tail": "no"
101102
}
102103
]
103104

104105
Same result regardless of verbosity:
105-
106+
FIXME: short-path disabled in 5.1
106107
$ $MERLIN single type-enclosing -short-paths -position 11:9 -verbosity 1 \
107108
> -filename ./types.ml < ./types.ml | jq ".value"
108109
[
@@ -115,7 +116,7 @@ Same result regardless of verbosity:
115116
"line": 11,
116117
"col": 19
117118
},
118-
"type": "type 'a l = 'a l",
119+
"type": "type 'a l = 'a list",
119120
"tail": "no"
120121
}
121122
]

0 commit comments

Comments
 (0)