Skip to content

Commit 052242d

Browse files
author
Tobias
committed
Remove redundant mobile buttons grouping
There's only one button in the group, and the wrapping div messed with the flex box layout
1 parent 4434355 commit 052242d

2 files changed

Lines changed: 7 additions & 10 deletions

File tree

app/styles/base.css

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -718,16 +718,15 @@ html {
718718
}
719719

720720
/* noVNC Touch Device only buttons */
721-
:root:not(.noVNC_connected) #noVNC_mobile_buttons {
721+
:root:not(.noVNC_connected) #noVNC_keyboard_button {
722722
display: none;
723723
}
724724
@media not all and (any-pointer: coarse) {
725-
/* FIXME: The button for the virtual keyboard is the only button in this
726-
group of "mobile buttons". It is bad to assume that no touch
727-
devices have physical keyboards available. Hopefully we can get
728-
a media query for this:
725+
/* FIXME: It is bad to assume that no touch devices have physical
726+
keyboards available. Hopefully we can get a media query
727+
for this:
729728
https://github.com/w3c/csswg-drafts/issues/3871 */
730-
:root.noVNC_connected #noVNC_mobile_buttons {
729+
:root.noVNC_connected #noVNC_keyboard_button {
731730
display: none;
732731
}
733732
}

vnc.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,8 @@
127127
title="Move/Drag viewport">
128128

129129
<!--noVNC touch device only buttons-->
130-
<div id="noVNC_mobile_buttons">
131-
<input type="image" alt="Keyboard" src="app/images/keyboard.svg"
132-
id="noVNC_keyboard_button" class="noVNC_button" title="Show keyboard">
133-
</div>
130+
<input type="image" alt="Keyboard" src="app/images/keyboard.svg"
131+
id="noVNC_keyboard_button" class="noVNC_button" title="Show keyboard">
134132

135133
<!-- Extra manual keys -->
136134
<input type="image" alt="Extra keys" src="app/images/toggleextrakeys.svg"

0 commit comments

Comments
 (0)