Skip to content

Commit 40ca725

Browse files
committed
src: move metrics interval state into EnvList
1 parent 7ef9610 commit 40ca725

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/nsolid/nsolid_api.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ static void calculatePtiles(std::vector<double>* vals, double* med, double* nn);
166166
// any thread have been blocked longer than the threadshold passed to
167167
// OnBlockedLoopHook().
168168
constexpr uint64_t blocked_loop_interval = 100;
169-
std::atomic<uint64_t> gen_ptiles_interval{5000};
170169
constexpr uint64_t datapoints_q_interval = 100;
171170
constexpr size_t datapoints_q_max_size = 100;
172171

@@ -1296,7 +1295,7 @@ void EnvList::UpdateConfig(const nlohmann::json& config) {
12961295
if (it != config.end() && !it->is_null()) {
12971296
// If interval changes, next timer cb the timer is reset.
12981297
uint64_t interval = it->get<uint64_t>();
1299-
gen_ptiles_interval.store(interval, std::memory_order_relaxed);
1298+
gen_ptiles_interval_.store(interval, std::memory_order_relaxed);
13001299
}
13011300

13021301
it = config.find("otlp");
@@ -1762,8 +1761,8 @@ void EnvList::env_list_routine_(ns_thread*, EnvList* envlist) {
17621761
CHECK_EQ(er, 0);
17631762
er = envlist->gen_ptiles_timer_.start(
17641763
gen_ptiles_cb_,
1765-
gen_ptiles_interval.load(std::memory_order_relaxed),
1766-
gen_ptiles_interval.load(std::memory_order_relaxed));
1764+
envlist->gen_ptiles_interval_.load(std::memory_order_relaxed),
1765+
envlist->gen_ptiles_interval_.load(std::memory_order_relaxed));
17671766
CHECK_EQ(er, 0);
17681767
envlist->blocked_loop_timer_.unref();
17691768
envlist->gen_ptiles_timer_.unref();
@@ -1904,7 +1903,8 @@ void EnvList::gen_ptiles_cb_(ns_timer* timer) {
19041903
// Restart timer if interval changed.
19051904
uint64_t interval =
19061905
uv_timer_get_repeat(reinterpret_cast<uv_timer_t*>(timer->base_handle()));
1907-
uint64_t next_interval = gen_ptiles_interval.load(std::memory_order_relaxed);
1906+
uint64_t next_interval =
1907+
envlist->gen_ptiles_interval_.load(std::memory_order_relaxed);
19081908
if (next_interval != interval) {
19091909
int er = envlist->gen_ptiles_timer_.start(
19101910
gen_ptiles_cb_, next_interval, next_interval);

src/nsolid/nsolid_api.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,7 @@ class EnvList {
730730
std::atomic<uint64_t> min_blocked_threshold_ = { UINT64_MAX };
731731
// TODO(trevnorris): Temporary until Console supports streaming metrics
732732
nsuv::ns_timer gen_ptiles_timer_;
733+
std::atomic<uint64_t> gen_ptiles_interval_ = { 5000 };
733734
// exit data
734735
std::atomic<bool> exiting_ = { false };
735736
std::atomic<int> exit_code_;

0 commit comments

Comments
 (0)