Merge branch 'main' into sabrina/manifest-bundle

Author: sabrina-ngrok

.github/actions/build-and-test/action.yaml

@@ -34,15 +34,15 @@ runs:
 
     - name: Build
       shell: bash
-      run: nix develop --command make build
+      run: make build
 
     - name: Test
       shell: bash
-      run: nix develop --command make test
+      run: make test
 
     - name: Build the Docker image
       shell: bash
-      run: nix develop --command make docker-build
+      run: make docker-build
 
     - name: Deploy controller to local cluster
       shell: bash
@@ -57,7 +57,7 @@ runs:
         kubectl create ns e2e || true
 
         # deploy ngrok-op for e2e tests
-        nix develop --command make deploy_for_e2e
+        make deploy_for_e2e
 
     - name: Check if operator is up
       shell: bash
@@ -71,7 +71,7 @@ runs:
     - name: Run e2e tests
       shell: bash
       if: ${{ inputs.run-e2e == 'true' }}
-      run: nix develop --command make e2e-tests
+      run: make e2e-tests
 
     # best effort to remove ngrok k8s resources from cluster
     # this allows our finalizers to delete upstream ngrok API resources too
@@ -80,4 +80,4 @@ runs:
       shell: bash
       if: ${{ always() && inputs.run-e2e == 'true' }}
       run: |
-        nix develop --command make e2e-clean
+        make e2e-clean

.github/actions/nix-setup/action.yaml

@@ -0,0 +1,26 @@
+name: Action - Nix Setup
+description: "Sets up Nix with caching and puts tools in PATH for use in later steps"
+
+runs:
+  using: "composite"
+  steps:
+  - uses: nixbuild/nix-quick-install-action@2c9db80fb984ceb1bcaa77cdda3fdf8cfba92035 # v34
+  - uses: DeterminateSystems/magic-nix-cache-action@b8276522d77f21bf19d3574e5bc99186a6c7aa6c
+  - name: Install direnv
+    shell: bash
+    run: |
+      DIRENV_VERSION="2.37.1"
+      DIRENV_SHA256="1f1b93dd6f38523fde26dfac96151ef9d31a374e3005cd3345fb93555ae0c9b5"
+      curl -sfL "https://github.com/direnv/direnv/releases/download/v${DIRENV_VERSION}/direnv.linux-amd64" -o /tmp/direnv
+      echo "${DIRENV_SHA256}  /tmp/direnv" | sha256sum -c
+      chmod +x /tmp/direnv
+      mkdir -p "$HOME/.local/bin"
+      mv /tmp/direnv "$HOME/.local/bin/direnv"
+      echo "$HOME/.local/bin" >> "$GITHUB_PATH"
+      export PATH="$HOME/.local/bin:$PATH"
+  - name: Allow direnv and export environment variables
+    shell: bash
+    run: |
+      direnv allow .
+      direnv export gha >> "$GITHUB_ENV"
+

.github/agents/README.md

@@ -4,6 +4,39 @@ This directory contains custom GitHub Copilot agents that provide specialized as
 
 ## Available Agents
 
+### Test Agent (`test-agent.agent.md`)
+
+A specialized AI agent with expert knowledge of testing the ngrok Kubernetes Operator. It writes new tests following best practices, finds and fixes flaky tests, and verifies new tests are stable and well-structured.
+
+**What it does:**
+- Writes new tests following Ginkgo v2 / Gomega best practices for this codebase
+- Verifies new tests are stable by running them repeatedly (`--repeat=N`) and with `-race`
+- Reproduces flaky test failures and identifies root causes: missing `Eventually`, race conditions, shared state, insufficient timeouts
+- Prefers fixing test code over production code unless a real bug is demonstrated
+- Confirms fixes are stable by re-running tests multiple times
+
+**How to use it:**
+
+```
+@test-agent write tests for the new MyController in internal/controller/ngrok
+```
+
+```
+@test-agent investigate why TestFooController is flaky
+```
+
+```
+@test-agent verify that the new tests I just added are not flaky
+```
+
+The agent will:
+1. Analyze the code and existing test patterns
+2. Write or fix tests following codebase conventions
+3. Run tests repeatedly to confirm stability
+4. Fix any flakiness found before finishing
+
+---
+
 ### Release Agent (`release-agent.agent.md`)
 
 A specialized AI agent that automates the release process for the ngrok Kubernetes Operator.