Skip to content

Adding test data for Comet#1961

Merged
julianu merged 4 commits intonf-core:modulesfrom
medbioinf:comet-testdata
Mar 31, 2026
Merged

Adding test data for Comet#1961
julianu merged 4 commits intonf-core:modulesfrom
medbioinf:comet-testdata

Conversation

@julianu
Copy link
Copy Markdown

@julianu julianu commented Mar 31, 2026

adding comet params and an mzML conversion of Thermo RAW file for protein identification

Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall OK, but ore information on the source/how each file was generated would be helpful.

@julianu
Copy link
Copy Markdown
Author

julianu commented Mar 31, 2026

@jfy133 I added some more information to the README. Is this sufficient, or more needed?
The sage-file actually was already in the proteomisc path, but no info in the README .

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Mar 31, 2026

@jfy133 I added some more information to the README. Is this sufficient, or more needed?
The sage-file actually was already in the proteomisc path, but no info in the README .

  • Ok if you didn't add the file don't eorry

Looks better now - do you have any info on the sample source the data was generated from? But I recognise these are extra files

@julianu
Copy link
Copy Markdown
Author

julianu commented Mar 31, 2026

I added the information for the files I could find. Somehow they ended up to become default test files in the last years, as they are so small.

@julianu julianu merged commit 0211365 into nf-core:modules Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants