Skip to content

Commit 6b8928f

Browse files
committed
refactor: Don't format code with mdformat by default
Now that we improved our templates to directly output the correct spacing between items, we shouldn't need to format the Markdown with `mdformat` by default. Therefore, we change the default value of the `format_md` parameter to false. This shouldn't be a breaking change for users not passing any value, and users passing true will keep getting their Markdown with `mdformat`. Issue-19: #19
1 parent 3636cab commit 6b8928f

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ classifiers = [
3131
dependencies = [
3232
"griffelib>=2.0",
3333
"jinja2>=3.1.2",
34+
# TODO: Make this an optional dependency at some point.
3435
"mdformat>=0.7.16",
3536
# YORE: EOL 3.10: Remove line.
3637
"tomli>=2.0; python_version < '3.11'",

src/griffe2md/_internal/cli.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@ def get_parser() -> argparse.ArgumentParser:
3737
"""
3838
parser = argparse.ArgumentParser(prog="griffe2md")
3939
parser.add_argument("package", help="The package to output Markdown docs for.")
40+
parser.add_argument(
41+
"-f",
42+
"--format-md",
43+
action="store_true",
44+
help="Whether to format the resulting Markdown using `mdformat`.",
45+
)
4046
parser.add_argument("-o", "--output", default=None, help="File to write to. Default: stdout.")
4147
parser.add_argument("-V", "--version", action="version", version=f"%(prog)s {debug._get_version()}")
4248
parser.add_argument("--debug-info", action=_DebugInfo, help="Print debug information.")
@@ -58,5 +64,5 @@ def main(args: list[str] | None = None) -> int:
5864
opts = parser.parse_args(args=args)
5965
config = load_config()
6066

61-
write_package_docs(opts.package, config, opts.output)
67+
write_package_docs(opts.package, config, opts.output, format_md=opts.format_md)
6268
return 0

src/griffe2md/_internal/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def prepare_env(env: Environment | None = None) -> Environment:
116116
return env
117117

118118

119-
def render_object_docs(obj: Object, config: ConfigDict | None = None, *, format_md: bool = True) -> str:
119+
def render_object_docs(obj: Object, config: ConfigDict | None = None, *, format_md: bool = False) -> str:
120120
"""Render docs for a given object.
121121
122122
Parameters:
@@ -141,7 +141,7 @@ def render_object_docs(obj: Object, config: ConfigDict | None = None, *, format_
141141
return rendered
142142

143143

144-
def render_package_docs(package: str, config: ConfigDict | None = None, *, format_md: bool = True) -> str:
144+
def render_package_docs(package: str, config: ConfigDict | None = None, *, format_md: bool = False) -> str:
145145
"""Render docs for a given package.
146146
147147
Parameters:
@@ -174,7 +174,7 @@ def write_package_docs(
174174
config: ConfigDict | None = None,
175175
output: IO | str | None = None,
176176
*,
177-
format_md: bool = True,
177+
format_md: bool = False,
178178
) -> None:
179179
"""Write docs for a given package to a file or stdout.
180180

tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ def test_load_config(tmpdir: py.path.local, rel_path: Path) -> None:
3030

3131
griffe2md.main(["griffe2md"])
3232

33-
mock_write.assert_called_once_with("griffe2md", expected_config, None)
33+
mock_write.assert_called_once_with("griffe2md", expected_config, None, format_md=False)

0 commit comments

Comments
 (0)