Skip to content

fix(backend): 存在しないActorに対するDeleteアクティビティは無視するように#17294

Merged
syuilo merged 12 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-17293
Apr 11, 2026
Merged

fix(backend): 存在しないActorに対するDeleteアクティビティは無視するように#17294
syuilo merged 12 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-17293

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

Why

Fix #17293

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 9, 2026
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.92%. Comparing base (92e0e8e) to head (908daba).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17294       +/-   ##
============================================
- Coverage    63.79%   14.92%   -48.88%     
============================================
  Files         1162      242      -920     
  Lines       116401    11864   -104537     
  Branches      8455     4014     -4441     
============================================
- Hits         74261     1771    -72490     
+ Misses       39941     7930    -32011     
+ Partials      2199     2163       -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.13 MB 320.09 MB +3.95 MB +1.25%
VmHWM 316.13 MB 320.09 MB +3.95 MB +1.25%
VmSize 23109.35 MB 23115.68 MB +6.33 MB +0.02%
VmData 1380.21 MB 1386.18 MB +5.96 MB +0.43%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.13 MB 320.09 MB +3.95 MB +1.25%
VmHWM 316.13 MB 320.09 MB +3.95 MB +1.25%
VmSize 23109.35 MB 23115.68 MB +6.33 MB +0.02%
VmData 1380.21 MB 1386.18 MB +5.96 MB +0.43%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.46 MB 320.49 MB +4.02 MB +1.27%
VmHWM 316.46 MB 320.49 MB +4.02 MB +1.27%
VmSize 23109.35 MB 23115.68 MB +6.33 MB +0.02%
VmData 1380.21 MB 1386.18 MB +5.96 MB +0.43%

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft April 9, 2026 01:31
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review April 11, 2026 05:36
@syuilo syuilo merged commit 29cecd7 into misskey-dev:develop Apr 11, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Apr 11, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

未知のリモートユーザーの Delete アクティビティで無駄な fetch + deleteAccount が発生する

2 participants