Mark gsl::not_null swap noexcept when possible

Author: MarcoFalke

include/gsl/pointers

@@ -145,14 +145,17 @@ public:
     not_null& operator-=(std::ptrdiff_t) = delete;
     void operator[](std::ptrdiff_t) const = delete;
 
-    void swap(not_null<T>& other) { std::swap(ptr_, other.ptr_); }
+    void swap(not_null<T>& other) noexcept(noexcept(std::swap(std::declval<T&>(), std::declval<T&>())))
+    {
+        std::swap(ptr_, other.ptr_);
+    }
 
 private:
     T ptr_;
 };
 
 template <typename T, std::enable_if_t<std::is_move_assignable<T>::value && std::is_move_constructible<T>::value, bool> = true>
-void swap(not_null<T>& a, not_null<T>& b)
+void swap(not_null<T>& a, not_null<T>& b) noexcept(noexcept(a.swap(b)))
 {
     a.swap(b);
 }

tests/pointers_tests.cpp

@@ -43,6 +43,8 @@ TEST(pointers_test, swap)
         gsl::not_null<std::unique_ptr<int>> a(std::make_unique<int>(0));
         gsl::not_null<std::unique_ptr<int>> b(std::make_unique<int>(1));
 
+        static_assert(noexcept(gsl::swap(a, b)), "not null unique_ptr should be noexcept-swappable");
+
         EXPECT_TRUE(*a == 0);
         EXPECT_TRUE(*b == 1);
 
@@ -62,6 +64,8 @@ TEST(pointers_test, swap)
         gsl::strict_not_null<std::unique_ptr<int>> a{std::make_unique<int>(0)};
         gsl::strict_not_null<std::unique_ptr<int>> b{std::make_unique<int>(1)};
 
+        static_assert(noexcept(gsl::swap(a, b)), "strict not null unique_ptr should be noexcept-swappable");
+
         EXPECT_TRUE(*a == 0);
         EXPECT_TRUE(*b == 1);