Skip to content

test(#10813): stabilize GET attachment integration test and wdio send message test and others#10869

Merged
dianabarsan merged 24 commits intomasterfrom
10813-stabilize-api-test
Apr 16, 2026
Merged

test(#10813): stabilize GET attachment integration test and wdio send message test and others#10869
dianabarsan merged 24 commits intomasterfrom
10813-stabilize-api-test

Conversation

@dianabarsan
Copy link
Copy Markdown
Member

@dianabarsan dianabarsan commented Apr 15, 2026

Description

closes #10813
closes #10858
closes #10495
closes #10881
closes #10873

also minor edits for #10565 nad handling how services are restarted

There is another flake that I tried to address, the audit flake (is there even an issue). I changed one test and added logging in the other, need to understand what is happening there and failures are too infrequent.

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design. Test it has appropriate design for RTL languages.
  • Readable: Concise, well named, follows the style guide
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.
  • AI disclosure: Please disclose use of AI per the guidelines.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
…-test

# Conflicts:
#	tests/integration/api/controllers/db-doc.spec.js
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
…delay duration in server tests

Signed-off-by: Diana Barsan <barsan@medic.org>
… task handling

Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
…try logic in server tests

Signed-off-by: Diana Barsan <barsan@medic.org>
… task handling tests

Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
…ion to iterate over cluster nodes in tests

Signed-off-by: Diana Barsan <barsan@medic.org>
…e the info calculates something?

Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Signed-off-by: Diana Barsan <barsan@medic.org>
Comment thread tests/integration/api/controllers/db-doc.spec.js
Comment thread tests/integration/api/server.spec.js
Comment thread tests/integration/api/server.spec.js
Comment thread webapp/src/ts/modules/messages/messages.component.ts
Comment thread webapp/src/ts/modules/messages/messages.component.ts
@dianabarsan dianabarsan requested a review from jkuester April 16, 2026 13:00
@dianabarsan dianabarsan changed the title test(#10813): stabilize GET attachment integration test and wdio send message test test(#10813): stabilize GET attachment integration test and wdio send message test and others Apr 16, 2026
Copy link
Copy Markdown
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for taking the time to solve these!

That compaction one is particularly WOW!!!

await utils.createUsers([offlineUser]);
await loginPage.login(offlineUser);
await commonPage.hideSnackbar();
// avoid churn from server causing element rerenders, the message component is poorly written.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

};

const getTaskById = (emissionId) => $(`${TASK_LIST_SELECTOR} li[data-record-id="${emissionId}"`);
const getTaskById = (emissionId) => $(`${TASK_LIST_SELECTOR} li[data-record-id="${emissionId}"]`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@dianabarsan dianabarsan merged commit fd7311e into master Apr 16, 2026
57 checks passed
@dianabarsan dianabarsan deleted the 10813-stabilize-api-test branch April 16, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment