Skip to content

Commit c5069dd

Browse files
committed
replace waitForDisplayed with waitForTaskToDisappear in e2e tests for task handling
Signed-off-by: Diana Barsan <[email protected]>
1 parent c6e2a4c commit c5069dd

2 files changed

Lines changed: 17 additions & 8 deletions

File tree

tests/e2e/default/tasks/tasks-group.wdio-spec.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ describe('Tasks group landing page', () => {
167167
await tasksPage.waitForTaskContentLoaded('Home Visit');
168168
const taskElement = await tasksPage.getOpenTaskElement();
169169
await genericForm.submitForm();
170-
await taskElement.waitForDisplayed({ reverse: true });
170+
await tasksPage.waitForTaskToDisappear(taskElement);
171171

172172
// tasks group is displayed
173173
await tasksPage.waitForTasksGroupLoaded();
@@ -198,7 +198,7 @@ describe('Tasks group landing page', () => {
198198
await tasksPage.waitForTaskContentLoaded('Home Visit');
199199
const taskElement = await tasksPage.getOpenTaskElement();
200200
await genericForm.submitForm();
201-
await taskElement.waitForDisplayed({ reverse: true });
201+
await tasksPage.waitForTaskToDisappear(taskElement);
202202
// tasks group is displayed again
203203
await tasksPage.waitForTasksGroupLoaded();
204204
const secondGroupTasks = await tasksPage.getTasksInGroup();
@@ -227,7 +227,7 @@ describe('Tasks group landing page', () => {
227227
await tasksPage.waitForTaskContentLoaded('Place Home Visit');
228228
const taskElement = await tasksPage.getOpenTaskElement();
229229
await genericForm.submitForm();
230-
await taskElement.waitForDisplayed({ reverse: true });
230+
await tasksPage.waitForTaskToDisappear(taskElement);
231231

232232
await tasksPage.waitForTasksGroupLoaded();
233233
const groupTasksAndTitles = await getGroupTasksNamesAndTitles();
@@ -245,7 +245,7 @@ describe('Tasks group landing page', () => {
245245
await tasksPage.waitForTaskContentLoaded('Home Visit');
246246
const taskElement = await tasksPage.getOpenTaskElement();
247247
await genericForm.submitForm();
248-
await taskElement.waitForDisplayed({ reverse: true });
248+
await tasksPage.waitForTaskToDisappear(taskElement);
249249

250250
await tasksPage.waitForTasksGroupLoaded();
251251

@@ -267,7 +267,7 @@ describe('Tasks group landing page', () => {
267267
await tasksPage.waitForTaskContentLoaded('Home Visit');
268268
const taskElementHomeVisit = await tasksPage.getOpenTaskElement();
269269
await genericForm.submitForm();
270-
await taskElementHomeVisit.waitForDisplayed({ reverse: true });
270+
await tasksPage.waitForTaskToDisappear(taskElementHomeVisit);
271271

272272
await tasksPage.waitForTasksGroupLoaded();
273273
const tasksInGroup = await tasksPage.getTasksInGroup();
@@ -279,7 +279,7 @@ describe('Tasks group landing page', () => {
279279
await tasksPage.waitForTaskContentLoaded('Place Home Visit');
280280
const taskElementPlaceHomeVisit = await tasksPage.getOpenTaskElement();
281281
await genericForm.submitForm();
282-
await taskElementPlaceHomeVisit.waitForDisplayed({ reverse: true });
282+
await tasksPage.waitForTaskToDisappear(taskElementPlaceHomeVisit);
283283

284284
const emptySelection = await tasksPage.noSelectedTask();
285285
await (emptySelection).waitForDisplayed();
@@ -293,7 +293,7 @@ describe('Tasks group landing page', () => {
293293
await tasksPage.waitForTaskContentLoaded('Home Visit');
294294
const taskElement = await tasksPage.getOpenTaskElement();
295295
await genericForm.submitForm();
296-
await taskElement.waitForDisplayed({ reverse: true });
296+
await tasksPage.waitForTaskToDisappear(taskElement);
297297

298298
const emptySelection = await tasksPage.noSelectedTask();
299299
await (emptySelection).waitForDisplayed();
@@ -331,7 +331,7 @@ describe('Tasks group landing page', () => {
331331
await tasksPage.waitForTaskContentLoaded('Home Visit');
332332
const taskElement = await tasksPage.getOpenTaskElement();
333333
await genericForm.submitForm();
334-
await taskElement.waitForDisplayed({ reverse: true });
334+
await tasksPage.waitForTaskToDisappear(taskElement);
335335

336336
const emptySelection = await tasksPage.noSelectedTask();
337337
await (emptySelection).waitForDisplayed();

tests/page-objects/default/tasks/tasks.wdio.page.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,14 @@ const getOpenTaskElement = async () => {
8787
return getTaskById(emissionId);
8888
};
8989

90+
const waitForTaskToDisappear = async (taskElement) => {
91+
const selector = taskElement.selector;
92+
await browser.waitUntil(
93+
async () => !(await $(selector).isExisting()),
94+
{ timeout: 10000, timeoutMsg: `Task element ${selector} was not removed from the DOM.` }
95+
);
96+
};
97+
9098
const waitForTasksGroupLoaded = async () => {
9199
await $(TASKS_GROUP_SELECTOR).waitForDisplayed();
92100
await browser.waitUntil(async () => {
@@ -175,6 +183,7 @@ module.exports = {
175183
getTaskInfo,
176184
getTasksListInfos,
177185
getOpenTaskElement,
186+
waitForTaskToDisappear,
178187
waitForTasksGroupLoaded,
179188
getTasksInGroup,
180189
noSelectedTask,

0 commit comments

Comments
 (0)